From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EC64C636D3 for ; Tue, 31 Jan 2023 15:40:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232319AbjAaPkX (ORCPT ); Tue, 31 Jan 2023 10:40:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233258AbjAaPkU (ORCPT ); Tue, 31 Jan 2023 10:40:20 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B495530CA for ; Tue, 31 Jan 2023 07:39:54 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id bg13-20020a05600c3c8d00b003d9712b29d2so12765041wmb.2 for ; Tue, 31 Jan 2023 07:39:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dxmryiaMIfHhWze9/Btzg+33937lzrXECqTVRCjEX6E=; b=HJ+9lvsOIPh4qmmcIksr48LGL5dGzjtiIECJNMLe062na23dnIE/LOX6frZ33/yAg4 hxRATS2jMhgu8IAXK52nvdZM8dhHicFmVmdfqLsnrZl+JcEX34fjKV7VNxvV0t9SnL10 tdwVmaMRZGrMHtq4l5qsbtcr8EFoG2VotSj8l7EqbMfjWEbhfe8icjjXM0K6VQGR2IJs Z8w0PmDLH8oz/RHnzr8oU3fAGNAR465AuNtbcuOqjoNyWoJO830NRgnGg8XR5NEOcJge bjoNbAtLjvsZ5Bs/7ppchTfC8yY3Dtt14sIMNu4kb5i1SQ4gxbmNfApwV/Dw0lTEe1Mu FwcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dxmryiaMIfHhWze9/Btzg+33937lzrXECqTVRCjEX6E=; b=mpq7MM74Ceyw8OgCy8hK5mewWIx+aKmb4RGaHIqHOZDa1XX25CGNIcHvsiSUQ0ECNF ZlMqxJhozobYSgtX/2oXDrSdb9hSraxLOu5HlWZ9fC6Dl/UhIM1IlvV+hY3sxjBnjK0O OQWHNLct4fAAiiTMOx/0uZhlQhfvKHzdl5QqN30bcGA6xfuOQ5M/SvOOqq2cb9MqMTWt 3tCRPr3rsp4gT1rfD/yiBRaErIaeC/xivs7Ts/baw/dJsyq9R18jzv7Wah0O2yZCQSJf 3GAbwEojfZO6DmhtzQpdT6QCOPREPDP1g+X7wSB9QyrlS6IDg8YnbgS7Hi5v8wOQLDot bd+w== X-Gm-Message-State: AO0yUKWetBidbMsZb7Cr4D9/QlGf/5+tQsH23xunYwk7yc5T6I++dsGY xRCTo0DwJtJwJMMYO6oo9Jvtqg== X-Google-Smtp-Source: AK7set+nSv2SvvWrJMSc6LYW4dP/bhR0owoVVEtTGUpAiXM4dWaJmCNI4Iz326T228c6SXJmaVjKgg== X-Received: by 2002:a05:600c:43ca:b0:3dd:6d69:7cda with SMTP id f10-20020a05600c43ca00b003dd6d697cdamr2678989wmn.39.1675179587384; Tue, 31 Jan 2023 07:39:47 -0800 (PST) Received: from [192.168.10.46] (146725694.box.freepro.com. [130.180.211.218]) by smtp.googlemail.com with ESMTPSA id d3-20020adffbc3000000b002bdd155ca4dsm15001584wrs.48.2023.01.31.07.39.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Jan 2023 07:39:46 -0800 (PST) Message-ID: Date: Tue, 31 Jan 2023 16:39:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 4/4] thermal: intel: int340x: Improve int340x_thermal_set_trip_temp() Content-Language: en-US To: "Rafael J. Wysocki" , Linux PM Cc: Linux ACPI , LKML , Srinivas Pandruvada , Zhang Rui References: <2133431.irdbgypaU6@kreacher> <3719164.kQq0lBPeGt@kreacher> From: Daniel Lezcano In-Reply-To: <3719164.kQq0lBPeGt@kreacher> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 30/01/2023 19:47, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Instead of using snprintf() to populate the ACPI object name in > int340x_thermal_set_trip_temp(), use an appropriate initializer > and make the function fail if its trip argument is greater than 9, > because ACPI object names can only be 4 characters long and it does > not make sense to even try to evaluate objects with longer names (that > argument is guaranteed to be non-negative, because it comes from the > thermal code that will not pass negative trip numbers to zone > callbacks). > > Signed-off-by: Rafael J. Wysocki > --- Acked-by: Daniel Lezcano -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog