Re: [rafael-pm:bleeding-edge 9/22] drivers/platform/x86/acer-wmi-battery.c:292:16: error: implicit declaration of function 'devm_battery_hook_register'; did you mean 'acpi_battery_hook_register'?

[Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>]

On 11/11/2026 10:33 AM, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
> head:   51bafe2e7302403a43ba45415bf9a268a7fcaa05
> commit: fafe4f5166bc3d43e28967efb9ea82b1f456b798 [9/22] Merge branch 'acpi-battery' into bleeding-edge
> config: x86_64-randconfig-1011-20261111 (https://download.01.org/0day-ci/archive/20261111/202611111027.YYwIlIDB-lkp@intel.com/config)
> compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261111/202611111027.YYwIlIDB-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202611111027.YYwIlIDB-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>     drivers/platform/x86/acer-wmi-battery.c: In function 'acer_wmi_battery_probe':
>>> drivers/platform/x86/acer-wmi-battery.c:292:16: error: implicit declaration of function 'devm_battery_hook_register'; did you mean 'acpi_battery_hook_register'? [-Wimplicit-function-declaration]
>       292 |         return devm_battery_hook_register(&data->wdev->dev, &data->hook);
>           |                ^~~~~~~~~~~~~~~~~~~~~~~~~~
>           |                acpi_battery_hook_register


I took a quick look at this merge-ordering problem:

devm_battery_hook_register() gained two new callers in v7.4-rc1 while
the rename was still pending:

Old API (devm_battery_hook_register) users:

   c72dd9994952 ("platform/x86: add Acer battery control driver")
     committed:  2026-09-18
     file:       drivers/platform/x86/acer-wmi-battery.c
     branch:     platform-drivers-x86 -> mainline v7.4-rc1

   929433336e0a ("platform/x86: hp-wmi: add charge_behaviour support for 
Spectre 8C15/8C17")
     committed:  2026-10-14
     file:       drivers/platform/x86/hp/hp-wmi.c
     branch:     platform-drivers-x86 -> mainline v7.4-rc1

New API (devm_acpi_battery_hook_register):

   c27a6fd6b403 ("ACPI: battery: add acpi_ prefix to the battery hook
API")
     committed:  2026-11-10
     branch:     linux-pm bleeding-edge (via the acpi-battery branch,
                 based on v7.3-rc2)

(Please note that the robot only reported acer-wmi-battery. The hp-wmi
should fail the same way when CONFIG_HP_WMI is enabled)


> 
> 
> vim +292 drivers/platform/x86/acer-wmi-battery.c
> 
> c72dd9994952eb Jelle van der Waa 2026-09-13  275
> c72dd9994952eb Jelle van der Waa 2026-09-13  276  static int acer_wmi_battery_probe(struct wmi_device *wdev, const void *context)
> c72dd9994952eb Jelle van der Waa 2026-09-13  277  {
> c72dd9994952eb Jelle van der Waa 2026-09-13  278  	struct acer_wmi_battery_data *data;
> c72dd9994952eb Jelle van der Waa 2026-09-13  279
> 4dd10fbbeb9c33 Kees Cook         2026-10-28  280  	data = devm_kzalloc_obj(&wdev->dev, *data);
> c72dd9994952eb Jelle van der Waa 2026-09-13  281  	if (!data)
> c72dd9994952eb Jelle van der Waa 2026-09-13  282  		return -ENOMEM;
> c72dd9994952eb Jelle van der Waa 2026-09-13  283
> c72dd9994952eb Jelle van der Waa 2026-09-13  284  	dev_set_drvdata(&wdev->dev, data);
> c72dd9994952eb Jelle van der Waa 2026-09-13  285  	data->wdev = wdev;
> c72dd9994952eb Jelle van der Waa 2026-09-13  286  	data->battery_ext = health_mode ? &acer_wmi_battery_extension_v2
> c72dd9994952eb Jelle van der Waa 2026-09-13  287  					: &acer_wmi_battery_extension_v1;
> c72dd9994952eb Jelle van der Waa 2026-09-13  288  	data->hook.name = "Acer Battery Extension";
> c72dd9994952eb Jelle van der Waa 2026-09-13  289  	data->hook.add_battery = acer_battery_add;
> c72dd9994952eb Jelle van der Waa 2026-09-13  290  	data->hook.remove_battery = acer_battery_remove;
> c72dd9994952eb Jelle van der Waa 2026-09-13  291
> c72dd9994952eb Jelle van der Waa 2026-09-13 @292  	return devm_battery_hook_register(&data->wdev->dev, &data->hook);
> c72dd9994952eb Jelle van der Waa 2026-09-13  293  }
> c72dd9994952eb Jelle van der Waa 2026-09-13  294
> 
> :::::: The code at line 292 was first introduced by commit
> :::::: c72dd9994952eb09442827caecb945474ae3072b platform/x86: add Acer battery control driver
> 
> :::::: TO: Jelle van der Waa <jelle@vdwaa.nl>
> :::::: CC: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> 
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
> 


-- 
Thx and BRs,
Zhongqiu Han