Re: [PATCH v2] cpupower: Fix no-rounding MHz frequency output

[Prarit Bhargava <prarit@redhat.com>]

On 11/01/2017 06:30 PM, Shuah Khan wrote:
> On 11/01/2017 04:07 PM, Rafael J. Wysocki wrote:
>> On Wed, Nov 1, 2017 at 10:49 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
>>> On 11/01/2017 03:46 PM, Rafael J. Wysocki wrote:
>>>> On Wed, Nov 1, 2017 at 10:38 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
>>>>> On 11/01/2017 03:33 PM, Rafael J. Wysocki wrote:
>>>>>> On Wed, Nov 1, 2017 at 10:00 PM, Shuah Khan <shuah@kernel.org> wrote:
>>>>>>> On 10/25/2017 07:51 AM, Prarit Bhargava wrote:
>>>>>>>> 'cpupower frequency-info -ln' returns kHz values on systems with MHz range
>>>>>>>> minimum CPU frequency range.  For example, on a 800MHz to 4.20GHz system
>>>>>>>> the command returns
>>>>>>>>
>>>>>>>> hardware limits: 800000 MHz - 4.200000 GHz
>>>>>>>>
>>>>>>>> The code that causes this error can be removed.  The next else if clause
>>>>>>>> will handle the output correctly such that
>>>>>>>>
>>>>>>>> hardware limits: 800.000 MHz - 4.200000 GHz
>>>>>>>>
>>>>>>>> is displayed correctly.
>>>>>>>>
>>>>>>>> [v2]: Remove two lines instead of fixing broken code.
>>>>>>>>
>>>>>>>> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
>>>>>>>> Cc: Thomas Renninger <trenn@suse.com>
>>>>>>>> Cc: Stafford Horne <shorne@gmail.com>
>>>>>>>> Cc: Shuah Khan <shuah@kernel.org>
>>>>>>>> ---
>>>>>>>>  tools/power/cpupower/utils/cpufreq-info.c | 2 --
>>>>>>>>  1 file changed, 2 deletions(-)
>>>>>>>>
>>>>>>>> diff --git a/tools/power/cpupower/utils/cpufreq-info.c b/tools/power/cpupower/utils/cpufreq-info.c
>>>>>>>> index 3e701f0e9c14..df43cd45d810 100644
>>>>>>>> --- a/tools/power/cpupower/utils/cpufreq-info.c
>>>>>>>> +++ b/tools/power/cpupower/utils/cpufreq-info.c
>>>>>>>> @@ -93,8 +93,6 @@ static void print_speed(unsigned long speed)
>>>>>>>>               if (speed > 1000000)
>>>>>>>>                       printf("%u.%06u GHz", ((unsigned int) speed/1000000),
>>>>>>>>                               ((unsigned int) speed%1000000));
>>>>>>>> -             else if (speed > 100000)
>>>>>>>> -                     printf("%u MHz", (unsigned int) speed);
>>>>>>>>               else if (speed > 1000)
>>>>>>>>                       printf("%u.%03u MHz", ((unsigned int) speed/1000),
>>>>>>>>                               (unsigned int) (speed%1000));
>>>>>>>>
>>>>>>>
>>>>>>> Thanks.  I will queue this up for 4.15-rc1.
>>>>>>
>>>>>> OK
>>>>>>
>>>>>> So are you going to maintain this utility going forward?
>>>>>>
>>>>>
>>>>> oops. I was on auto-pilot responding to patches sitting in my Inbox.
>>>>> Wrong email response. Sorry about that.
>>>>>
>>>>> Please ignore. Mu bad.
>>>>
>>>> OK :-)
>>>>
>>>> But that said, from my perspective, cpupower is basically not maintained.
>>>>
>>>> Thomas, who sort of maintained it, but then basically became a patch
>>>> reviewer for it, does not respond to patches any more and I am not
>>>> sufficiently familiar with the code to be able to effectively review
>>>> the patches myself, nor I have the time to get more familiar with it.
>>>>
>>>> For this reason, I'm inclined to drop this code from the kernel source
>>>> tree unless somebody steps in to fill the gap.
>>>>
>>>
>>> Please don't drop this from kernel sources.. I think this is useful. If you
>>> are looking for a maintainer, I will be happy to step up to maintain it.
>>
>> Cool, please do that then. :-)
>>
>> I will be happy to take pull requests with cpupower changes so that
>> they go in along with the other PM material.
>>
> 
> Sounds like a plan. I can do that. I will work on getting git setup and
> send pull requests. We can get that going for 4.15 unless you think it is
> late for you to get pull requests.

Shuah, I have two other cleanup patches that should be applied to cpupower.  I
will post them shortly.

P.

> 
> thanks,
> -- Shuah
>