From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC7131AF0C1; Mon, 17 Mar 2025 17:54:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.69.126.157 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742234087; cv=none; b=P8vO1Mpoz6wl5ei45H2X9GdTCn2IIPah96nfAmNVZQj8fS7IP0cSeUicspQQ5stmMHz72ART+QtF8tw3V97HkboEm59cdtswHsLinsjljQpzbRyb0nqUsTtzFzZrBkMkiLzLtrR49oKMxOUfFazpPkz1EPUdUlK6AYPi06SshQ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742234087; c=relaxed/simple; bh=vs9BPFatqmHSxEPncR3Ib1jyEqOzcqlm+rcAreK+Kp8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XQE0tyC0LVomY2JHQI/sSM/kO4KdP/csefNf3kPjyZOu4xR1z2qniU5u0PmFOAnJc+auqKL4b0oxyAPsWGYQk4L+4rIeif0Dj5mDSEDYy+XD5zAfnYvUNi8Cqmpsu0tUqRpr5VJmFZFK8OyEEvdAl4tLBYhH4NhzopPgaVheU2k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net; spf=pass smtp.mailfrom=weissschuh.net; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b=j4M9aRcf; arc=none smtp.client-ip=159.69.126.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b="j4M9aRcf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1742234083; bh=vs9BPFatqmHSxEPncR3Ib1jyEqOzcqlm+rcAreK+Kp8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=j4M9aRcfsUVDA2BY3PtIMvW4v7N6hvMkatebGtvveRNQ4rtVGCP88eNg/5AAfXHwc tIWBh/WOaVM9v1hqEiRZm1Ow4eLjdIQ8SROo3Hy9cPI+runxV8YTuiVIuT3BJ4XVQd /Ts71+O4Pfv9h6OpP8Peqkv76nsFDcUmHJv1+GJg= Date: Mon, 17 Mar 2025 18:54:42 +0100 From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: Antheas Kapenekakis Cc: platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-pm@vger.kernel.org, Guenter Roeck , Jean Delvare , Jonathan Corbet , Joaquin Ignacio Aramendia , Derek J Clark , Kevin Greenberg , Joshua Tam , Parth Menon , Eileen , linux-kernel@vger.kernel.org, sre@kernel.org Subject: Re: [PATCH v5 05/13] platform/x86: oxpec: Rename ec group to tt_toggle Message-ID: References: <20250317155349.1236188-1-lkml@antheas.dev> <20250317155349.1236188-6-lkml@antheas.dev> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250317155349.1236188-6-lkml@antheas.dev> On 2025-03-17 16:53:41+0100, Antheas Kapenekakis wrote: > Currently, the EC group is used for the turbo button. However, the next > patch in the series adds support for the LED button in X1 devices, which > is only applicable for X1 devices. Therefore, rename it to prepare for > adding the second group. > > Reviewed-by: Derek J. Clark > Signed-off-by: Antheas Kapenekakis > --- > drivers/platform/x86/oxpec.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/platform/x86/oxpec.c b/drivers/platform/x86/oxpec.c > index dc3a0871809cd..8836b3df0d57e 100644 > --- a/drivers/platform/x86/oxpec.c > +++ b/drivers/platform/x86/oxpec.c > @@ -681,18 +681,18 @@ static const struct hwmon_channel_info * const oxp_platform_sensors[] = { > NULL, > }; > > -static struct attribute *oxp_ec_attrs[] = { > +static struct attribute *oxp_tt_toggle_attrs[] = { > &dev_attr_tt_toggle.attr, > NULL > }; > > -static struct attribute_group oxp_ec_attribute_group = { > +static struct attribute_group oxp_tt_toggle_attribute_group = { While you touch this anyways it could be made 'const'. > .is_visible = tt_toggle_is_visible, > - .attrs = oxp_ec_attrs, > + .attrs = oxp_tt_toggle_attrs, > }; > > static const struct attribute_group *oxp_ec_groups[] = { > - &oxp_ec_attribute_group, > + &oxp_tt_toggle_attribute_group, > NULL > }; > > -- > 2.48.1 >