Re: [PATCH v3 03/12] platform/x86: oxpec: Move hwmon/oxp-sensors to platform/x86

[Guenter Roeck <linux@roeck-us.net>]

On 3/10/25 16:30, Antheas Kapenekakis wrote:
> On Tue, 11 Mar 2025 at 00:18, Derek John Clark
> <derekjohn.clark@gmail.com> wrote:
>>
>> On Sun, Mar 9, 2025 at 4:21 AM Antheas Kapenekakis <lkml@antheas.dev> wrote:
>>>
>>> The EC of OneXPlayer devices used to only control the fan.
>>> This is no longer the case, with the EC of OneXPlayer gaining
>>> additional functionality (turbo button, turbo led, battery controls).
>>>
>>> As it will be beneficial from a complexity perspective
>>> to retain this driver as a single unit, move it out
>>> of hwmon, and into platform/x86.
>>>
>>> While at it, add myself to the maintainer's file.
>>>
>>> Acked-by: Guenter Roeck <linux@roeck-us.net>
>>> Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
>>> ---
>>>   Documentation/hwmon/index.rst                         |  2 +-
>>>   Documentation/hwmon/{oxp-sensors.rst => oxpec.rst}    |  0
>>>   MAINTAINERS                                           |  7 ++++---
>>>   drivers/hwmon/Kconfig                                 | 11 -----------
>>>   drivers/hwmon/Makefile                                |  1 -
>>>   drivers/platform/x86/Kconfig                          | 11 +++++++++++
>>>   drivers/platform/x86/Makefile                         |  3 +++
>>>   drivers/{hwmon/oxp-sensors.c => platform/x86/oxpec.c} | 10 ++++------
>>>   8 files changed, 23 insertions(+), 22 deletions(-)
>>>   rename Documentation/hwmon/{oxp-sensors.rst => oxpec.rst} (100%)
>>
>> IMO this should also be moved, it doesn't really make sense that hwmon
>> would continue to carry the docs after the move. Platform/x86 doesn't
>> seem to have a home in Documentation, perhaps misc-devices? Armin or
>> Ilpo may have some thoughts here.
> 
> I looked at similar drivers and I think asus-wmi was the same FYI. The
> sensors for it reside in hwmon.
> 

One alternative would be to remove the documentation if there are objections
to keeping it in Documentation/hwmon/. I personally don't see the point, and
I don't agree with the argument above about moving it, but I would not object
either. Many of the hwmon drivers outside hwmon have no documentation, so this
would not be the first one.

Guenter