From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C43DC38D; Fri, 19 Apr 2024 09:42:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713519767; cv=none; b=AZ9pQhGUGEqf9pD4fxJ6uG17M/9whRJVIyC1+P/Boy4hq7ZRNi1OgZXbfEVxUu5qcAiCCFPZYNHw1j3NO16P1OTzjOm0Bdohb4DtUbu081NuB7eM8AwUKMfjhGEHPz49ObVvNrrTOqPYUgrSDfv5s6n9t+j7jTRvwjSbc9zTkHc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713519767; c=relaxed/simple; bh=LYzTc/eaLc+xLzg4IoyEUHl2csluo0qUvLDBP6KWlOs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WPx41pkY4nEFQQa6AXbtE8YOzsnn6YnFhRHLmSvyGbYtbz2jtueW3Ak0zkJAW0IjDLCYjcVmiiyFZPLuR/KVgldTNRZ4Bnd/hEcTwvaf6GNyLv6fhkiN/1vGscftK3fvGDufPJR55EaPqOMKJYvXaxgmZ39GJB/XbfBlheyauWA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 578292F; Fri, 19 Apr 2024 02:43:12 -0700 (PDT) Received: from [10.57.77.69] (unknown [10.57.77.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 280F53F792; Fri, 19 Apr 2024 02:42:42 -0700 (PDT) Message-ID: Date: Fri, 19 Apr 2024 10:42:50 +0100 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 04/16] thermal: gov_bang_bang: Fold thermal_zone_trip_update() into its caller To: "Rafael J. Wysocki" Cc: LKML , Linux PM , Daniel Lezcano , Srinivas Pandruvada References: <13515747.uLZWGnKmhe@kreacher> <3827124.kQq0lBPeGt@kreacher> Content-Language: en-US From: Lukasz Luba In-Reply-To: <3827124.kQq0lBPeGt@kreacher> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/10/24 17:06, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Fold thermal_zone_trip_update() into bang_bang_control() which is the > only caller of it to reduce code size and make it easier to follow. > > No functional impact. > > Signed-off-by: Rafael J. Wysocki > --- > drivers/thermal/gov_bang_bang.c | 75 +++++++++++++++++----------------------- > 1 file changed, 33 insertions(+), 42 deletions(-) > > Index: linux-pm/drivers/thermal/gov_bang_bang.c > =================================================================== > --- linux-pm.orig/drivers/thermal/gov_bang_bang.c > +++ linux-pm/drivers/thermal/gov_bang_bang.c > @@ -13,47 +13,6 @@ > > #include "thermal_core.h" > > -static void thermal_zone_trip_update(struct thermal_zone_device *tz, > - const struct thermal_trip *trip, > - bool crossed_up) > -{ > - struct thermal_instance *instance; > - > - dev_dbg(&tz->device, "Trip%d[temp=%d]:temp=%d:hyst=%d\n", > - thermal_zone_trip_id(tz, trip), trip->temperature, > - tz->temperature, trip->hysteresis); > - > - list_for_each_entry(instance, &tz->thermal_instances, tz_node) { > - if (instance->trip != trip) > - continue; > - > - if (instance->target == THERMAL_NO_TARGET) > - instance->target = 0; > - > - if (instance->target != 0 && instance->target != 1) { > - pr_debug("Unexpected state %ld of thermal instance %s in bang-bang\n", > - instance->target, instance->name); > - > - instance->target = 1; > - } > - > - /* > - * Enable the fan when the trip is crossed on the way up and > - * disable it when the trip is crossed on the way down. > - */ > - if (instance->target == 0 && crossed_up) > - instance->target = 1; > - else if (instance->target == 1 && !crossed_up) > - instance->target = 0; > - > - dev_dbg(&instance->cdev->device, "target=%ld\n", instance->target); > - > - mutex_lock(&instance->cdev->lock); > - instance->cdev->updated = false; /* cdev needs update */ > - mutex_unlock(&instance->cdev->lock); > - } > -} > - > /** > * bang_bang_control - controls devices associated with the given zone > * @tz: thermal_zone_device > @@ -90,7 +49,39 @@ static void bang_bang_control(struct the > > lockdep_assert_held(&tz->lock); > > - thermal_zone_trip_update(tz, trip, crossed_up); > + dev_dbg(&tz->device, "Trip%d[temp=%d]:temp=%d:hyst=%d\n", > + thermal_zone_trip_id(tz, trip), trip->temperature, > + tz->temperature, trip->hysteresis); > + > + list_for_each_entry(instance, &tz->thermal_instances, tz_node) { > + if (instance->trip != trip) > + continue; > + > + if (instance->target == THERMAL_NO_TARGET) > + instance->target = 0; > + > + if (instance->target != 0 && instance->target != 1) { > + pr_debug("Unexpected state %ld of thermal instance %s in bang-bang\n", > + instance->target, instance->name); > + > + instance->target = 1; > + } > + > + /* > + * Enable the fan when the trip is crossed on the way up and > + * disable it when the trip is crossed on the way down. > + */ > + if (instance->target == 0 && crossed_up) > + instance->target = 1; > + else if (instance->target == 1 && !crossed_up) > + instance->target = 0; > + > + dev_dbg(&instance->cdev->device, "target=%ld\n", instance->target); > + > + mutex_lock(&instance->cdev->lock); > + instance->cdev->updated = false; /* cdev needs update */ > + mutex_unlock(&instance->cdev->lock); > + } > > list_for_each_entry(instance, &tz->thermal_instances, tz_node) > thermal_cdev_update(instance->cdev); > > > LGTM Reviewed-by: Lukasz Luba