From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C730C25B6B for ; Thu, 26 Oct 2023 12:22:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230405AbjJZMWN (ORCPT ); Thu, 26 Oct 2023 08:22:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229642AbjJZMWN (ORCPT ); Thu, 26 Oct 2023 08:22:13 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 28A01B9; Thu, 26 Oct 2023 05:22:10 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5205B2F4; Thu, 26 Oct 2023 05:22:51 -0700 (PDT) Received: from [10.57.81.157] (unknown [10.57.81.157]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D11B63F738; Thu, 26 Oct 2023 05:22:08 -0700 (PDT) Message-ID: Date: Thu, 26 Oct 2023 13:22:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/7] Minor cleanup for thermal gov power allocator Content-Language: en-US To: "Rafael J. Wysocki" Cc: linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org, linux-pm@vger.kernel.org, rui.zhang@intel.com References: <20231025192225.468228-1-lukasz.luba@arm.com> From: Lukasz Luba In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 10/26/23 09:54, Rafael J. Wysocki wrote: > On Wed, Oct 25, 2023 at 9:21 PM Lukasz Luba wrote: >> >> Hi all, >> >> The patch set does some small clean up for Intelligent Power Allocator. >> Those changes are not expected to alter the general functionality. They just >> improve the code reading. Only patch 3/7 might improve the use case for >> binding the governor to thermal zone (very unlikely in real products, but >> it's needed for correctness). >> >> The changes are based on top of current PM thermal branch, so with the >> new trip points. >> >> Regards, >> Lukasz >> >> Lukasz Luba (7): >> thermal: gov_power_allocator: Rename trip_max_desired_temperature >> thermal: gov_power_allocator: Setup trip points earlier >> thermal: gov_power_allocator: Check the cooling devices only for >> trip_max >> thermal: gov_power_allocator: Rearrange the order of variables >> thermal: gov_power_allocator: Use shorter variable when possible >> thermal: gov_power_allocator: Remove unneeded local variables >> thermal: gov_power_allocator: Clean needed variables at the beginning >> >> drivers/thermal/gov_power_allocator.c | 123 ++++++++++++++------------ >> 1 file changed, 64 insertions(+), 59 deletions(-) >> >> -- > > The series looks good to me overall, but I'd prefer to make these > changes in the 6.8 cycle, because the 6.7 merge window is around the > corner and there is quite a bit of thermal material in this cycle > already. Thanks for having a look! Yes, I agree, we can wait after the merge window. It just have to be cleaned one day a bit and I postponed this a few times, so no rush ;)