Re: [PATCH v1] thermal: core: Do not fail cdev registration because of invalid initial state

Rafael J. Wysocki
2024-06-06T09:47:57Z

On Thu, Jun 6, 2024 at 5:41 AM srinivas pandruvada
<srinivas.pandruvada@linux.intel.com> wrote:
>
> On Wed, 2024-06-05 at 21:17 +0200, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >
> > It is reported that commit 31a0fa0019b0 ("thermal/debugfs: Pass
> > cooling
> > device state to thermal_debug_cdev_add()") causes the ACPI fan driver
> > to fail probing on some systems which turns out to be due to the _FST
> > control method returning an invalid value until _FSL is first
> > evaluated
> > for the given fan. If this happens, the .get_cur_state() cooling
> > device
> > callback returns an error and __thermal_cooling_device_register()
> > fails
> > as uses that callback after commit 31a0fa0019b0.
> >
> > Arguably, _FST should not return an inavlid
> s/inavlid/invalid

Thanks, I'll fix it up when applying the patch.