linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: rjw@rjwysocki.net
Cc: linaro-kernel@lists.linaro.org, cpufreq@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	nm@ti.com, swarren@wwwdotorg.org, kgene.kim@samsung.com,
	jinchoi@broadcom.com, tianyu.lan@intel.com,
	sebastian.capella@linaro.org, jhbird.choi@samsung.com,
	Viresh Kumar <viresh.kumar@linaro.org>
Subject: [PATCH V6 0/7] cpufreq: suspend early/resume late: dpm_{suspend|resume}()
Date: Mon, 17 Feb 2014 14:55:06 +0530	[thread overview]
Message-ID: <cover.1392629003.git.viresh.kumar@linaro.org> (raw)

This patchset creates/calls cpufreq suspend/resume callbacks from dpm_{suspend|resume}()
for handling suspend/resume of cpufreq governors and core.

There are multiple problems that are fixed by this patch:
- Nishanth Menon (TI) found an interesting problem on his platform, OMAP. His board
  wasn't working well with suspend/resume as calls for removing non-boot CPUs
  was turning out into a call to drivers ->target() which then tries to play
  with regulators. But regulators and their I2C bus were already suspended and
  this resulted in a failure. Many platforms have such problems, samsung, tegra,
  etc.. They solved it with driver specific PM notifiers where they used to
  disable their driver's ->target() routine.
- Lan Tianyu (Intel) & Jinhyuk Choi (Broadcom) found an issue where tunables
  configuration for clusters/sockets with non-boot CPUs was getting lost after
  suspend/resume, as we were notifying governors with CPUFREQ_GOV_POLICY_EXIT on
  removal of the last cpu for that policy and so deallocating memory for
  tunables.  This is fixed by this patch as we don't allow any operation on
  governors after device suspend and before device resume now.

This is already tested by few people and so incorporating their Tested-by as
well.

I have tested this again on latest stuff on my thinkpad for several
suspend/resume cycles.

V6->V7:
- Fixed crash reported by S.Warren on systems without a cpufreq driver.
- Moved some function doc-comments to patch 1 from a later patch.

For-v3.15

Viresh Kumar (7):
  cpufreq: suspend governors on system suspend/hibernate
  cpufreq: suspend governors from dpm_{suspend|resume}()
  cpufreq: call driver's suspend/resume for each policy
  cpufreq: Implement cpufreq_generic_suspend()
  cpufreq: exynos: Use cpufreq_generic_suspend()
  cpufreq: s5pv210: Use cpufreq_generic_suspend()
  cpufreq: Tegra: Use cpufreq_generic_suspend()

 drivers/base/power/main.c         |   5 ++
 drivers/cpufreq/cpufreq.c         | 137 +++++++++++++++++++++++---------------
 drivers/cpufreq/exynos-cpufreq.c  |  96 ++------------------------
 drivers/cpufreq/s5pv210-cpufreq.c |  49 +-------------
 drivers/cpufreq/tegra-cpufreq.c   |  46 ++-----------
 include/linux/cpufreq.h           |  11 +++
 6 files changed, 113 insertions(+), 231 deletions(-)

-- 
1.7.12.rc2.18.g61b472e

             reply	other threads:[~2014-02-17  9:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-17  9:25 Viresh Kumar [this message]
2014-02-17  9:25 ` [PATCH V6 1/7] cpufreq: suspend governors on system suspend/hibernate Viresh Kumar
2014-02-17  9:25 ` [PATCH V6 2/7] cpufreq: suspend governors from dpm_{suspend|resume}() Viresh Kumar
2014-03-02  0:01   ` Rafael J. Wysocki
2014-02-17  9:25 ` [PATCH V6 3/7] cpufreq: call driver's suspend/resume for each policy Viresh Kumar
2014-03-02  0:02   ` Rafael J. Wysocki
2014-02-17  9:25 ` [PATCH V6 4/7] cpufreq: Implement cpufreq_generic_suspend() Viresh Kumar
2014-02-17  9:25 ` [PATCH V6 5/7] cpufreq: exynos: Use cpufreq_generic_suspend() Viresh Kumar
2014-02-17  9:25 ` [PATCH V6 6/7] cpufreq: s5pv210: " Viresh Kumar
2014-02-17  9:25 ` [PATCH V6 7/7] cpufreq: Tegra: " Viresh Kumar
2014-02-18 20:30 ` [PATCH V6 0/7] cpufreq: suspend early/resume late: dpm_{suspend|resume}() Stephen Warren
2014-02-18 22:36   ` Rafael J. Wysocki
2014-02-18 22:26     ` Stephen Warren
2014-02-18 23:31       ` Rafael J. Wysocki
2014-02-24  6:44 ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1392629003.git.viresh.kumar@linaro.org \
    --to=viresh.kumar@linaro.org \
    --cc=cpufreq@vger.kernel.org \
    --cc=jhbird.choi@samsung.com \
    --cc=jinchoi@broadcom.com \
    --cc=kgene.kim@samsung.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=rjw@rjwysocki.net \
    --cc=sebastian.capella@linaro.org \
    --cc=swarren@wwwdotorg.org \
    --cc=tianyu.lan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).