From: Viresh Kumar <viresh.kumar@linaro.org>
To: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Amit Daniel Kachhap <amit.kachhap@gmail.com>,
Amit Kucheria <amitk@kernel.org>, Ben Segall <bsegall@google.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Javi Merino <javi.merino@kernel.org>,
Juri Lelli <juri.lelli@redhat.com>, Mel Gorman <mgorman@suse.de>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Steven Rostedt <rostedt@goodmis.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Zhang Rui <rui.zhang@intel.com>
Cc: linux-kernel@vger.kernel.org, Quentin Perret <qperret@google.com>,
Lukasz Luba <lukasz.luba@arm.com>,
linux-pm@vger.kernel.org
Subject: [PATCH V2 0/2] cpufreq_cooling: Get effective CPU utilization from scheduler
Date: Fri, 23 Oct 2020 15:50:19 +0530 [thread overview]
Message-ID: <cover.1603448113.git.viresh.kumar@linaro.org> (raw)
Hi Peter/Rafael,
I thought about the fallback thing getting registered by scheduler with
cpufreq core, and after Peter's comment about two interactions with
cpufreq I didn't like it much. Either way we are exposing the cpu
utilization finding algorithm to rest of the kernel, through cpufreq or
otherwise.
And so kept it simple for now. Scheduler exposes a single routine,
sched_cpu_util(), along with the related enum and that's all schedutil
and cpufreq_cooling stuff want.
V1->V2:
- Name the routine as sched_cpu_util().
- Make it more self sufficient and remove few parameters that aren't
required to be exposed anymore to rest of the kernel.
- Better cleanups in schedutil and cpufreq_cooling.
---
Schedutil and fair.c use schedutil_cpu_util() to get an idea of how busy
a CPU is. Do the same for cpufreq_cooling which uses CPU's idle time
currently to get load, which is used to calculate the current power
consumption of the CPUs, which isn't that accurate.
Tested with hackbench and sysbench on Hikey (octa-core SMP) and no
regression was observed.
--
Viresh
Viresh Kumar (2):
sched/core: Rename and move schedutil_cpu_util() to core.c
thermal: cpufreq_cooling: Reuse sched_cpu_util()
drivers/thermal/cpufreq_cooling.c | 70 +++++-------------
include/linux/sched.h | 19 +++++
kernel/sched/core.c | 113 +++++++++++++++++++++++++++++
kernel/sched/cpufreq_schedutil.c | 116 +-----------------------------
kernel/sched/fair.c | 6 +-
kernel/sched/sched.h | 29 +-------
6 files changed, 156 insertions(+), 197 deletions(-)
--
2.25.0.rc1.19.g042ed3e048af
next reply other threads:[~2020-10-23 10:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 10:20 Viresh Kumar [this message]
2020-10-23 10:20 ` [PATCH V2 1/2] sched/core: Rename and move schedutil_cpu_util() to core.c Viresh Kumar
2020-10-23 10:34 ` Peter Zijlstra
2020-10-23 10:54 ` Viresh Kumar
2020-10-23 11:08 ` Lukasz Luba
2020-10-23 12:34 ` Vincent Guittot
2020-10-28 5:49 ` Viresh Kumar
2020-10-23 10:43 ` Vincent Guittot
2020-10-23 10:55 ` Viresh Kumar
2020-10-23 10:20 ` [PATCH V2 2/2] thermal: cpufreq_cooling: Reuse sched_cpu_util() Viresh Kumar
2020-10-23 10:37 ` Peter Zijlstra
2020-11-12 9:41 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1603448113.git.viresh.kumar@linaro.org \
--to=viresh.kumar@linaro.org \
--cc=amit.kachhap@gmail.com \
--cc=amitk@kernel.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=javi.merino@kernel.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=rjw@rjwysocki.net \
--cc=rostedt@goodmis.org \
--cc=rui.zhang@intel.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).