linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Nishanth Menon <nm@ti.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Stephen Boyd <sboyd@kernel.org>,
	Viresh Kumar <vireshk@kernel.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
	linux-pm@vger.kernel.org,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dmitry Osipenko <dmitry.osipenko@collabora.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH V2 0/5] OPP: Replace custom set_opp() with config_regulators()
Date: Fri,  1 Jul 2022 14:04:50 +0530	[thread overview]
Message-ID: <cover.1656664183.git.viresh.kumar@linaro.org> (raw)

Hi,

Currently the custom set_opp() helper, which is implemented only for OMAP, is
responsible to set both clock and regulators for the device and may end up doing
tricky stuff behind the scene. This makes the OPP core contain special code to
support it.

This patch series tries to streamline the code path in _set_opp() in the OPP
core and minimize the platform specific code within it. The platforms provide a
config_regulators() callback now, from which they should only program the
regulators in their preferred sequence. Rest of the code sequence to program
clk, bw, required-opps, etc is common across all device and platform types and
is present in the OPP core.

Keerthy/Dave: I couldn't test it on omap, can any of you do that please ? It
builds just fine though. Also maybe you can simplify the OPP driver to drop all
restoration logic on failures, as the OPP core doesn't do any of it as well. I
can add a patch for that if you guys are fine with it.

This is pushed here along with other dependencies:

git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git opp/linux-next

V1->V2:
- Moved back to 80 column width instead of 100.
- Rebased over updated set-config API changes, which forced minor changes to
  this series as well.

Thanks.

--
Viresh

Viresh Kumar (5):
  OPP: Add support for config_regulators() helper
  OPP: Make _generic_set_opp_regulator() a config_regulators() interface
  OPP: Add dev_pm_opp_get_supplies()
  OPP: ti: Migrate to config_regulators()
  OPP: Remove custom OPP helper support

 drivers/opp/core.c          | 218 +++++++++++++-----------------------
 drivers/opp/opp.h           |   9 +-
 drivers/opp/ti-opp-supply.c |  74 ++++++------
 include/linux/pm_opp.h      |  46 ++------
 4 files changed, 125 insertions(+), 222 deletions(-)

-- 
2.31.1.272.g89b43f80a514


             reply	other threads:[~2022-07-01  8:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-01  8:34 Viresh Kumar [this message]
2022-07-01  8:34 ` [PATCH V2 1/5] OPP: Add support for config_regulators() helper Viresh Kumar
2022-07-01  8:34 ` [PATCH V2 2/5] OPP: Make _generic_set_opp_regulator() a config_regulators() interface Viresh Kumar
2022-07-01  8:34 ` [PATCH V2 3/5] OPP: Add dev_pm_opp_get_supplies() Viresh Kumar
2022-07-01  8:34 ` [PATCH V2 4/5] OPP: ti: Migrate to config_regulators() Viresh Kumar
2022-07-01  8:34 ` [PATCH V2 5/5] OPP: Remove custom OPP helper support Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1656664183.git.viresh.kumar@linaro.org \
    --to=viresh.kumar@linaro.org \
    --cc=dmitry.osipenko@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=rafael@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).