From: Perry Yuan <perry.yuan@amd.com>
To: <Mario.Limonciello@amd.com>, <gautham.shenoy@amd.com>,
<Borislav.Petkov@amd.com>
Cc: <rafael.j.wysocki@intel.com>, <viresh.kumar@linaro.org>,
<Alexander.Deucher@amd.com>, <Xinmei.Huang@amd.com>,
<Xiaojian.Du@amd.com>, <Li.Meng@amd.com>,
<linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v11 0/9] AMD Pstate Driver Core Performance Boost
Date: Thu, 13 Jun 2024 15:25:12 +0800 [thread overview]
Message-ID: <cover.1718262992.git.perry.yuan@amd.com> (raw)
Hi all,
The patchset series implement CPB(core performance boost) feature for AMD pstate
driver including passisve ,guide and active mode support.
User can change global core frequency boost control with a new sysfs entry:
"/sys/devices/system/cpu/amd_pstate/cpb_boost"
Now it also support to update indivial CPU boost state in sysfs boost file.
"/sys/devices/system/cpu/cpuX/cpufreq/boost"
And global control will override the indivial CPU boost state by default.
1) globally disable core boost:
$ sudo bash -c "echo 0 > /sys/devices/system/cpu/amd_pstate/cpb_boost"
$ lscpu -ae
CPU NODE SOCKET CORE L1d:L1i:L2:L3 ONLINE MAXMHZ MINMHZ MHZ
0 0 0 0 0:0:0:0 yes 4201.0000 400.0000 2983.578
1 0 0 1 1:1:1:0 yes 4201.0000 400.0000 2983.578
2 0 0 2 2:2:2:0 yes 4201.0000 400.0000 2583.855
3 0 0 3 3:3:3:0 yes 4201.0000 400.0000 2983.578
4 0 0 4 4:4:4:0 yes 4201.0000 400.0000 2983.578
2) globally enable core boost:
$ sudo bash -c "echo 1 > /sys/devices/system/cpu/amd_pstate/cpb_boost"
$ lscpu -ae
0 0 0 0 0:0:0:0 yes 5759.0000 400.0000 2983.578
1 0 0 1 1:1:1:0 yes 5759.0000 400.0000 2983.578
2 0 0 2 2:2:2:0 yes 5759.0000 400.0000 2983.578
3 0 0 3 3:3:3:0 yes 5759.0000 400.0000 2983.578
4 0 0 4 4:4:4:0 yes 5759.0000 400.0000 2983.578
============================================================================
The V9 patches add per CPU boost control, user can enable/disable CPUs boost
as the below command tested on a laptop system.
# before
CPU NODE SOCKET CORE L1d:L1i:L2:L3 ONLINE MAXMHZ MINMHZ MHZ
0 0 0 0 0:0:0:0 yes 4208.0000 400.0000 1666.7740
1 0 0 0 0:0:0:0 yes 4208.0000 400.0000 400.0000
2 0 0 1 1:1:1:0 yes 4208.0000 400.0000 3386.1260
3 0 0 1 1:1:1:0 yes 4208.0000 400.0000 400.0000
$ sudo rdmsr 0xc00102b3 -p 0
10a6
$ sudo bash -c "echo 1 > /sys/devices/system/cpu/cpu0/cpufreq/boost"
# after
CPU NODE SOCKET CORE L1d:L1i:L2:L3 ONLINE MAXMHZ MINMHZ MHZ
0 0 0 0 0:0:0:0 yes 3501.0000 400.0000 400.0000
1 0 0 0 0:0:0:0 yes 4208.0000 400.0000 1391.0690
2 0 0 1 1:1:1:0 yes 4208.0000 400.0000 3654.4541
3 0 0 1 1:1:1:0 yes 4208.0000 400.0000 400.0000
$ sudo rdmsr 0xc00102b3 -p 0
108a
rebasd to keep syncing to Mario kernel tree: bleeding-edge
https://git.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git
Tested result:
CPU NODE SOCKET CORE L1d:L1i:L2:L3 ONLINE MAXMHZ MINMHZ MHZ
0 0 0 0 0:0:0:0 yes 4354.0000 400.0000 1110.7140
1 0 0 0 0:0:0:0 yes 4354.0000 400.0000 1110.7140
2 0 0 1 1:1:1:0 yes 4354.0000 400.0000 1110.7140
3 0 0 1 1:1:1:0 yes 4354.0000 400.0000 3110.0000
4 0 0 2 2:2:2:0 yes 4354.0000 400.0000 2732.3569
5 0 0 2 2:2:2:0 yes 4354.0000 400.0000 1110.7140
6 0 0 3 3:3:3:0 yes 4354.0000 400.0000 1110.7140
7 0 0 3 3:3:3:0 yes 4354.0000 400.0000 1110.7140
8 0 0 4 4:4:4:0 yes 4354.0000 400.0000 2312.2109
9 0 0 4 4:4:4:0 yes 4354.0000 400.0000 1110.7140
10 0 0 5 5:5:5:0 yes 4354.0000 400.0000 2310.1011
11 0 0 5 5:5:5:0 yes 4354.0000 400.0000 1110.7140
sudo bash -c "echo 0 > /sys/devices/system/cpu/cpu11/cpufreq/boost"
sudo bash -c "echo 0 > /sys/devices/system/cpu/cpu10/cpufreq/boost"
sudo bash -c "echo 0 > /sys/devices/system/cpu/cpu9/cpufreq/boost"
CPU NODE SOCKET CORE L1d:L1i:L2:L3 ONLINE MAXMHZ MINMHZ MHZ
0 0 0 0 0:0:0:0 yes 4354.0000 400.0000 1242.7240
1 0 0 0 0:0:0:0 yes 4354.0000 400.0000 1110.7140
2 0 0 1 1:1:1:0 yes 4354.0000 400.0000 2754.5710
3 0 0 1 1:1:1:0 yes 4354.0000 400.0000 2659.8159
4 0 0 2 2:2:2:0 yes 4354.0000 400.0000 2308.9929
5 0 0 2 2:2:2:0 yes 4354.0000 400.0000 1110.7140
6 0 0 3 3:3:3:0 yes 4354.0000 400.0000 1110.7140
7 0 0 3 3:3:3:0 yes 4354.0000 400.0000 1110.7140
8 0 0 4 4:4:4:0 yes 4354.0000 400.0000 1110.7140
9 0 0 4 4:4:4:0 yes 2801.0000 400.0000 1110.7140
10 0 0 5 5:5:5:0 yes 2801.0000 400.0000 1110.7140
11 0 0 5 5:5:5:0 yes 2801.0000 400.0000 1110.7140
sudo bash -c "echo 0 > /sys/devices/system/cpu/amd_pstate/cpb_boost"
CPU NODE SOCKET CORE L1d:L1i:L2:L3 ONLINE MAXMHZ MINMHZ MHZ
0 0 0 0 0:0:0:0 yes 2801.0000 400.0000 1233.8630
1 0 0 0 0:0:0:0 yes 2801.0000 400.0000 1110.7140
2 0 0 1 1:1:1:0 yes 2801.0000 400.0000 2714.4851
3 0 0 1 1:1:1:0 yes 2801.0000 400.0000 2732.3569
4 0 0 2 2:2:2:0 yes 2801.0000 400.0000 2564.2639
5 0 0 2 2:2:2:0 yes 2801.0000 400.0000 1110.7140
6 0 0 3 3:3:3:0 yes 2801.0000 400.0000 2732.3569
7 0 0 3 3:3:3:0 yes 2801.0000 400.0000 1110.7140
8 0 0 4 4:4:4:0 yes 2801.0000 400.0000 1233.8660
9 0 0 4 4:4:4:0 yes 2801.0000 400.0000 1110.7140
10 0 0 5 5:5:5:0 yes 2801.0000 400.0000 1233.6630
11 0 0 5 5:5:5:0 yes 2801.0000 400.0000 1233.5050
sudo bash -c "echo 1 > /sys/devices/system/cpu/amd_pstate/cpb_boost"
CPU NODE SOCKET CORE L1d:L1i:L2:L3 ONLINE MAXMHZ MINMHZ MHZ
0 0 0 0 0:0:0:0 yes 4354.0000 400.0000 1234.0200
1 0 0 0 0:0:0:0 yes 4354.0000 400.0000 1110.7140
2 0 0 1 1:1:1:0 yes 4354.0000 400.0000 1110.7140
3 0 0 1 1:1:1:0 yes 4354.0000 400.0000 1110.7140
4 0 0 2 2:2:2:0 yes 4354.0000 400.0000 1110.7140
5 0 0 2 2:2:2:0 yes 4354.0000 400.0000 1110.7140
6 0 0 3 3:3:3:0 yes 4354.0000 400.0000 2278.8491
7 0 0 3 3:3:3:0 yes 4354.0000 400.0000 2732.3569
8 0 0 4 4:4:4:0 yes 4354.0000 400.0000 1110.7140
9 0 0 4 4:4:4:0 yes 4354.0000 400.0000 1110.7140
10 0 0 5 5:5:5:0 yes 4354.0000 400.0000 2353.0449
11 0 0 5 5:5:5:0 yes 4354.0000 400.0000 1110.7140
Perry.
Changes from v10:
* rework the boost interface with cpufreq core boost control, align the sysfs file
created from cpufreq.c and allow indivial CPU boost control (Mario)
* fix the pr_warn code format with %zd (Oleksandr Natalenko)
* replace sscanf with kstrtobool for cpufreq.c (new)
* drop the boost sysfs file creation from amd pstate patch #6
* add init_boost for cpufreq.c to unify the boost file creation(Mario)
* add set_boost callback for EPP driver mode
* fix syncronization issue for indivial boost control and global CPB control, now the
two control way will keep syncronization after anyone CPU boost state changed.
* rebased to Mario kernel tree: bleeding-edge
* run testing on local system, no regression issue found so far.
Changes from v9:
* change per CPU boost sysfs file name to `boost` (Mario)
* rebased to latest linux-pm/bleeding-edge
Changes from v8:
* pick RB flag for patch 4 (Mario)
* change boot_cpu_has to cpu_feature_enabled for patch 2 (Boris)
* merge patch 6 into patch 3 (Mario)
* add two patch for per CPU boost control patch 6 & 7(Mario)
* rebased to latest linux-pm/bleeding-edge
Changes from v7:
* fix the mutext locking issue in the sysfs file update(Ray, Mario)
* pick ack flag from Ray
* use X86_FEATURE_CPB to verify the CPB function in Patch #2(Ray)
* rerun the testing to check function works well
* rebased to linux-pm/bleeding-edge latest
Changes from v6:
* reword patch 2 commit log (Gautham)
* update cover letter description(Gautham)
* rebase to kernel v6.9-rc5
Changes from v4:
* drop the legacy boost remove patch, let us keep the legacy interface
in case some applications break.
* rebase to linux-pm/bleeding-edge branch
* rework the patchset base on [PATCH v8 0/8] AMD Pstate Fixes And
Enhancements which has some intial work done there.
Changes from v4:
* move MSR_K7_HWCR_CPB_DIS_BIT into msr-index.h
* pick RB flag from Gautham R. Shenoy
* add Cc Oleksandr Natalenko <oleksandr@natalenko.name>
* rebase to latest linux-pm/bleeding-edge branch
* rebase the patch set on top of [PATCH v7 0/6] AMD Pstate Fixes And Enhancements
* update [PATCH v7 2/6] to use MSR_K7_HWCR_CPB_DIS_BIT
Changes from v3:
* rebased to linux-pm/bleeding-edge v6.8
* rename global to amd_pstate_global_params(Oleksandr Natalenko)
* remove comments for boot_supported in amd_pstate.h
* fix the compiler warning for amd-pstate-ut.ko
* use for_each_online_cpu in cpb_boost_store which fix the null pointer
error during testing
* fix the max frequency value to be KHz when cpb boost disabled(Gautham R. Shenoy)
Changes from v2:
* move global struct to amd-pstate.h
* fix the amd-pstate-ut with new cpb control interface
Changes from v1:
* drop suspend/resume fix patch 6/7 because of the fix should be in
another fix series instead of CPB feature
* move the set_boost remove patch to the last(Mario)
* Fix commit info with "Closes:" (Mario)
* simplified global.cpb_supported initialization(Mario)
* Add guide mode support for CPB control
* Fixed some Doc typos and add guide mode info to Doc as well.
v1: https://lore.kernel.org/all/cover.1706255676.git.perry.yuan@amd.com/
v2: https://lore.kernel.org/lkml/cover.1707047943.git.perry.yuan@amd.com/
v3: https://lore.kernel.org/lkml/cover.1707297581.git.perry.yuan@amd.com/
v4: https://lore.kernel.org/lkml/cover.1710322310.git.perry.yuan@amd.com/
v5: https://lore.kernel.org/lkml/cover.1710473712.git.perry.yuan@amd.com/
v6: https://lore.kernel.org/lkml/cover.1710754236.git.perry.yuan@amd.com/
v7: https://lore.kernel.org/lkml/cover.1713861200.git.perry.yuan@amd.com/
v8: https://lore.kernel.org/lkml/cover.1714112854.git.perry.yuan@amd.com/
v9: https://lore.kernel.org/lkml/cover.1714989803.git.perry.yuan@amd.com/
v10: https://lore.kernel.org/lkml/cover.1715152592.git.perry.yuan@amd.com/
Perry Yuan (9):
cpufreq: acpi: move MSR_K7_HWCR_CPB_DIS_BIT into msr-index.h
cpufreq: simplify boolean parsing with kstrtobool in store function
cpufreq: introduce init_boost callback to initialize boost state for
pstate drivers
cpufreq: amd-pstate: initialize new core precision boost state
cpufreq: amd-pstate: implement cpb_boost sysfs entry for boost control
cpufreq: amd-pstate: Add set_boost callback for active mode
cpufreq: amd-pstate: fix the MSR highest perf will be reset issue
while cpb boost off
Documentation: cpufreq: amd-pstate: introduce the new cpu boost
control method
Documentation: cpufreq: amd-pstate: update doc for Per CPU boost
control method
Documentation/admin-guide/pm/amd-pstate.rst | 30 +++
arch/x86/include/asm/msr-index.h | 2 +
drivers/cpufreq/acpi-cpufreq.c | 2 -
drivers/cpufreq/amd-pstate-ut.c | 2 +-
drivers/cpufreq/amd-pstate.c | 197 +++++++++++++++++---
drivers/cpufreq/amd-pstate.h | 14 ++
drivers/cpufreq/cpufreq.c | 23 ++-
include/linux/cpufreq.h | 2 +
8 files changed, 237 insertions(+), 35 deletions(-)
--
2.34.1
next reply other threads:[~2024-06-13 7:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 7:25 Perry Yuan [this message]
2024-06-13 7:25 ` [PATCH v11 1/9] cpufreq: acpi: move MSR_K7_HWCR_CPB_DIS_BIT into msr-index.h Perry Yuan
2024-06-13 7:25 ` [PATCH v11 2/9] cpufreq: simplify boolean parsing with kstrtobool in store function Perry Yuan
2024-06-13 17:55 ` Mario Limonciello
2024-06-13 7:25 ` [PATCH v11 3/9] cpufreq: introduce init_boost callback to initialize boost state for pstate drivers Perry Yuan
2024-06-13 17:55 ` Mario Limonciello
2024-06-14 2:43 ` Yuan, Perry
2024-06-19 3:46 ` Yuan, Perry
2024-06-13 7:25 ` [PATCH v11 4/9] cpufreq: amd-pstate: initialize new core precision boost state Perry Yuan
2024-06-13 17:55 ` Mario Limonciello
2024-06-14 3:32 ` Yuan, Perry
2024-06-13 7:25 ` [PATCH v11 5/9] cpufreq: amd-pstate: implement cpb_boost sysfs entry for boost control Perry Yuan
2024-06-13 17:55 ` Mario Limonciello
2024-06-14 2:32 ` Yuan, Perry
2024-06-13 7:25 ` [PATCH v11 6/9] cpufreq: amd-pstate: Add set_boost callback for active mode Perry Yuan
2024-06-13 17:52 ` Mario Limonciello
2024-06-14 2:28 ` Yuan, Perry
2024-06-13 7:25 ` [PATCH v11 7/9] cpufreq: amd-pstate: fix the MSR highest perf will be reset issue while cpb boost off Perry Yuan
2024-06-13 7:25 ` [PATCH v11 8/9] Documentation: cpufreq: amd-pstate: introduce the new cpu boost control method Perry Yuan
2024-06-13 17:53 ` Mario Limonciello
2024-06-13 7:25 ` [PATCH v11 9/9] Documentation: cpufreq: amd-pstate: update doc for Per CPU " Perry Yuan
2024-06-13 17:53 ` Mario Limonciello
2024-06-13 17:54 ` [PATCH v11 0/9] AMD Pstate Driver Core Performance Boost Mario Limonciello
2024-06-14 3:18 ` Yuan, Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1718262992.git.perry.yuan@amd.com \
--to=perry.yuan@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Borislav.Petkov@amd.com \
--cc=Li.Meng@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=Xinmei.Huang@amd.com \
--cc=gautham.shenoy@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).