From: Perry Yuan <perry.yuan@amd.com>
To: <Mario.Limonciello@amd.com>
Cc: <rafael.j.wysocki@intel.com>, <viresh.kumar@linaro.org>,
<gautham.shenoy@amd.com>, <Alexander.Deucher@amd.com>,
<Xinmei.Huang@amd.com>, <Xiaojian.Du@amd.com>, <Li.Meng@amd.com>,
<linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v5 0/8] AMD Pstate Driver Fixes and Improvements
Date: Wed, 19 Jun 2024 23:40:11 +0800 [thread overview]
Message-ID: <cover.1718811234.git.perry.yuan@amd.com> (raw)
Hello everyone,
This patchset addresses critical issues and enhances performance settings for CPUs
with heterogeneous core types in the AMD pstate driver.
Specifically, it resolves problems related to calculating the highest performance
and frequency on the latest CPUs with preferred cores.
Additionally, the patchset includes documentation improvements in amd-pstate.rst,
offering a comprehensive guide covering topics such as recommended reboot requirements
during driver switching, debugging procedures for driver loading failures.
Your feedback and suggestions for improvement are highly appreciated.
Please review the patches and provide your valuable input.
Thank you.
Best regards,
Perry.
Changes from V4:
* pick all the RB by and ACk by flags from Mario
* fix typo for patch #10 in the commit log
* improve the commit log for shared memory in patch #11
* drop hetero core type patches into another patchset
* drop debugging section patch for amd-pstate.rst
Changes from V3:
* add one new patch to enable shared memory type CPPC by default
* pick all the RB by and ACk by flags from Mario and Gautham
* update the patch #7 PPR link with doc id (Boris & Mario)
* fix the highest perf initialization issue with preferred core check
for patch #9 (Gautham)
* rework return core type and commit log for the patch #9 (Mario)
* address feedback for patch #5 for the debugging suggestions.(Mario)
* retest the patches on MSR and shared memory type CPPC systems, no regression seen.
Changes from V2:
* pick review by and ack by flags from Mario and Gautham
* rebase to latest linux-pm bleeding edge branch
* fix driver loading block issue for patch 4, make sure the warning will
not abort the driver loading in case there are some new family/model id.
* fix the driver loading sequence issue for patch 10, it allows command line
and kernel config option together. command line will override kconfig option.
* add back the AMD CPUs with Family ID 19H and Model ID range 0x70 to 0x7f to return
the highest perf and check others CPU core type in the following codes.
* run some testing on the local system.
* move the amd_core_type to amd-pstate.c because of the amd-pstate.h was removed lately.
Changes from V1:
* drop patch 11 which has been merged in a separate patch. (Mario)
* fix some typos in commit log and tile (Mario)
* fix the patch 11 regression issue of kernel command line (Oleksandr Natalenko)
* pick ack flag for patch 7 (Mario)
* drop patch 4 which is not recommended for user(Mario)
* rebase to linux-pm/bleeding-edge branch
* fix some build warning
* rework the patch 3 for CPU ID matching(Mario)
* address feedback for patch 5 (Mario)
* move the acpi pm profile after got default mode(Mario)
Perry Yuan (8):
cpufreq: amd-pstate: optimize the initial frequency values
verification
cpufreq: amd-pstate: remove unused variable nominal_freq
cpufreq: amd-pstate: show CPPC debug message if CPPC is not supported
cpufreq: amd-pstate: add debug message while CPPC is supported and
disabled by SBIOS
Documentation: PM: amd-pstate: add guided mode to the Operation mode
cpufreq: amd-pstate: switch boot_cpu_has() to cpu_feature_enabled()
cpufreq: amd-pstate: enable shared memory type CPPC by default
cpufreq: amd-pstate: auto-load pstate driver by default
Documentation/admin-guide/pm/amd-pstate.rst | 2 +-
drivers/cpufreq/amd-pstate.c | 145 +++++++++++++-------
2 files changed, 95 insertions(+), 52 deletions(-)
--
2.34.1
next reply other threads:[~2024-06-19 15:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 15:40 Perry Yuan [this message]
2024-06-19 15:40 ` [PATCH v5 1/8] cpufreq: amd-pstate: optimize the initial frequency values verification Perry Yuan
2024-06-19 15:40 ` [PATCH v5 2/8] cpufreq: amd-pstate: remove unused variable nominal_freq Perry Yuan
2024-06-19 15:40 ` [PATCH v5 3/8] cpufreq: amd-pstate: show CPPC debug message if CPPC is not supported Perry Yuan
2024-06-19 15:40 ` [PATCH v5 4/8] cpufreq: amd-pstate: add debug message while CPPC is supported and disabled by SBIOS Perry Yuan
2024-06-19 15:40 ` [PATCH v5 5/8] Documentation: PM: amd-pstate: add guided mode to the Operation mode Perry Yuan
2024-06-19 15:40 ` [PATCH v5 6/8] cpufreq: amd-pstate: switch boot_cpu_has() to cpu_feature_enabled() Perry Yuan
2024-06-19 15:40 ` [PATCH v5 7/8] cpufreq: amd-pstate: enable shared memory type CPPC by default Perry Yuan
2024-06-21 8:29 ` Gautham R.Shenoy
2024-06-19 15:40 ` [PATCH v5 8/8] cpufreq: amd-pstate: auto-load pstate driver " Perry Yuan
2024-06-21 8:41 ` Gautham R.Shenoy
2024-06-19 17:59 ` [PATCH v5 0/8] AMD Pstate Driver Fixes and Improvements Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1718811234.git.perry.yuan@amd.com \
--to=perry.yuan@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Li.Meng@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=Xinmei.Huang@amd.com \
--cc=gautham.shenoy@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).