From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,FREEMAIL_REPLYTO_END_DIGIT, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC138C433DF for ; Wed, 26 Aug 2020 13:16:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF6512080C for ; Wed, 26 Aug 2020 13:16:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729334AbgHZNQY (ORCPT ); Wed, 26 Aug 2020 09:16:24 -0400 Received: from mga18.intel.com ([134.134.136.126]:7576 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729177AbgHZNQX (ORCPT ); Wed, 26 Aug 2020 09:16:23 -0400 IronPort-SDR: XX3+JDuVw15eJTYxVi53cVFFpjhoZ+bzppdrwhD/wx4xZHBL9WHVw005OesBM9pIEA3WZFwyjo TRdqNpzhGHBQ== X-IronPort-AV: E=McAfee;i="6000,8403,9724"; a="143949317" X-IronPort-AV: E=Sophos;i="5.76,355,1592895600"; d="scan'208";a="143949317" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2020 06:16:22 -0700 IronPort-SDR: NWV84qiBbzuGF6u+v34yNbY3wZEIE7Blm4wTVprLCU/eHyE7uHEVhGWI5MfL1TLAgkvLGnUV5/ KLQkSKGbq0Pg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,355,1592895600"; d="scan'208";a="499719031" Received: from linux.intel.com ([10.54.29.200]) by fmsmga006.fm.intel.com with ESMTP; 26 Aug 2020 06:16:22 -0700 Received: from abityuts-desk1.fi.intel.com (abityuts-desk1.fi.intel.com [10.237.72.186]) by linux.intel.com (Postfix) with ESMTP id 4FAC05806C4; Wed, 26 Aug 2020 06:16:20 -0700 (PDT) Message-ID: Subject: Re: [PATCH] intel_idle: Add ICL support From: Artem Bityutskiy Reply-To: dedekind1@gmail.com To: Guilhem Lettron , "Rafael J. Wysocki" Cc: Jacob Pan , Len Brown , Linux PM , Linux Kernel Mailing List Date: Wed, 26 Aug 2020 16:16:19 +0300 In-Reply-To: References: <20200826120421.44356-1-guilhem@barpilot.io> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.5 (3.32.5-1.fc30) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Wed, 2020-08-26 at 15:03 +0200, Guilhem Lettron wrote: > On Wed, 26 Aug 2020 at 14:43, Rafael J. Wysocki wrote: > > On Wed, Aug 26, 2020 at 2:05 PM Guilhem Lettron wrote: > > > Use the same C-states as SKL > > > > Why is this change needed? > > On my laptop, a Dell XPS 13 7390 2-in-1 with i7-1065G7, ACPI only > report "C1_ACPI", "C2_ACPI" and "C3_ACPI". Also, if you could runt turbostat - we could see which _actual_ HW C- states are used on your system, which Package C-states are reached. Just get a reasonably new turbostat (it is part of the kernel tree, you can compile it yourself) and run it for few seconds (like 'turbostat sleep 10'), get the output (will be a lot of it), and we can check what is actually going on with regards to C-states. Artem.