From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 228D243F8B6 for ; Mon, 14 Sep 2026 11:22:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789384982; cv=none; b=Fdzh3Ym0CtV9++2q7lxvI8QA9OaANb8r4uKbcAb9EiKxRyJTUEH2Ay/lDlrrNOV6KifxbyVGnJINaT2PIwyvt7FBKQr/HHjy/geTFx1WnCmbk70ExISljXC/UyDv3TMDd/4gz9//s4ohBUfhXu3AK1Uj2ibdZWw8U3cjrjQMhUA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789384982; c=relaxed/simple; bh=qB15Tu0wQgvflvACMlEZFwV6PZUUfZT9UV5fY5oJj88=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LxFqUAJiu/NTD4eQKFcvwA31xjps/hM7Zr0jpIBJGKm720Byp4Sn72p4Tv098dZPNSw8aCQFG/d5JfjCTCagF9qwkqa4FQ8Js1QW1/Z1uKsSNr59VRWLDn68Z9wbw8SajUvWsVjRUv3Qq5vyrTFLGN1v0eN0kuaTEk46Hz5+SXg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=V6eXEJqa; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TY8Xbk1k; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="V6eXEJqa"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TY8Xbk1k" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68EAmaIl314079 for ; Mon, 14 Sep 2026 11:22:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= htoucfNJ1NBOznj2ucEtPoE5fys137bATrwbrwYNEEg=; b=V6eXEJqaW52sruVW KmAWqHedQKN92ge5YENWkiPjd+G4FUiYoi+rXuXHOXCHct/s2ruBO47fL403iyAH 2SylfxfndayU9tuNs74mBf0Xj12d3kC5/2MhrMELYG8moOkZhHp5DR7YyqO0kNHs 0Lw7qkc35AhQS+AgFCbu3IoOaFGpMQF7HP0nvezpOH9EjkcQG7/eI1EGSaOHqhHE tAFRbnOZo/0zdY6LMW69aKrcmdFxfdNVAuR98oQs9x/NZr3V+VuTPtOnn+xGBeb6 5M5JFDIf2VvoFSBwfEjJixhhuEPdxOYVn7knVSt6iSa8pTvUSJQzCq5yrtQwVTO8 3nO8Vw== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gmy9c6cer-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 14 Sep 2026 11:22:58 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-9106bb33cdfso7384356d6.2 for ; Mon, 14 Sep 2026 04:22:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789384978; x=1789989778; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=htoucfNJ1NBOznj2ucEtPoE5fys137bATrwbrwYNEEg=; b=TY8Xbk1k2YxpMzK/hLKk7URRPEjoLUwPSByfCcPtMKzYR4YH49rJsWXDYLRQlmKaKK X+ENG1DzvL5fLgYYq3GdL8Wwly+HGJhAveGLsEkJtE6v7AzLrHNjfeqhju7Dv0aTF8Hb OwK3nk5s5kMTo39eVvmD4RnW1iaGWL1CmGRAGrM6FNX1ffZKmP4xGihwoZkqGKAeJk1W yJMIlLGPL8K8wUQT/W5ez39I15/6K3kTWBaY5USnE5BmE5Qlom4OUMCEr+7SsFM7KPNh C6FeOLoA/Zw7gB4fFkp9Swjc8IO9zozRd2JwQRLvZOfL92GfFXENURAf2uYUTjZ81jC8 egEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789384978; x=1789989778; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=htoucfNJ1NBOznj2ucEtPoE5fys137bATrwbrwYNEEg=; b=SOMM/8qZJZcEO3ui+d0sGfiU8BewsusimPPey8LZl6tY3mLHd2sa+8U+YqCOaEEK6y mV3rIrq6qiMPGDDQQgPo7jAnkTS8ckZLSnw55VDiBTgNfvbco+QBHJ0SV5f1Zwu+IVLz 9X+SufZQR9hRfONde4yXSDtr2oDsAQ215DX94TeA/dpiVbRiaEYSy4WzdC8zgWx5xZfr ypUAYGVqQJ09/g5GrEh/50VphvreY/ITgNuiSeJwFA1OweFuK+VYpVCTOJTIj0EZxBVl Z4HF24kcH1KXzz1hm830ElfJywByxkWNiyahCLxeQX29uzEZR4SA+ScfxQGbyHAwdG2Q qapw== X-Forwarded-Encrypted: i=1; AKwUvBw+s+gCLvWxkWmVaeb8U2V1P56c/4EUe3TBEjX23xrPLt0uKSqtnPXmU/BkWD8mufTJHVKNjvfi6A==@vger.kernel.org X-Gm-Message-State: AFuF++lSSZRpNLKvhRZzwmxWp1xJ05h0++NN2kUZ6pHYOUrnsshv7LJS dGkWddnVWclxcM2A+Qqwdf853gDmWGnlvPRUUqLV7qGdMqHeIan22atCCTKpzqmGrYBhaY5SiX/ kw6tkiJFLQVMgUVSk/2UYs7HFGWL/5iBqWRGV6QS773f/vgVzk4afz3NjCHr/9g== X-Gm-Gg: AYBFou0vj5PMrKf6CZfKONjkuJsfxPdsciDnnLmGuM9Z7Uf5jSq3RbLOiRv1kZjxX4X BCNW5eCpDBa4RHWPyfzyGubIssv7XYagOPmLJ9Npj7vvdIWNNWzqcnvTQW+WUvT5tXhM4qfadvV cL1fnB+AbS8JKQgihal103//Xi6PIC58YqXl+ZqZLNorP9ndJcJPR4DFH6VsQ3DTQhdiFsIgheb 611UVmA0bDwJtdzrTcN1yDZ8LVuQ16zFH/wRhkFxycIiQ+djpT4VrHMAqsLq0BUY3IcA9iqO1rW INkaCOF2IjgEC3vLPn1Fy2uAZFw4hBl9x4O1rGSzLYj9oBpfXnzW2Js2NBu2EbZSTFxkMku5pC9 DvCmGz0DmhWhByGzREq8+2w== X-Received: by 2002:a05:6214:4883:b0:912:1f0f:b204 with SMTP id 6a1803df08f44-9122e4ccd58mr27340406d6.1.1789384978164; Mon, 14 Sep 2026 04:22:58 -0700 (PDT) X-Received: by 2002:a05:6214:4883:b0:912:1f0f:b204 with SMTP id 6a1803df08f44-9122e4ccd58mr27339976d6.1.1789384977653; Mon, 14 Sep 2026 04:22:57 -0700 (PDT) Received: from [192.168.202.12] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a9b594f0fasm4216719a12.25.2026.09.14.04.22.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Sep 2026 04:22:56 -0700 (PDT) Message-ID: Date: Mon, 14 Sep 2026 13:22:52 +0200 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 20/20] arm64: dts: qcom: generalmobile-shamrock: new device To: muzafferkadir@mainlining.org, Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Srinivas Kandagatla , Ulf Hansson , Konrad Dybcio , "Joerg Roedel (AMD)" , Will Deacon , Robin Murphy , Lee Jones , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Robert Marko , Guru Das Srinagesh , Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , Dmitry Torokhov Cc: David Heidelberg , Dang Huynh , phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, iommu@lists.linux.dev, mfd@lists.linux.dev, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Krzysztof Kozlowski , linux-pm@vger.kernel.org, linux-input@vger.kernel.org References: <20260912-msm8952-initial-support-v1-0-0e742578b524@mainlining.org> <20260912-msm8952-initial-support-v1-20-0e742578b524@mainlining.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260912-msm8952-initial-support-v1-20-0e742578b524@mainlining.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: UGgZej44XY8JD6KzPtqRB0uaQXaLE0Iq X-Proofpoint-GUID: UGgZej44XY8JD6KzPtqRB0uaQXaLE0Iq X-Authority-Analysis: v=2.4 cv=c5Y+0h9l c=1 sm=1 tr=0 ts=6aa7d912 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=OuZLqq7tAAAA:8 a=orgwjQpZXFS75ENpSOkA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 a=AKGiAy9iJ-JzxKVHQNES:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE0MDE2MSBTYWx0ZWRfXzHD1bS12B5k0 NdFB/o7DL4HraMyPPrDci2RRZxToh52PfT6H7Vt0y9OSocG546sgRvHOLqjGph0lVpdq4XV5eEK Y2R1gd4x5u6j5Iiuejx+gEfbGwgBt3HeYtjxQzNI+jHTRVYA8NKkvltbXmmbuYZRcey7sCoBwQh t0OK6xegeIUCc8J3EckUr37da03bz0qggyIv6MbrYQwUEiqtKoLfBBu/j4bloIIXNkwFDvNhieO mWikii1XjucVcigq7WhlAr+DaMA39hWtKIUt49cF7hnbIEnTrT6EoYiC4J4ei0GbKnwy1PJyV+4 AlZPiNi6biSTlJXgOdl+WQ/uFtepTGvA+dYiGkLUp1CIoJg31POoFpEHX7gKyFzwNsYAzDQPqBR bjVGAmtO0AN0C5MWWyFzgkHWC7yABiiMzP1/8GW9IHQe3FNmNYKxCd+PgEdVTH4EcXu1F1zS6Ty 772Hx2G44NKuqJBAUiw== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE0MDE2MSBTYWx0ZWRfX71hUmNfrmmP6 Or1aBd7vQoaOaYb3LbumicZsNbyGid1/j5cx0PVfXaYS5U58mCXFMxyIPeM+qDmj5gxTqfeglSh ixM/o0FA2Oq5paBR9/1xz+INS1VqJr0= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-14_03,2026-09-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 bulkscore=0 impostorscore=0 suspectscore=0 malwarescore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609140161 On 9/12/26 10:39 AM, Muzaffer Kadir via B4 Relay wrote: > From: Muzaffer Kadir > > Add General Mobile Shamrock (GM 5 Plus). > Shamrock is designed similar to L9300. > Downstream reference is [1]. Please feel free to wrap your messages at 72 characters, otherwise they are a bit hard to read! :D [...] > +/ { > + model = "General Mobile GM 5 Plus (shamrock)"; It's not any "policy", but other DTs tend to only put the "pretty name" here, without the codename [...] > + framebuffer { > + compatible = "simple-framebuffer"; > + memory-region = <&cont_splash_mem>; > + > + width = <1080>; > + height = <1920>; > + stride = <(1080 * 3)>; > + format = "r8g8b8"; > + > + power-domains = <&gcc MDSS_GDSC>; > + > + clocks = <&gcc GCC_MDSS_AHB_CLK>, > + <&gcc GCC_MDSS_AXI_CLK>, > + <&gcc GCC_MDSS_VSYNC_CLK>, > + <&gcc GCC_MDSS_MDP_CLK>, > + <&gcc GCC_MDSS_BYTE0_CLK>, > + <&gcc GCC_MDSS_PCLK0_CLK>, > + <&gcc GCC_MDSS_ESC0_CLK>; Please align the '<'s, make sure your tab width is set to 8 [...] > + multi-led { > + compatible = "leds-group-multicolor"; > + color = ; > + function = LED_FUNCTION_INDICATOR; > + leds = <&red_status>, <&green_status>, <&blue_status>; > + }; > + > +}; Stray \n above [...] > +&ramoops_mem { > + status = "okay"; > +}; > + > +&adsp { > + status = "okay"; > +}; > + > +&lpass_mem { > + status = "okay"; > +}; Please sort the label references alphabetically > + > +&pm8950_spmi_regulators { > + // PM8950 S5 + S6 = VDD_APC supply Let's use /* C-style comments */ [...] > +&tlmm { > + gpio-reserved-ranges = <20 4>; // Downstream doesn't use 21,22,23. 24 is mdss_te Let's keep a \n between the last property and the following subnode [...] > + tpa6130a2_default: tpa6130a2-default-state { > + pins = "gpio61"; > + function = "gpio"; > + drive-strength = <8>; > + bias-pull-down; > + output-low; Drop this property, the driver will take care of it Konrad