From: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Pavel Machek <pavel-AlSwsSmVLrQ@public.gmane.org>
Cc: Vojtech Pavlik <vojtech-AlSwsSmVLrQ@public.gmane.org>,
Andy Isaacson <adi-3HqRAUrWAWyGglJvpFV4uA@public.gmane.org>,
Linux-pm mailing list
<linux-pm-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>,
Nigel Cunningham
<ncunningham-3EexvZdKGZRWk0Htik3J/w@public.gmane.org>,
Stefan Seyfried <seife-l3A5Bk7waGM@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: Re: swsusp 'disk' fails in bk-current - intel_agp at fault?
Date: Thu, 31 Mar 2005 10:02:37 -0500 [thread overview]
Message-ID: <d120d50005033107024b4c2f96@mail.gmail.com> (raw)
In-Reply-To: <20050331083909.GA1387-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
On Thu, 31 Mar 2005 10:39:10 +0200, Pavel Machek <pavel-AlSwsSmVLrQ@public.gmane.org> wrote:
> > int swsusp_write(void)
> > {
> > int error;
> > - device_resume();
> > lock_swapdevices();
> > error = write_suspend_image();
> > /* This will unlock ignored swap devices since writing is
>
> Looks good, except... why move code around? Could you just call
> usermodehelper_disable from swsusp_write?
That's because I don't think that swsusp_write is a proper place for
it ;) It looks like a lean and mean function that does just write and
manipulating usermodehelper state _and_ system (device) state is
wrong. Let it do one thing, don't overload with actions that I think
belong to the upper level. Do you agree?
I think I need to stick in usermodehelper_enable call in case
swsusp_write fails though.
--
Dmitry
next prev parent reply other threads:[~2005-03-31 15:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4242CE43.1020806@suse.de>
[not found] ` <20050324181059.GA18490@hexapodia.org>
[not found] ` <4243252D.6090206@suse.de>
[not found] ` <20050324235439.GA27902@hexapodia.org>
[not found] ` <4243D854.2010506@suse.de>
[not found] ` <d120d50005032908183b2f622e@mail.gmail.com>
[not found] ` <20050329181831.GB8125@elf.ucw.cz>
[not found] ` <d120d50005032911114fd2ea32@mail.gmail.com>
[not found] ` <20050329192339.GE8125@elf.ucw.cz>
[not found] ` <d120d50005032912051fee6e91@mail.gmail.com>
[not found] ` <d120d50005032912051fee6e91-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2005-03-29 20:52 ` swsusp 'disk' fails in bk-current - intel_agp at fault? Pavel Machek
[not found] ` <20050329205225.GF8125-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2005-03-29 21:07 ` Dmitry Torokhov
[not found] ` <d120d500050329130714e1daaf-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2005-03-29 21:12 ` Pavel Machek
[not found] ` <20050329211239.GG8125-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2005-03-29 21:33 ` Dmitry Torokhov
[not found] ` <d120d50005032913331be39802-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2005-03-29 21:44 ` Pavel Machek
[not found] ` <20050329214408.GH8125-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2005-03-29 22:31 ` Nigel Cunningham
[not found] ` <1112135477.29392.16.camel-r49W/1Cwd2ff0s6lnCXPX/uOuaPYTxhvJwvTLr3MMZM@public.gmane.org>
2005-03-29 22:35 ` Pavel Machek
[not found] ` <20050329223519.GI8125-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2005-03-29 23:46 ` Nigel Cunningham
2005-03-31 7:26 ` Dmitry Torokhov
[not found] ` <200503310226.03495.dtor_core-yWtbtysYrB+LZ21kGMrzwg@public.gmane.org>
2005-03-31 8:39 ` Pavel Machek
[not found] ` <20050331083909.GA1387-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2005-03-31 15:02 ` Dmitry Torokhov [this message]
2005-03-31 16:02 ` Patrick Mochel
[not found] ` <Pine.LNX.4.50.0503310801410.15519-100000-x8k/2hhmB0w5etPau2IXcQ@public.gmane.org>
2005-03-31 16:32 ` Dmitry Torokhov
[not found] ` <d120d50005033108321c8f4ae7-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2005-03-31 22:16 ` Nigel Cunningham
2005-03-31 22:18 ` Pavel Machek
[not found] ` <20050331221814.GC1802-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2005-03-31 22:28 ` Nigel Cunningham
[not found] ` <1112308137.18871.7.camel-r49W/1Cwd2ff0s6lnCXPX/uOuaPYTxhvJwvTLr3MMZM@public.gmane.org>
2005-04-01 8:49 ` Rafael J. Wysocki
[not found] ` <200504011049.01540.rjw-KKrjLPT3xs0@public.gmane.org>
2005-04-01 10:33 ` Stefan Seyfried
2005-03-29 23:05 ` Rafael J. Wysocki
2005-03-29 21:23 ` Patrick Mochel
[not found] ` <Pine.LNX.4.50.0503291321490.29474-100000-x8k/2hhmB0w5etPau2IXcQ@public.gmane.org>
2005-03-29 21:38 ` Dmitry Torokhov
2005-03-30 9:52 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d50005033107024b4c2f96@mail.gmail.com \
--to=dmitry.torokhov-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=adi-3HqRAUrWAWyGglJvpFV4uA@public.gmane.org \
--cc=dtor_core-yWtbtysYrB+LZ21kGMrzwg@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pm-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=ncunningham-3EexvZdKGZRWk0Htik3J/w@public.gmane.org \
--cc=pavel-AlSwsSmVLrQ@public.gmane.org \
--cc=seife-l3A5Bk7waGM@public.gmane.org \
--cc=vojtech-AlSwsSmVLrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox