From: Dmitry Osipenko <digetx@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Keerthy <j-keerthy@ti.com>, Dave Gerlach <d-gerlach@ti.com>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-kernel@vger.kernel.org,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 5/5] OPP: Remove custom OPP helper support
Date: Mon, 27 Jun 2022 10:09:11 +0300 [thread overview]
Message-ID: <d18a1f18-d78c-2db8-9b19-196dc88978c2@gmail.com> (raw)
In-Reply-To: <20220627064155.jo7iqz5h33l7a4vn@vireshk-i7>
27.06.2022 09:41, Viresh Kumar пишет:
> On 27-06-22, 09:10, Dmitry Osipenko wrote:
>> Okay, but Tegra 3d driver doesn't need config_regulators(), it needs
>> customized set_opp() to set clock rate for both 3d engines.
>
> What does that mean, you need to set two clocks ? There is separate
> support added for that already [1].
>
Yes, I missed that multi-clock OPP patch, thanks.
Seems _opp_compare_key() won't work properly for the multi-clocks since
Tegra doesn't have bandwidth nor level for the 3d OPPs. Why does it need
to check opp_table->clk_count == 1? Shouldn't it be opp_table->clk_count
> 0?
next prev parent reply other threads:[~2022-06-27 7:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 10:09 [PATCH 0/5] OPP: Replace custom set_opp() with config_regulators() Viresh Kumar
2022-05-31 10:10 ` [PATCH 1/5] OPP: Add support for config_regulators() helper Viresh Kumar
2022-05-31 10:10 ` [PATCH 2/5] OPP: Make _generic_set_opp_regulator() a config_regulators() interface Viresh Kumar
2022-05-31 10:10 ` [PATCH 3/5] OPP: Add dev_pm_opp_get_supplies() Viresh Kumar
2022-05-31 10:10 ` [PATCH 4/5] OPP: ti: Migrate to config_regulators() Viresh Kumar
2022-05-31 10:10 ` [PATCH 5/5] OPP: Remove custom OPP helper support Viresh Kumar
2022-06-25 11:42 ` Dmitry Osipenko
2022-06-27 6:06 ` Viresh Kumar
2022-06-27 6:10 ` Dmitry Osipenko
2022-06-27 6:41 ` Viresh Kumar
2022-06-27 7:09 ` Dmitry Osipenko [this message]
2022-06-27 7:19 ` Viresh Kumar
2022-06-28 10:04 ` Dmitry Osipenko
2022-06-28 11:04 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d18a1f18-d78c-2db8-9b19-196dc88978c2@gmail.com \
--to=digetx@gmail.com \
--cc=d-gerlach@ti.com \
--cc=j-keerthy@ti.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).