From: Krzysztof Kozlowski <krzk@kernel.org>
To: Xueqin Luo <luoxueqin@kylinos.cn>,
hansg@kernel.org, m.szyprowski@samsung.com,
sebastian.krzyszkowiak@puri.sm, kernel@puri.sm, sre@kernel.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: supply: max17042_battery: Fix vmin assigned instead of vmax in DT parsing
Date: Tue, 1 Sep 2026 07:41:15 +0200 [thread overview]
Message-ID: <d2ae22e7-c84f-4963-8039-63370411896d@kernel.org> (raw)
In-Reply-To: <20260901053653.1668492-1-luoxueqin@kylinos.cn>
On 01/09/2026 07:36, Xueqin Luo wrote:
> The else branch of the "maxim,over-volt" property check assigns the
> parsed value to chip->vmin instead of chip->vmax, so chip->vmin is
> overwritten and chip->vmax never gets the DT value.
>
> Fixes: 6a3b47a5a5fc ("power: supply: Match DT value types")
> Signed-off-by: Xueqin Luo <luoxueqin@kylinos.cn>
> ---
> drivers/power/supply/max17042_battery.c | 2 +-
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
prev parent reply other threads:[~2026-09-01 5:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 5:36 [PATCH] power: supply: max17042_battery: Fix vmin assigned instead of vmax in DT parsing Xueqin Luo
2026-09-01 5:41 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2ae22e7-c84f-4963-8039-63370411896d@kernel.org \
--to=krzk@kernel.org \
--cc=hansg@kernel.org \
--cc=kernel@puri.sm \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=luoxueqin@kylinos.cn \
--cc=m.szyprowski@samsung.com \
--cc=sebastian.krzyszkowiak@puri.sm \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox