* [PATCH 0/2] power: dead struct removal
@ 2024-05-28 0:06 linux
2024-05-28 0:06 ` [PATCH 1/2] power: supply: bd99954: remove unused struct 'battery_data' linux
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: linux @ 2024-05-28 0:06 UTC (permalink / raw)
To: linus.walleij, mazziesaccount, sre
Cc: linux-pm, linux-kernel, Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
A couple of dead struct removals in drivers/power
Build tested.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Dr. David Alan Gilbert (2):
power: supply: bd99954: remove unused struct 'battery_data'
power: supply: ab8500: remove unused struct 'inst_curr_result_list'
drivers/power/supply/ab8500_fg.c | 5 -----
drivers/power/supply/bd99954-charger.c | 7 -------
2 files changed, 12 deletions(-)
--
2.45.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] power: supply: bd99954: remove unused struct 'battery_data'
2024-05-28 0:06 [PATCH 0/2] power: dead struct removal linux
@ 2024-05-28 0:06 ` linux
2024-05-28 5:36 ` Matti Vaittinen
2024-05-28 0:06 ` [PATCH 2/2] power: supply: ab8500: remove unused struct 'inst_curr_result_list' linux
2024-06-05 21:38 ` [PATCH 0/2] power: dead struct removal Sebastian Reichel
2 siblings, 1 reply; 6+ messages in thread
From: linux @ 2024-05-28 0:06 UTC (permalink / raw)
To: linus.walleij, mazziesaccount, sre
Cc: linux-pm, linux-kernel, Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
'battery_data' is unused since the original
commit 0902f8366491 ("power: supply: Support ROHM bd99954 charger").
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/power/supply/bd99954-charger.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/power/supply/bd99954-charger.c b/drivers/power/supply/bd99954-charger.c
index 1ed1d9f99fb3..54bf88262510 100644
--- a/drivers/power/supply/bd99954-charger.c
+++ b/drivers/power/supply/bd99954-charger.c
@@ -70,13 +70,6 @@
#include "bd99954-charger.h"
-struct battery_data {
- u16 precharge_current; /* Trickle-charge Current */
- u16 fc_reg_voltage; /* Fast Charging Regulation Voltage */
- u16 voltage_min;
- u16 voltage_max;
-};
-
/* Initial field values, converted to initial register values */
struct bd9995x_init_data {
u16 vsysreg_set; /* VSYS Regulation Setting */
--
2.45.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] power: supply: ab8500: remove unused struct 'inst_curr_result_list'
2024-05-28 0:06 [PATCH 0/2] power: dead struct removal linux
2024-05-28 0:06 ` [PATCH 1/2] power: supply: bd99954: remove unused struct 'battery_data' linux
@ 2024-05-28 0:06 ` linux
2024-05-29 7:47 ` Linus Walleij
2024-06-05 21:38 ` [PATCH 0/2] power: dead struct removal Sebastian Reichel
2 siblings, 1 reply; 6+ messages in thread
From: linux @ 2024-05-28 0:06 UTC (permalink / raw)
To: linus.walleij, mazziesaccount, sre
Cc: linux-pm, linux-kernel, Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
'inst_curr_result_list' is unused since the original
commit 13151631b5bd ("ab8500-fg: A8500 fuel gauge driver").
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/power/supply/ab8500_fg.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/power/supply/ab8500_fg.c b/drivers/power/supply/ab8500_fg.c
index 2ccaf6116c09..270874eeb934 100644
--- a/drivers/power/supply/ab8500_fg.c
+++ b/drivers/power/supply/ab8500_fg.c
@@ -149,11 +149,6 @@ struct ab8500_fg_flags {
bool batt_id_received;
};
-struct inst_curr_result_list {
- struct list_head list;
- int *result;
-};
-
/**
* struct ab8500_fg - ab8500 FG device information
* @dev: Pointer to the structure device
--
2.45.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] power: supply: bd99954: remove unused struct 'battery_data'
2024-05-28 0:06 ` [PATCH 1/2] power: supply: bd99954: remove unused struct 'battery_data' linux
@ 2024-05-28 5:36 ` Matti Vaittinen
0 siblings, 0 replies; 6+ messages in thread
From: Matti Vaittinen @ 2024-05-28 5:36 UTC (permalink / raw)
To: linux, linus.walleij, sre; +Cc: linux-pm, linux-kernel
On 5/28/24 03:06, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'battery_data' is unused since the original
> commit 0902f8366491 ("power: supply: Support ROHM bd99954 charger").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Acked-by: Matti Vaittinen <mazziesaccount@gmail.com>
Thanks!
> ---
> drivers/power/supply/bd99954-charger.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/power/supply/bd99954-charger.c b/drivers/power/supply/bd99954-charger.c
> index 1ed1d9f99fb3..54bf88262510 100644
> --- a/drivers/power/supply/bd99954-charger.c
> +++ b/drivers/power/supply/bd99954-charger.c
> @@ -70,13 +70,6 @@
>
> #include "bd99954-charger.h"
>
> -struct battery_data {
> - u16 precharge_current; /* Trickle-charge Current */
> - u16 fc_reg_voltage; /* Fast Charging Regulation Voltage */
> - u16 voltage_min;
> - u16 voltage_max;
> -};
> -
> /* Initial field values, converted to initial register values */
> struct bd9995x_init_data {
> u16 vsysreg_set; /* VSYS Regulation Setting */
--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] power: supply: ab8500: remove unused struct 'inst_curr_result_list'
2024-05-28 0:06 ` [PATCH 2/2] power: supply: ab8500: remove unused struct 'inst_curr_result_list' linux
@ 2024-05-29 7:47 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2024-05-29 7:47 UTC (permalink / raw)
To: linux; +Cc: mazziesaccount, sre, linux-pm, linux-kernel
On Tue, May 28, 2024 at 2:06 AM <linux@treblig.org> wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'inst_curr_result_list' is unused since the original
> commit 13151631b5bd ("ab8500-fg: A8500 fuel gauge driver").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] power: dead struct removal
2024-05-28 0:06 [PATCH 0/2] power: dead struct removal linux
2024-05-28 0:06 ` [PATCH 1/2] power: supply: bd99954: remove unused struct 'battery_data' linux
2024-05-28 0:06 ` [PATCH 2/2] power: supply: ab8500: remove unused struct 'inst_curr_result_list' linux
@ 2024-06-05 21:38 ` Sebastian Reichel
2 siblings, 0 replies; 6+ messages in thread
From: Sebastian Reichel @ 2024-06-05 21:38 UTC (permalink / raw)
To: linus.walleij, mazziesaccount, sre, linux; +Cc: linux-pm, linux-kernel
On Tue, 28 May 2024 01:06:32 +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> A couple of dead struct removals in drivers/power
>
> Build tested.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
>
> [...]
Applied, thanks!
[1/2] power: supply: bd99954: remove unused struct 'battery_data'
commit: ef1f6783fe03bee6acc15ef7084ab8b64c38d769
[2/2] power: supply: ab8500: remove unused struct 'inst_curr_result_list'
commit: a5dd84f3bde0252cb39a3ecebbe71d7c2b405194
Best regards,
--
Sebastian Reichel <sebastian.reichel@collabora.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-06-05 21:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-28 0:06 [PATCH 0/2] power: dead struct removal linux
2024-05-28 0:06 ` [PATCH 1/2] power: supply: bd99954: remove unused struct 'battery_data' linux
2024-05-28 5:36 ` Matti Vaittinen
2024-05-28 0:06 ` [PATCH 2/2] power: supply: ab8500: remove unused struct 'inst_curr_result_list' linux
2024-05-29 7:47 ` Linus Walleij
2024-06-05 21:38 ` [PATCH 0/2] power: dead struct removal Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).