Linux Power Management development
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Roman Storozhenko <romeusmeister@gmail.com>,
	Thomas Renninger <trenn@suse.com>, Shuah Khan <shuah@kernel.org>
Cc: Javier Carrasco <javier.carrasco.cruz@gmail.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] cpupower: Remove absent 'v' parameter from monitor man page
Date: Tue, 18 Jun 2024 14:22:13 -0600	[thread overview]
Message-ID: <d47043de-628c-4f9e-8791-a2a8dbf4ed21@linuxfoundation.org> (raw)
In-Reply-To: <20240618-change-mon-format-v1-1-efa263a8e286@gmail.com>

On 6/18/24 13:21, Roman Storozhenko wrote:
> Remove not supported '-v' parameter from the cpupower's 'monitor'
> command description.
> 

Nice find.

> Signed-off-by: Roman Storozhenko <romeusmeister@gmail.com>
> ---
> There is a '-v' parameter described in cpupower's 'monitor' command man
> page. It isn't supported at the moment, and perhaps has never been
> supported. When I run the monitor with this parameter I get the
> following:
> 
> $ sudo LD_LIBRARY_PATH=lib64/ bin/cpupower monitor -v
> monitor: invalid option -- 'v'
> invalid or unknown argument
> $ sudo LD_LIBRARY_PATH=lib64/ bin/cpupower monitor -V
> monitor: invalid option -- 'V'
> invalid or unknown argument

You are burying important information in throw away text. Please
add all of the above text to commit log and send me v2.

thanks,
-- Shuah

      reply	other threads:[~2024-06-18 20:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-18 19:21 [PATCH] cpupower: Remove absent 'v' parameter from monitor man page Roman Storozhenko
2024-06-18 20:22 ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d47043de-628c-4f9e-8791-a2a8dbf4ed21@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=javier.carrasco.cruz@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=romeusmeister@gmail.com \
    --cc=shuah@kernel.org \
    --cc=trenn@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox