From: Shuah Khan <skhan@linuxfoundation.org>
To: Borislav Petkov <bp@alien8.de>, X86 ML <x86@kernel.org>
Cc: Thomas Renninger <trenn@suse.com>, Shuah Khan <shuah@kernel.org>,
Len Brown <lenb@kernel.org>,
linux-pm@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v1 1/4] tools/power/cpupower: Read energy_perf_bias from sysfs
Date: Fri, 30 Oct 2020 11:13:47 -0600 [thread overview]
Message-ID: <d6da5f48-5f50-a201-1f6c-5084466f81ee@linuxfoundation.org> (raw)
In-Reply-To: <20201029190259.3476-2-bp@alien8.de>
On 10/29/20 1:02 PM, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
>
> ... instead of poking at the MSR. For that, move the accessor functions
> to misc.c and add a sysfs-writing function too.
>
> There should be no functional changes resulting from this.
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Thomas Renninger <trenn@suse.com>
> Cc: Shuah Khan <shuah@kernel.org>
> ---
> tools/power/cpupower/lib/cpupower.c | 23 +++++++++-
> tools/power/cpupower/lib/cpupower_intern.h | 5 ++
> tools/power/cpupower/utils/cpupower-info.c | 2 +-
> tools/power/cpupower/utils/cpupower-set.c | 2 +-
> tools/power/cpupower/utils/helpers/helpers.h | 8 ++--
> tools/power/cpupower/utils/helpers/misc.c | 48 ++++++++++++++++++++
> tools/power/cpupower/utils/helpers/msr.c | 28 ------------
> 7 files changed, 81 insertions(+), 35 deletions(-)
>
Thanks. Looks good to me.
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
next prev parent reply other threads:[~2020-10-30 17:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 19:02 [PATCH v1 0/4] x86: Remove direct use of MSR_IA32_ENERGY_PERF_BIAS Borislav Petkov
2020-10-29 19:02 ` [PATCH v1 1/4] tools/power/cpupower: Read energy_perf_bias from sysfs Borislav Petkov
2020-10-30 17:13 ` Shuah Khan [this message]
2020-10-29 19:02 ` [PATCH v1 2/4] tools/power/turbostat: " Borislav Petkov
2020-11-16 20:08 ` [tip: x86/misc] " tip-bot2 for Borislav Petkov
2020-10-29 19:02 ` [PATCH v1 3/4] tools/power/x86_energy_perf_policy: " Borislav Petkov
2020-10-29 19:02 ` [PATCH v1 4/4] x86/msr: Do not allow writes to MSR_IA32_ENERGY_PERF_BIAS Borislav Petkov
2020-10-30 17:12 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6da5f48-5f50-a201-1f6c-5084466f81ee@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=bp@alien8.de \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=trenn@suse.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).