From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Eduardo Valentin <edubezval@gmail.com>
Cc: rui.zhang@intel.com, linux-pm@vger.kernel.org,
leo.yan@linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/18] thermal/drivers/hisi: Fix missing interrupt enablement
Date: Fri, 20 Oct 2017 08:35:29 +0200 [thread overview]
Message-ID: <d82e759c-21a8-231e-16ff-aa3ab3b719a0@linaro.org> (raw)
In-Reply-To: <20171020015205.GA10997@localhost.localdomain>
On 20/10/2017 03:52, Eduardo Valentin wrote:
> On Thu, Oct 19, 2017 at 07:05:43PM +0200, Daniel Lezcano wrote:
>> The interrupt for the temperature threshold is not enabled at the end of the
>> probe function, enable it after the setup is complete.
>>
>> On the other side, the irq_enabled is not correctly set as we are checking if
>> the interrupt is masked where 'yes' means irq_enabled=false.
>>
>> irq_get_irqchip_state(data->irq, IRQCHIP_STATE_MASKED,
>> &data->irq_enabled);
>>
>> As we are always enabling the interrupt, it is pointless to check if
>> the interrupt is masked or not, just set irq_enabled to 'true'.
>
>
> Why only 18 patches this time? Can you please add a cover letter (0/X)
> next time?
Yes sure.
Actually, I grouped the different series (acked and reviewed) into a git
pull request instead of having them around. I thought that could help
you. I sent a pull request with all these patches under this pull
request along with a description. Did you receive it? Note without the
threaded email view, it is easy to miss it.
> What happened to the other 7 patches?
As stated in the PR, I put them apart to solve the multi threshold issue
before resubmitting, probably by folding Kevin's latest change. I will
resend them very shortly.
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
prev parent reply other threads:[~2017-10-20 6:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 17:05 [GIT PULL] thermal: new material for hikey for 4.15 #2 Daniel Lezcano
2017-10-19 17:05 ` [PATCH 01/18] thermal/drivers/hisi: Fix missing interrupt enablement Daniel Lezcano
2017-10-19 17:05 ` [PATCH 02/18] thermal/drivers/hisi: Remove the multiple sensors support Daniel Lezcano
2017-10-19 17:05 ` [PATCH 03/18] thermal/drivers/hisi: Fix kernel panic on alarm interrupt Daniel Lezcano
2017-10-19 17:05 ` [PATCH 04/18] thermal/drivers/hisi: Simplify the temperature/step computation Daniel Lezcano
2017-10-19 17:05 ` [PATCH 05/18] thermal/drivers/hisi: Fix multiple alarm interrupts firing Daniel Lezcano
2017-10-19 17:05 ` [PATCH 06/18] thermal/drivers/hisi: Remove pointless lock Daniel Lezcano
2017-10-19 17:05 ` [PATCH 07/18] thermal/drivers/hisi: Encapsulate register writes into helpers Daniel Lezcano
2017-10-19 17:05 ` [PATCH 08/18] thermal/drivers/hisi: Fix configuration register setting Daniel Lezcano
2017-10-19 17:05 ` [PATCH 09/18] thermal/drivers/hisi: Remove costly sensor inspection Daniel Lezcano
2017-10-19 17:05 ` [PATCH 10/18] thermal/drivers/hisi: Rename and remove unused field Daniel Lezcano
2017-10-19 17:05 ` [PATCH 11/18] thermal/drivers/hisi: Convert long to int Daniel Lezcano
2017-10-19 17:05 ` [PATCH 12/18] thermal/drivers/hisi: Remove thermal data back pointer Daniel Lezcano
2017-10-19 17:05 ` [PATCH 13/18] thermal/drivers/hisi: Remove mutex_lock in the code Daniel Lezcano
2017-10-19 17:05 ` [PATCH 14/18] thermal/drivers/hisi: Move the clk setup in the corresponding functions Daniel Lezcano
2017-10-19 17:05 ` [PATCH 15/18] thermal/drivers/hisi: Use round up step value Daniel Lezcano
2017-10-19 17:05 ` [PATCH 16/18] thermal/drivers/step_wise: Fix temperature regulation misbehavior Daniel Lezcano
2017-10-19 17:05 ` [PATCH 17/18] thermal/drivers/generic-iio-adc: Switch tz request to devm version Daniel Lezcano
2017-10-19 17:06 ` [PATCH 18/18] thermal/drivers/qcom-spmi: Use devm_iio_channel_get Daniel Lezcano
2017-10-20 1:52 ` [PATCH 01/18] thermal/drivers/hisi: Fix missing interrupt enablement Eduardo Valentin
2017-10-20 6:35 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d82e759c-21a8-231e-16ff-aa3ab3b719a0@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).