From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH v1.1] ARM: multi_v7_defconfig: Enable power sequence for Odroid U3 Date: Mon, 9 Jan 2017 13:24:43 -0300 Message-ID: References: <20170107085203.4431-5-krzk@kernel.org> <20170107091651.10560-1-krzk@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170107091651.10560-1-krzk@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Krzysztof Kozlowski , Kukjin Kim , Anand Moon , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Peter Chen , ulf.hansson@linaro.org, Markus Reichl , linux-pm@vger.kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, sre@kernel.org, robh+dt@kernel.org, hverkuil@xs4all.nl, broonie@kernel.org, stern@rowland.harvard.edu, Sylwester Nawrocki , Marek Szyprowski List-Id: linux-pm@vger.kernel.org Hello Krzysztof, I think it would had been clearer if the subject prefix was "[PATCH v1.1 4/4]" :) On 01/07/2017 06:16 AM, Krzysztof Kozlowski wrote: > Odroid U3 needs a power sequence for lan9730, if it was enabled by > bootloader. Also enable the USB3503 HSCI to USB2.0 driver (device > is present on Odroid U3). > > Signed-off-by: Krzysztof Kozlowski > > --- > Do you think that makes sense to also enable GPIO_SYS for debugging purposes as you do in patch 3/4? In any case the patch looks good to me: Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America