From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23438ECAAD1 for ; Thu, 1 Sep 2022 15:47:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234162AbiIAPrO (ORCPT ); Thu, 1 Sep 2022 11:47:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233986AbiIAPrL (ORCPT ); Thu, 1 Sep 2022 11:47:11 -0400 Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5B268A7DA for ; Thu, 1 Sep 2022 08:47:08 -0700 (PDT) Received: by mail-il1-x130.google.com with SMTP id a9so6935984ilh.1 for ; Thu, 01 Sep 2022 08:47:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=cR8Ir4R4yuVk1/9w3KJlXK3iQYqpW+6/KYRzY74rKiY=; b=R3UKzrAlLHtXUKFQIbdjd9rA5YoDFOjI4Qk1Qqo9oBR4ezcyVqEHXgLUMH+qpdsEb8 HwGF8DOSLPC0IxGL432SE13xG1QLKKNBKqomF4yKq8rITRUrF8AYOCrAajjmNyrLYKa8 qKn9BM5o57RTGEMubeedPi2ytz3EyhCNOrAlg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=cR8Ir4R4yuVk1/9w3KJlXK3iQYqpW+6/KYRzY74rKiY=; b=6i2MnYFIvKtWLZ3yVKEsbIL61sHGQNycvxgIFyPwuiZ1EDFI+D5uHwL/UPi3c2gpLU DmVtLMMCuLFt0mvra3aFMHP6/ZQ6+qBliAM3gJXpmf7WGamEANg9NDfuBwsonGlupMXz BucBMZcRDOHd+eJLF4Kmg7QdQIRhLmuquo9EZxGBVqtWV0RvM6VOv0L1wlUtS3ug7QyS PNk7EIGo0WI3LNxNswXtkrYOcnp760rCFVPv2irMGiFUMI4iMCKM3UuT2lJ5d/SH1q6/ nUlS3d85Ax4K3zOtEfDB6qX1apfTrdA6WUHZG95yGZ8TBhMurqX9xz8KZzucofitMKO/ NOFw== X-Gm-Message-State: ACgBeo0xuWxuJAsOrz9+7D7cYAhbRICB1x5lU1dVHfNg+hKStzGxBiUW Tg4jc9zakmTiArAH5W51YtAqaw== X-Google-Smtp-Source: AA6agR6ETM5ONYFMDYU3TZ91zzC/yTF/90lCTohpaRzj5uHJ0D9aODBPkl06wrbUYPuM9mT4rBeBrQ== X-Received: by 2002:a05:6e02:1347:b0:2ea:e939:fef1 with SMTP id k7-20020a056e02134700b002eae939fef1mr11598351ilr.114.1662047227677; Thu, 01 Sep 2022 08:47:07 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id a5-20020a056e0208a500b002eb9fb2d4e3sm1467428ilt.76.2022.09.01.08.47.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Sep 2022 08:47:07 -0700 (PDT) Message-ID: Date: Thu, 1 Sep 2022 09:47:06 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [Suggested-by:Shuah Khan Patch 1/1] cpufreq: amd-pstate: Add explanation for X86_AMD_PSTATE_UT Content-Language: en-US To: Meng Li , Huang Rui , linux-pm@vger.kernel.org Cc: "Rafael J . Wysocki" , Nathan Fontenot , Deepak Sharma , Alex Deucher , Mario Limonciello , Jinzhou Su , Perry Yuan , Xiaojian Du , Viresh Kumar , Borislav Petkov , linux-kernel@vger.kernel.org, Shuah Khan References: <20220901143313.1491951-1-li.meng@amd.com> <20220901143313.1491951-2-li.meng@amd.com> From: Shuah Khan In-Reply-To: <20220901143313.1491951-2-li.meng@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 9/1/22 08:33, Meng Li wrote: > This kernel module is used for testing. It's safe to say M here. > It can be modprobed even without amd-pstate module. > When the comparison test is performed, it can load other module > like acpi-cpufreq to test cases, then compare the test results. > When only the test for amd-pstate is performed, it can tell the > users they loaded a wrong module like acpi-cpufreq. > > Signed-off-by: Meng Li > --- > drivers/cpufreq/Kconfig.x86 | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/cpufreq/Kconfig.x86 b/drivers/cpufreq/Kconfig.x86 > index fdd819069d72..fd1582716c58 100644 > --- a/drivers/cpufreq/Kconfig.x86 > +++ b/drivers/cpufreq/Kconfig.x86 > @@ -58,6 +58,12 @@ config X86_AMD_PSTATE_UT > help > This kernel module is used for testing. It's safe to say M here. > > + It can be modprobed even without amd-pstate module. It can also be built-in without X86_AMD_PSTATE enabled. I would rephrase this as: This config option can be enabled without X86_AMD_PSTATE enabled. Also change the information below to sat enabled as opposed to module as both these options can be built-in > + When the comparison test is performed, it can load other module > + like acpi-cpufreq to test cases, then compare the test results. > + When only the test for amd-pstate is performed, it can tell the > + users they loaded a wrong module like acpi-cpufreq. > + > config X86_ACPI_CPUFREQ > tristate "ACPI Processor P-States driver" > depends on ACPI_PROCESSOR Thank you - In addition to this patch please make change to the test script as well when it fails detecting that X86_AMD_PSTATE is disabled to say what user has to do to run the test. This run-time message will be helpful to users. thanks, -- Shuah