From: Taniya Das <tdas@codeaurora.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Stephen Boyd <sboyd@kernel.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
linux-arm-msm@vger.kernel.org, amit.kucheria@linaro.org,
Matthias Kaehlcke <mka@chromium.org>,
evgreen@google.com
Subject: Re: [PATCH v3] cpufreq: qcom: Read voltage LUT and populate OPP
Date: Thu, 17 Jan 2019 16:30:37 +0530 [thread overview]
Message-ID: <d9cf7ab9-a5f9-5c1a-940b-5ddb12d8ff9a@codeaurora.org> (raw)
In-Reply-To: <20190117072716.iy3glrtdpobsh5u2@vireshk-i7>
On 1/17/2019 12:57 PM, Viresh Kumar wrote:
> On 17-01-19, 12:38, Taniya Das wrote:
>> @@ -159,10 +170,18 @@ static int qcom_cpufreq_hw_cpu_init(struct cpufreq_policy *policy)
>> struct device *dev = &global_pdev->dev;
>> struct of_phandle_args args;
>> struct device_node *cpu_np;
>> + struct device *cpu_dev;
>> struct resource *res;
>> void __iomem *base;
>> int ret, index;
>>
>> + cpu_dev = get_cpu_device(policy->cpu);
>> + if (!cpu_dev) {
>> + pr_err("%s: failed to get cpu%d device\n", __func__,
>> + policy->cpu);
>> + return -ENODEV;
>> + }
>> +
>> cpu_np = of_cpu_device_node_get(policy->cpu);
>> if (!cpu_np)
>> return -EINVAL;
>> @@ -199,12 +218,18 @@ static int qcom_cpufreq_hw_cpu_init(struct cpufreq_policy *policy)
>>
>> policy->driver_data = base + REG_PERF_STATE;
>>
>> - ret = qcom_cpufreq_hw_read_lut(dev, policy, base);
>> + ret = qcom_cpufreq_hw_read_lut(policy, base);
>
> I asked you to pass cpu_dev here instead of dev and you said okay in
> the previous version of the patch. Didn't like it ?
>
:(, sent the next patch for review.
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.
--
prev parent reply other threads:[~2019-01-17 11:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 7:08 [PATCH v3] cpufreq: qcom: Read voltage LUT and populate OPP Taniya Das
2019-01-17 7:27 ` Viresh Kumar
2019-01-17 11:00 ` Taniya Das [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9cf7ab9-a5f9-5c1a-940b-5ddb12d8ff9a@codeaurora.org \
--to=tdas@codeaurora.org \
--cc=amit.kucheria@linaro.org \
--cc=evgreen@google.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox