From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E029CC001DF for ; Fri, 20 Oct 2023 16:16:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230028AbjJTQQb (ORCPT ); Fri, 20 Oct 2023 12:16:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230084AbjJTQQX (ORCPT ); Fri, 20 Oct 2023 12:16:23 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 67081170D; Fri, 20 Oct 2023 09:16:17 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DBBDD143D; Fri, 20 Oct 2023 09:16:57 -0700 (PDT) Received: from [10.57.82.142] (unknown [10.57.82.142]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DBC823F5A1; Fri, 20 Oct 2023 09:16:15 -0700 (PDT) Message-ID: Date: Fri, 20 Oct 2023 17:17:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 5/6] thermal: gov_step_wise: Fold update_passive_instance() into its caller Content-Language: en-US To: "Rafael J. Wysocki" Cc: LKML , Daniel Lezcano , Srinivas Pandruvada , Zhang Rui , Linux PM References: <13365827.uLZWGnKmhe@kreacher> <9177552.CDJkKcVGEf@kreacher> From: Lukasz Luba In-Reply-To: <9177552.CDJkKcVGEf@kreacher> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 10/6/23 18:49, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Fold update_passive_instance() into thermal_zone_trip_update() that is > its only caller so as to make the code in question easeir to follow. s/easeir/easier/ > > No intentional functional impact. > > Signed-off-by: Rafael J. Wysocki > --- > drivers/thermal/gov_step_wise.c | 28 ++++++++++------------------ > 1 file changed, 10 insertions(+), 18 deletions(-) > other than that LGTM: Reviewed-by: Lukasz Luba