From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5892756328E for ; Wed, 14 Oct 2026 16:45:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791996355; cv=none; b=Xc3hfYZI3ysep0vd9zdc/Q4F/NbIL7W1VY3QNX5pXbJqCq6ma8EugtyDhHPoT0C8XVhAFZzGb/qfL/rUxzRIdH6HlvZLsqosx9nlpOYvMYSCgkE+GYk8hJosl75u/5g93UDtCK2nXugamLMcW3rS4LI3Uta9hzBDz/na+g6QSgs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791996355; c=relaxed/simple; bh=avmiatq5ycfq3Gus4JRQptPL9QjSFPMI9z8DIWEoH7g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rnqGYUke64uW02HT7D70zTYmRn7okax/KNZEF/386dQ5/3N6Xriuwg4zp0P9nUzGRgwZlB3IAsBeKD1wm/q/5eYkGJ5V6EYgb6AVOyDaxyYCO3SBJWWZruCuYi5AhRA3+OyQWUFQERD18UiWbhnja8WQ2c8jM2EROIsY/mji42c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jEzHYwH9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KTJWLpLh; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jEzHYwH9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KTJWLpLh" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69EEbHu5467726 for ; Wed, 14 Oct 2026 16:45:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XOGH9ZC26XcWJ/gjq1+5uzlqR8S1/dn0I31tPVR1QeQ=; b=jEzHYwH934IrzYuI ynJmeEIh10QL7DWW/i4crH5aW5gLJqI9MFNYhhg/EPHi4iFypDBphxo4LKCahEk/ So5w5/cahPOjHd8RAXJjXucGpXKXSNchNgpOjmEUkdPhFuYdXbQDHRMMrvgNikEZ n7bDawQlRFRxtN2LksRIpTowMHqEKWRuOSbq7b1a6siGKwn6lP0AL9pT/ppwnYEp 4Bz7HmB1FLq3QJTsx+Ipz9cqdaMgaKM4yUCJWrh61m6X95F82nm+5BHWYL+BYwSG P5Gygm2w8POEDqWZcA30mucnro9zpWojaN3cyG2Nut8IWyXYfiDGfAIULC6rUWX4 yQ+Opw== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4h9yphkjvs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Oct 2026 16:45:52 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-917ad3b42eeso10614246d6.1 for ; Wed, 14 Oct 2026 09:45:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1791996352; x=1792601152; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XOGH9ZC26XcWJ/gjq1+5uzlqR8S1/dn0I31tPVR1QeQ=; b=KTJWLpLhcAgZyOkSdQEd3r3pzboXJzq5h9VkNEVZbDgtWVqjyKjCyAk6w+QvhNgpnS RvYsopkwt33PYkbMdpgrccHOAkZCHy8ymrXtZJiIPfmGJcIHvaoURJz9tTIRCuW9kq5E faWtq42WXe425d9obxspkgXD4lCMP7xt4ZKueRoI8/ZBRQqI+fsW2M9+j4Uh/bChcb0x XY5kSSitV4UBhFE7apOQwcU3AGLv9Z1OODl6SX4fbQnhpmOp0e6o7IjIKJg0HuZrrcI/ /4Pkgpfz3zR2brh3BSACHOCR/HJyVLqxCjiuQWshi3VWnB0lKJ4PaetsF+BKNdgnN0OG kf7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791996352; x=1792601152; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XOGH9ZC26XcWJ/gjq1+5uzlqR8S1/dn0I31tPVR1QeQ=; b=mHdKjF7VNF7ED9suLgr5LEawFQHgb0FL0Pj+jjR0HxhJKEy/anA739LiLiWC+waoYw N2jUVbatcUxRJrXS9grrOPYvq325HxzMPCkYm3v/LlrdhKTF89hH8Df+FoiTEJXY/b3A HqN0YQASDj8xToAzTTeKl5Ap3/viVkdo2X0msx9Y198Uf/2l68QtNGd6WV8w75BSkS61 rZ1qZa3LbH+kb0+ugggONx1OTpVzgeqMP5kxoNoF1GJIsmn1jkR7yWbeClzRTkhUst5r QjWFj1tfG6qFMxx1wWOFJ78OfPHw2CloEoDErFr+PB0f4+OJ1kicscyXyOjVt/uLOjh7 kOpw== X-Forwarded-Encrypted: i=1; AKwUvByiPF6rM7GHS2rPZixkEB/6+xqkoiqXadv8z87jo4ase/Od5biOxEJyXJIC3tcyOGGF7wSJioQ+vw==@vger.kernel.org X-Gm-Message-State: AFq9FYIB4cUot81S/DL4wC0yX105veRwgStwVLLBliKxljD4dHB81Tgt rn1RSLKCu0kEfG/uj7HXztD86c8A2VS5w+uHiB+kbalEbf+wulzxDLduH0PfwyBTWOPI0xTJMWf R1kegScaE+x3UGPbVORx5f94eKq5xtDrfGt0Ij2gBgGFWY92kmW4lDTtHdySXpg== X-Gm-Gg: AYBFou0uYkFqtB9j0eyDxT0g1lffpGaRx876Ju++NICgvWrE50YGocPJmA7/JSTfMQG qoa05RVGDQsWk393WkYKee4apNMiezANiZ72S3vswROn12Pqw4i8UaoViPlilTcDQ0EMl7XcMgs 7VEVncFeMyTHaTWGmDs295tuWVSBkFR1A4BA25FIxJS3ABFZ7VDSmptVFN7CemiJTkqfz5fRhNa qC2on3vrDnD1jHiK6gvtjpDb2iIJ6zmrlxBFHaUc6Upozb5CWuCm1H1NzHsurJB69hV2i7ZlrB4 G7Tsex4EmCBlCWDXb4x49xgvJoLOD464NDeyAyD7npcgK1fq6mQ23XU5jRuSjA5o5q84bDrNWRe KGZ8Gb1GKoTvgzyXjsssK4Q== X-Received: by 2002:a05:620a:6501:b0:93a:1312:ff19 with SMTP id af79cd13be357-93ebd2661bdmr3238437985a.5.1791996351357; Wed, 14 Oct 2026 09:45:51 -0700 (PDT) X-Received: by 2002:a05:620a:6501:b0:93a:1312:ff19 with SMTP id af79cd13be357-93ebd2661bdmr3238430085a.5.1791996350722; Wed, 14 Oct 2026 09:45:50 -0700 (PDT) Received: from [192.168.226.26] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c3eda61fb26sm4954766b.69.2026.10.14.09.45.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Oct 2026 09:45:49 -0700 (PDT) Message-ID: Date: Wed, 14 Oct 2026 18:45:46 +0200 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 07/16] clk: qcom: Add clock-owned GenPD DVFS aggregation To: Dmitry Baryshkov Cc: Konrad Dybcio , Stephen Boyd , Brian Masney , Jerome Brunet , Viresh Kumar , Nishanth Menon , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Greg Kroah-Hartman , Danilo Krummrich , Johan Hovold , Ulf Hansson , Bjorn Andersson , Abel Vesa , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Mike Tipton , Taniya Das , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, driver-core@lists.linux.dev, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20261014-topic-qc_clk_dvfs-v1-0-3041b788e9f7@oss.qualcomm.com> <20261014-topic-qc_clk_dvfs-v1-7-3041b788e9f7@oss.qualcomm.com> <6c9937a6-88c3-4e5f-85a3-73d929d3ba01@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: kN08DShgst-sQUbn_NzO2h1QTTl4OlOR X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE0MDA2NiBTYWx0ZWRfXwDneTAe0nj3v 7bTnjJWnsIvUblF9YVZwlDbaiEHQZMk2prel3BQ1p+2KcH5GMQPMgFsnWApSBy2+nYAC5NBUJzJ E6qRZyTXk/5H7OnI6S1CohChPL+Z+vU= X-Proofpoint-ORIG-GUID: kN08DShgst-sQUbn_NzO2h1QTTl4OlOR X-Authority-Analysis: v=2.4 cv=Uv72pOwB c=1 sm=1 tr=0 ts=6acfb1c0 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=XY6eGlS5OATuIy7doj0A:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE0MDA2NiBTYWx0ZWRfX6Pwvi4Ka5782 aOnuuv3RbMeiNlAx8mr9Ggs2ygGKC+bdIfqIJtTCRg3/70Sj7SuZoagy6TkYv2VKdoxfTH0Tcrg L+GSO42X/bksO6476O9ZUnZ2U6qETSxfNbJ7ho95Gjg76+KD6q4QmA4bT7CG9Ql6lWMdbc7Z4Id IWSssyi2KDsvhBUC7pOy4FvTjAnbTtA7vwwrH2ZPtbUvZz1neKQq8gE5qjRPkgObDDQuqxXoC4E 9ZHj1pdsTM0Je+Rh5NeVp7EMN1D+S/BrQ5SSSGgsOYzatLCtPlXUOVZiF4SJsexWJUvB50DcRhv RUpMHXF8Om/+6h4uFwYKUHcjLAWPNLCx0lKioJlHBtEBKgo0skZI9PxWJskJX4QlK9MH3SQ3twH UOZ/UcTfaoSDobVYkSiY3eY//Ar2E7D/cQgj9GjH+Kh+nPmG9tYpNO7Fsy9hp73eaecCqBADWFa H4QAcdCtBTmPY+Wtftw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-13_01,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 malwarescore=0 spamscore=0 adultscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610140066 On 10/14/26 6:30 PM, Dmitry Baryshkov wrote: > On Wed, Oct 14, 2026 at 05:26:00PM +0200, Konrad Dybcio wrote: >> On 10/14/26 4:36 PM, Dmitry Baryshkov wrote: >>> On Wed, Oct 14, 2026 at 02:19:07PM +0200, Konrad Dybcio wrote: >>>> From: Konrad Dybcio >>>> >>>> Clocks on Qualcomm SoCs need a minimum power rail performance state to >>>> operate at a given frequency. We currently leave this to clock >>>> consumers, so a driver has to know which power domains supply both the >>>> clock and its parents. This ties knowledge of the clock tree to >>>> individual consumers and doesn't protect other users that prepare or >>>> change the same clock without making those power requests. >>> >>> Why would they prepare or change the same clock without making power >>> requests? If it's a legitimate user of the clock, it should have an OPP >>> table. If it's not, it should have a separate API to set the clock via a >>> legitimate user / aggregator. >> >> That's the entire problem that motivated this series. The consumer >> doesn't know what it needs on Qualcomm platforms. The power >> requirements are that of the clock controller's, not of that device's. > > I'd still say that the consumers know that they need a certain > frequency, which demands a certain voltage / power / etc. Right, but the meaningful difference here is that the consumers only know they need a certain frequency. The required power votes from that don't stem from the consumer's requirements. They stem from the clock controller's inner workings that are necessary to fulfill the consumer's demand. [...] >> The Qualcomm case is easy - RPMH is *always* reachable, so the >> pmdomain provider needs no clocks itself. For the other cases, >> "patches welcome". > > Ok. There is a promise that I2C PMICs will never ever be involved in the > clock / power tables. Or at least that someone who needs them will contribute a solution to this problem. > >> >> [...] >> >>>> +static unsigned int >>>> +qcom_clk_dvfs_aggregate(struct qcom_clk_dvfs_rail_voter *rail_voter) >>>> +{ >>>> + struct qcom_clk_dvfs_vote *vote; >>>> + unsigned int level = 0; >>>> + >>>> + list_for_each_entry(vote, &rail_voter->votes, node) >>>> + level = max(level, vote->level); >>>> + >>>> + return max(level, rail_voter->safety_floor_level); >>> >>> I guess you want to avoid having too many voters, but would it be >>> possible to have one voter per 'signficant' clock and let GenPD itself >>> aggregate all the votes? >> >> What does "significant" mean here? > > I'd define it as "using a different power domain or requiring a > different corner". I still don't get it Konrad