From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB23BECAAD5 for ; Fri, 26 Aug 2022 22:36:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345061AbiHZWgf (ORCPT ); Fri, 26 Aug 2022 18:36:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232996AbiHZWge (ORCPT ); Fri, 26 Aug 2022 18:36:34 -0400 Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 544D2A61DC for ; Fri, 26 Aug 2022 15:36:32 -0700 (PDT) Received: by mail-oi1-x229.google.com with SMTP id t140so3679629oie.8 for ; Fri, 26 Aug 2022 15:36:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc; bh=Ofhm5bu3mqX4oZOke1Uk6LLRRxsC4M1BT8VbT7XnGuU=; b=Cn2RHA0xopllp4bDKXkq8Vniq2sdgYPx7j1g+kcS14Nn7aGFvcMyVn4kPcpQcKPVm6 j8xRrMyTaZL+nBHL7BH2j0a7LTB4EQ/CNDdtJgcFIb3Wf5yBv66/7uR+rdapHSCbX6/y 3MRrhupuyyywMQtgKkTKdjPNuhGEz+okxgKAA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc; bh=Ofhm5bu3mqX4oZOke1Uk6LLRRxsC4M1BT8VbT7XnGuU=; b=6CdDCnP+Fp67mxJ7E8cvkM0BizQxHNJNp2E+fZJ+foyhrv5P+U49P4Zmu573YkALcY mg78K0cxfHGEP1xzBJAxmuUQiwjSc+LW1tkKmxrUF5mmnakX/Uyt3g75y7JAh5mlmpGE 8Uqi4zafBJx5OKhyJtNG6IVNgAGwa31yUGkEFYRNWeGXrb6uuUA8KbNxp3qxwrRrmGfD XXZwxGsFv12AsKiJJOhek9jG9EBv2piYicj5sHkowxxmKmJUpfjTqu53fbibOh4vpDwz TxmgJllX5UF29Za2FPmUJlnCqiqfwZeyCKhdYKDAvssD083uSZb+hdpQGuf+c5pWHgD0 k+AQ== X-Gm-Message-State: ACgBeo3fTgGrQ/LmnlZnFC246OFOKB3sk6S+5N7xV3/N9DV9zBIJ79x8 aU4+hhva0DJ/8MGd5XTauskW8A== X-Google-Smtp-Source: AA6agR5eAKTdiz4NHx9btzEqNq+lUU2Dib4LQjotSGU5os8ZrxHdYmc1dH2vR7hAWdyvnk4NVDN8hQ== X-Received: by 2002:aca:b05:0:b0:343:53bf:3221 with SMTP id 5-20020aca0b05000000b0034353bf3221mr2536066oil.75.1661553391647; Fri, 26 Aug 2022 15:36:31 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id e5-20020aca1305000000b00344e3751fc4sm1560445oii.36.2022.08.26.15.36.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Aug 2022 15:36:31 -0700 (PDT) Subject: Re: [RESEND PATCH 2/4] cpufreq: amd-pstate: Add test module for amd-pstate driver To: Meng Li , Huang Rui , linux-pm@vger.kernel.org Cc: "Rafael J . Wysocki" , Nathan Fontenot , Deepak Sharma , Alex Deucher , Mario Limonciello , Jinzhou Su , Perry Yuan , Xiaojian Du , Viresh Kumar , Borislav Petkov , linux-kernel@vger.kernel.org, Shuah Khan References: <20220817034630.1172065-1-li.meng@amd.com> <20220817034630.1172065-3-li.meng@amd.com> <0f9706b7-6dd5-663d-70cf-7221b5a1bfc5@linuxfoundation.org> From: Shuah Khan Message-ID: Date: Fri, 26 Aug 2022 16:36:30 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <0f9706b7-6dd5-663d-70cf-7221b5a1bfc5@linuxfoundation.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 8/26/22 3:47 PM, Shuah Khan wrote: > On 8/16/22 9:46 PM, Meng Li wrote: >> Add amd-pstate-ut test module, this module is used by kselftest >> to unit test amd-pstate functionality. This module will be >> expected by some of selftests to be present and loaded. >> >> Signed-off-by: Meng Li >> Acked-by: Huang Rui >> Reviewed-by: Shuah Khan >> --- >>   drivers/cpufreq/Kconfig.x86     |   7 + >>   drivers/cpufreq/Makefile        |   1 + >>   drivers/cpufreq/amd-pstate-ut.c | 293 ++++++++++++++++++++++++++++++++ >>   3 files changed, 301 insertions(+) >>   create mode 100644 drivers/cpufreq/amd-pstate-ut.c >> >> diff --git a/drivers/cpufreq/Kconfig.x86 b/drivers/cpufreq/Kconfig.x86 >> index 55516043b656..fdd819069d72 100644 >> --- a/drivers/cpufreq/Kconfig.x86 >> +++ b/drivers/cpufreq/Kconfig.x86 >> @@ -51,6 +51,13 @@ config X86_AMD_PSTATE >>         If in doubt, say N. >> +config X86_AMD_PSTATE_UT >> +    tristate "selftest for AMD Processor P-State driver" >> +    depends on X86 && ACPI_PROCESSOR This has to specify dependency on X86_AMD_PSTATE >> +    default n >> +    help >> +      This kernel module is used for testing. It's safe to say M here. >> + > > Shouldn't this X86_AMD_PSTATE_UT depend on X86_AMD_PSTATE? > I am running a few tests and when I have X86_AMD_PSTATE_UT > enabled as built-in and X86_AMD_PSTATE is disabled, test > fails saying incorrect cpufreq driver? > > Skipped: Test can only run on amd-pstate driver. > > So it sounds like X86_AMD_PSTATE_UT depends on X86_AMD_PSTATE. > Once I enabled X86_AMD_PSTATE and X86_AMD_PSTATE_UT=m, the test ran correctly. Please fix the dependencies and send me a new version. Send all the patches so it is easier to apply them all at once. thanks, -- Shuah