* [PATCH v3 00/15] Introduce the SC8180x devices @ 2023-05-30 16:24 Vinod Koul 2023-05-30 16:24 ` [PATCH v3 03/15] dt-bindings: interconnect: split SC8180x to own schema Vinod Koul 2023-05-30 17:22 ` (subset) [PATCH v3 00/15] Introduce the SC8180x devices Bjorn Andersson 0 siblings, 2 replies; 6+ messages in thread From: Vinod Koul @ 2023-05-30 16:24 UTC (permalink / raw) To: Bjorn Andersson Cc: linux-arm-msm, Konrad Dybcio, Lorenzo Pieralisi, Krzysztof Wilczyński, Rob Herring, Bjorn Helgaas, Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam, Wesley Cheng, Georgi Djakov, Avri Altman, Bart Van Assche, Thomas Gleixner, Marc Zyngier, linux-pci, devicetree, linux-kernel, linux-usb, linux-pm, linux-scsi This introduces Qualcomm SC8180x SoC which features in Lenovo Flex 5G laptop. This also adds support for Primus platform as well as Lenovo Flex 5G laptop. Changes in v3: - Split DTS patch into smaller check - checkpatch and dtbs check error fixes - fix comments from Konrad/Krzysztof Changes in v2: - Fix the ufs pcie and phy bindings - Lots of error fixes for dtbs_check - Add few more missing compatiables Bjorn Andersson (3): arm64: dts: qcom: Introduce the SC8180x platform arm64: dts: qcom: sc8180x: Introduce Primus arm64: dts: qcom: sc8180x: Introduce Lenovo Flex 5G Vinod Koul (12): dt-bindings: PCI: qcom: Fix sc8180x clocks and interrupts dt-bindings: usb: qcom,dwc3: Add SC8180x binding dt-bindings: interconnect: split SC8180x to own schema scsi: ufs: dt-bindings: Add SC8180x binding dt-bindings: qcom,pdc: Add SC8180x compatible arm64: dts: qcom: sc8180x: Add interconnects and lmh arm64: dts: qcom: sc8180x: Add thermal zones arm64: dts: qcom: sc8180x: Add QUPs arm64: dts: qcom: sc8180x: Add PCIe instances arm64: dts: qcom: sc8180x: Add remoteprocs, wifi and usb nodes arm64: dts: qcom: sc8180x: Add display and gpu nodes arm64: dts: qcom: sc8180x: Add pmics .../bindings/interconnect/qcom,rpmh.yaml | 11 - .../interconnect/qcom,sc8180x-rpmh.yaml | 49 + .../interrupt-controller/qcom,pdc.yaml | 1 + .../devicetree/bindings/pci/qcom,pcie.yaml | 29 +- .../devicetree/bindings/ufs/qcom,ufs.yaml | 2 + .../devicetree/bindings/usb/qcom,dwc3.yaml | 3 + arch/arm64/boot/dts/qcom/Makefile | 2 + .../boot/dts/qcom/sc8180x-lenovo-flex-5g.dts | 583 +++ arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi | 326 ++ arch/arm64/boot/dts/qcom/sc8180x-primus.dts | 706 +++ arch/arm64/boot/dts/qcom/sc8180x.dtsi | 4030 +++++++++++++++++ 11 files changed, 5730 insertions(+), 12 deletions(-) create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sc8180x-rpmh.yaml create mode 100644 arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts create mode 100644 arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi create mode 100644 arch/arm64/boot/dts/qcom/sc8180x-primus.dts create mode 100644 arch/arm64/boot/dts/qcom/sc8180x.dtsi -- 2.40.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3 03/15] dt-bindings: interconnect: split SC8180x to own schema 2023-05-30 16:24 [PATCH v3 00/15] Introduce the SC8180x devices Vinod Koul @ 2023-05-30 16:24 ` Vinod Koul 2023-05-31 8:22 ` Krzysztof Kozlowski 2023-05-30 17:22 ` (subset) [PATCH v3 00/15] Introduce the SC8180x devices Bjorn Andersson 1 sibling, 1 reply; 6+ messages in thread From: Vinod Koul @ 2023-05-30 16:24 UTC (permalink / raw) To: Bjorn Andersson Cc: linux-arm-msm, Konrad Dybcio, Georgi Djakov, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-pm, devicetree, linux-kernel, Vinod Koul SC8180x comes with interconnects with missing IO address space and variable number of clocks, so split it from common file for easier maintenance and to fix warnings like: sc8180x-lenovo-flex-5g.dtb: interconnect-0: 'reg' is a required property Signed-off-by: Vinod Koul <vkoul@kernel.org> --- .../bindings/interconnect/qcom,rpmh.yaml | 11 ----- .../interconnect/qcom,sc8180x-rpmh.yaml | 49 +++++++++++++++++++ 2 files changed, 49 insertions(+), 11 deletions(-) create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sc8180x-rpmh.yaml diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml index 4d93ad415e0b..5cbc3be49e99 100644 --- a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml @@ -39,17 +39,6 @@ properties: - qcom,sc7180-npu-noc - qcom,sc7180-qup-virt - qcom,sc7180-system-noc - - qcom,sc8180x-aggre1-noc - - qcom,sc8180x-aggre2-noc - - qcom,sc8180x-camnoc-virt - - qcom,sc8180x-compute-noc - - qcom,sc8180x-config-noc - - qcom,sc8180x-dc-noc - - qcom,sc8180x-gem-noc - - qcom,sc8180x-mc-virt - - qcom,sc8180x-mmss-noc - - qcom,sc8180x-qup-virt - - qcom,sc8180x-system-noc - qcom,sdm670-aggre1-noc - qcom,sdm670-aggre2-noc - qcom,sdm670-config-noc diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sc8180x-rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sc8180x-rpmh.yaml new file mode 100644 index 000000000000..b182c2c5addc --- /dev/null +++ b/Documentation/devicetree/bindings/interconnect/qcom,sc8180x-rpmh.yaml @@ -0,0 +1,49 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/interconnect/qcom,sc8180x-rpmh.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm RPMh Network-On-Chip Interconnect on SC8180X + +maintainers: + - Bjorn Andersson <andersson@kernel.org> + - Konrad Dybcio <konrad.dybcio@linaro.org> + +description: | + RPMh interconnect providers support system bandwidth requirements through + RPMh hardware accelerators known as Bus Clock Manager (BCM). + + See also:: include/dt-bindings/interconnect/qcom,sc8180x.h + +properties: + compatible: + enum: + - qcom,sc8180x-aggre1-noc + - qcom,sc8180x-aggre2-noc + - qcom,sc8180x-camnoc-virt + - qcom,sc8180x-compute-noc + - qcom,sc8180x-config-noc + - qcom,sc8180x-dc-noc + - qcom,sc8180x-gem-noc + - qcom,sc8180x-ipa-virt + - qcom,sc8180x-mc-virt + - qcom,sc8180x-mmss-noc + - qcom,sc8180x-qup-virt + - qcom,sc8180x-system-noc + +required: + - compatible + +allOf: + - $ref: qcom,rpmh-common.yaml# + +unevaluatedProperties: false + +examples: + - | + interconnect-0 { + compatible = "qcom,sc8180x-camnoc-virt"; + #interconnect-cells = <2>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; -- 2.40.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3 03/15] dt-bindings: interconnect: split SC8180x to own schema 2023-05-30 16:24 ` [PATCH v3 03/15] dt-bindings: interconnect: split SC8180x to own schema Vinod Koul @ 2023-05-31 8:22 ` Krzysztof Kozlowski 2023-06-01 7:23 ` Vinod Koul 0 siblings, 1 reply; 6+ messages in thread From: Krzysztof Kozlowski @ 2023-05-31 8:22 UTC (permalink / raw) To: Vinod Koul, Bjorn Andersson Cc: linux-arm-msm, Konrad Dybcio, Georgi Djakov, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-pm, devicetree, linux-kernel On 30/05/2023 18:24, Vinod Koul wrote: > SC8180x comes with interconnects with missing IO address space and > variable number of clocks, so split it from common file for easier > maintenance and to fix warnings like: > > sc8180x-lenovo-flex-5g.dtb: interconnect-0: 'reg' is a required property > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > --- > .../bindings/interconnect/qcom,rpmh.yaml | 11 ----- > .../interconnect/qcom,sc8180x-rpmh.yaml | 49 +++++++++++++++++++ > 2 files changed, 49 insertions(+), 11 deletions(-) > create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sc8180x-rpmh.yaml > > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml > index 4d93ad415e0b..5cbc3be49e99 100644 > --- a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml > +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml > @@ -39,17 +39,6 @@ properties: > - qcom,sc7180-npu-noc > - qcom,sc7180-qup-virt > - qcom,sc7180-system-noc > - - qcom,sc8180x-aggre1-noc > - - qcom,sc8180x-aggre2-noc > - - qcom,sc8180x-camnoc-virt > - - qcom,sc8180x-compute-noc > - - qcom,sc8180x-config-noc > - - qcom,sc8180x-dc-noc > - - qcom,sc8180x-gem-noc > - - qcom,sc8180x-mc-virt > - - qcom,sc8180x-mmss-noc > - - qcom,sc8180x-qup-virt > - - qcom,sc8180x-system-noc > - qcom,sdm670-aggre1-noc > - qcom,sdm670-aggre2-noc > - qcom,sdm670-config-noc > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sc8180x-rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sc8180x-rpmh.yaml > new file mode 100644 > index 000000000000..b182c2c5addc > --- /dev/null > +++ b/Documentation/devicetree/bindings/interconnect/qcom,sc8180x-rpmh.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/interconnect/qcom,sc8180x-rpmh.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm RPMh Network-On-Chip Interconnect on SC8180X > + > +maintainers: > + - Bjorn Andersson <andersson@kernel.org> > + - Konrad Dybcio <konrad.dybcio@linaro.org> > + > +description: | > + RPMh interconnect providers support system bandwidth requirements through > + RPMh hardware accelerators known as Bus Clock Manager (BCM). > + > + See also:: include/dt-bindings/interconnect/qcom,sc8180x.h > + > +properties: > + compatible: > + enum: > + - qcom,sc8180x-aggre1-noc > + - qcom,sc8180x-aggre2-noc > + - qcom,sc8180x-camnoc-virt > + - qcom,sc8180x-compute-noc > + - qcom,sc8180x-config-noc > + - qcom,sc8180x-dc-noc > + - qcom,sc8180x-gem-noc > + - qcom,sc8180x-ipa-virt > + - qcom,sc8180x-mc-virt > + - qcom,sc8180x-mmss-noc > + - qcom,sc8180x-qup-virt > + - qcom,sc8180x-system-noc > + > +required: > + - compatible > + > +allOf: > + - $ref: qcom,rpmh-common.yaml# This should be based on sc7280. You need reg for some of the entries. > + > +unevaluatedProperties: false > + > +examples: > + - | > + interconnect-0 { Just "interconnect" > + compatible = "qcom,sc8180x-camnoc-virt"; > + #interconnect-cells = <2>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 03/15] dt-bindings: interconnect: split SC8180x to own schema 2023-05-31 8:22 ` Krzysztof Kozlowski @ 2023-06-01 7:23 ` Vinod Koul 2023-06-01 7:26 ` Krzysztof Kozlowski 0 siblings, 1 reply; 6+ messages in thread From: Vinod Koul @ 2023-06-01 7:23 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Bjorn Andersson, linux-arm-msm, Konrad Dybcio, Georgi Djakov, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-pm, devicetree, linux-kernel On 31-05-23, 10:22, Krzysztof Kozlowski wrote: > On 30/05/2023 18:24, Vinod Koul wrote: > > SC8180x comes with interconnects with missing IO address space and > > variable number of clocks, so split it from common file for easier > > maintenance and to fix warnings like: > > > > sc8180x-lenovo-flex-5g.dtb: interconnect-0: 'reg' is a required property > > > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > > --- > > .../bindings/interconnect/qcom,rpmh.yaml | 11 ----- > > .../interconnect/qcom,sc8180x-rpmh.yaml | 49 +++++++++++++++++++ > > 2 files changed, 49 insertions(+), 11 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sc8180x-rpmh.yaml > > > > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml > > index 4d93ad415e0b..5cbc3be49e99 100644 > > --- a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml > > +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml > > @@ -39,17 +39,6 @@ properties: > > - qcom,sc7180-npu-noc > > - qcom,sc7180-qup-virt > > - qcom,sc7180-system-noc > > - - qcom,sc8180x-aggre1-noc > > - - qcom,sc8180x-aggre2-noc > > - - qcom,sc8180x-camnoc-virt > > - - qcom,sc8180x-compute-noc > > - - qcom,sc8180x-config-noc > > - - qcom,sc8180x-dc-noc > > - - qcom,sc8180x-gem-noc > > - - qcom,sc8180x-mc-virt > > - - qcom,sc8180x-mmss-noc > > - - qcom,sc8180x-qup-virt > > - - qcom,sc8180x-system-noc > > - qcom,sdm670-aggre1-noc > > - qcom,sdm670-aggre2-noc > > - qcom,sdm670-config-noc > > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sc8180x-rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sc8180x-rpmh.yaml > > new file mode 100644 > > index 000000000000..b182c2c5addc > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/interconnect/qcom,sc8180x-rpmh.yaml > > @@ -0,0 +1,49 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/interconnect/qcom,sc8180x-rpmh.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Qualcomm RPMh Network-On-Chip Interconnect on SC8180X > > + > > +maintainers: > > + - Bjorn Andersson <andersson@kernel.org> > > + - Konrad Dybcio <konrad.dybcio@linaro.org> > > + > > +description: | > > + RPMh interconnect providers support system bandwidth requirements through > > + RPMh hardware accelerators known as Bus Clock Manager (BCM). > > + > > + See also:: include/dt-bindings/interconnect/qcom,sc8180x.h > > + > > +properties: > > + compatible: > > + enum: > > + - qcom,sc8180x-aggre1-noc > > + - qcom,sc8180x-aggre2-noc > > + - qcom,sc8180x-camnoc-virt > > + - qcom,sc8180x-compute-noc > > + - qcom,sc8180x-config-noc > > + - qcom,sc8180x-dc-noc > > + - qcom,sc8180x-gem-noc > > + - qcom,sc8180x-ipa-virt > > + - qcom,sc8180x-mc-virt > > + - qcom,sc8180x-mmss-noc > > + - qcom,sc8180x-qup-virt > > + - qcom,sc8180x-system-noc > > + > > +required: > > + - compatible > > + > > +allOf: > > + - $ref: qcom,rpmh-common.yaml# > > This should be based on sc7280. You need reg for some of the entries. Yes missed reg part here. Question is should it be added sc7280 or have a different file, I think doing former is better > > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + interconnect-0 { > > Just "interconnect" Nope. We have multiple virtual nodes here so interconnect-N would need to be done -- ~Vinod ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 03/15] dt-bindings: interconnect: split SC8180x to own schema 2023-06-01 7:23 ` Vinod Koul @ 2023-06-01 7:26 ` Krzysztof Kozlowski 0 siblings, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2023-06-01 7:26 UTC (permalink / raw) To: Vinod Koul Cc: Bjorn Andersson, linux-arm-msm, Konrad Dybcio, Georgi Djakov, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-pm, devicetree, linux-kernel On 01/06/2023 09:23, Vinod Koul wrote: >> >>> + >>> +unevaluatedProperties: false >>> + >>> +examples: >>> + - | >>> + interconnect-0 { >> >> Just "interconnect" > > Nope. We have multiple virtual nodes here so interconnect-N would > need to be done > You don't have. You have only one node here. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (subset) [PATCH v3 00/15] Introduce the SC8180x devices 2023-05-30 16:24 [PATCH v3 00/15] Introduce the SC8180x devices Vinod Koul 2023-05-30 16:24 ` [PATCH v3 03/15] dt-bindings: interconnect: split SC8180x to own schema Vinod Koul @ 2023-05-30 17:22 ` Bjorn Andersson 1 sibling, 0 replies; 6+ messages in thread From: Bjorn Andersson @ 2023-05-30 17:22 UTC (permalink / raw) To: Vinod Koul Cc: Bart Van Assche, Lorenzo Pieralisi, linux-pci, Krzysztof Kozlowski, devicetree, Krzysztof Wilczyński, Rob Herring, Wesley Cheng, linux-scsi, Marc Zyngier, linux-pm, linux-arm-msm, Manivannan Sadhasivam, Avri Altman, Georgi Djakov, Thomas Gleixner, linux-kernel, linux-usb, Konrad Dybcio, Conor Dooley, Bjorn Helgaas On Tue, 30 May 2023 21:54:39 +0530, Vinod Koul wrote: > This introduces Qualcomm SC8180x SoC which features in Lenovo Flex 5G > laptop. This also adds support for Primus platform as well as Lenovo Flex 5G > laptop. > > Changes in v3: > - Split DTS patch into smaller check > - checkpatch and dtbs check error fixes > - fix comments from Konrad/Krzysztof > > [...] Quite a few DT validation warnings left, but let's get it merged so that we can work on those together. Applied, thanks! [06/15] arm64: dts: qcom: Introduce the SC8180x platform commit: 8575f197b077001591ef3ff709cdee48785daf0d [07/15] arm64: dts: qcom: sc8180x: Add interconnects and lmh commit: f3be8a111d7eaf4e291b6c2d51dd0adb39934b32 [08/15] arm64: dts: qcom: sc8180x: Add thermal zones commit: d1d3ca03554e51be44546638f83169bb05b20ef8 [09/15] arm64: dts: qcom: sc8180x: Add QUPs commit: 0018761d1564f64d567e119fd9156c473b4592d7 [10/15] arm64: dts: qcom: sc8180x: Add PCIe instances commit: d20b6c84f56ae3a9823cc0fa5cfad330536ba0d1 [11/15] arm64: dts: qcom: sc8180x: Add remoteprocs, wifi and usb nodes commit: b080f53a8f44eeaa9db9628d8d339ab5a2afb5bd [12/15] arm64: dts: qcom: sc8180x: Add display and gpu nodes commit: 494dec9b6f541451b2e82905b0eebd9a4ac9848b [13/15] arm64: dts: qcom: sc8180x: Add pmics commit: d3302290f59e8533a56a8fa2455357f843d8dcf6 [14/15] arm64: dts: qcom: sc8180x: Introduce Primus commit: 2ce38cc1e8fea4e251e4563e436104369bf3b322 [15/15] arm64: dts: qcom: sc8180x: Introduce Lenovo Flex 5G commit: 20dea72a393c6d5572088b8ad01dbb9e9aca64ce Best regards, -- Bjorn Andersson <andersson@kernel.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-06-01 7:27 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-05-30 16:24 [PATCH v3 00/15] Introduce the SC8180x devices Vinod Koul 2023-05-30 16:24 ` [PATCH v3 03/15] dt-bindings: interconnect: split SC8180x to own schema Vinod Koul 2023-05-31 8:22 ` Krzysztof Kozlowski 2023-06-01 7:23 ` Vinod Koul 2023-06-01 7:26 ` Krzysztof Kozlowski 2023-05-30 17:22 ` (subset) [PATCH v3 00/15] Introduce the SC8180x devices Bjorn Andersson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).