From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25C91EB64DA for ; Sat, 17 Jun 2023 07:15:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234063AbjFQHPJ (ORCPT ); Sat, 17 Jun 2023 03:15:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229506AbjFQHPH (ORCPT ); Sat, 17 Jun 2023 03:15:07 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D23F3211D for ; Sat, 17 Jun 2023 00:15:05 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-3f8fae01224so9381365e9.3 for ; Sat, 17 Jun 2023 00:15:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686986104; x=1689578104; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qkJta/itqN/plYtDpPSK5B2b/lfTXQ8wtnzVNHq6pLE=; b=ycmJGcahVDhbo4zOAmSq3lKerxRW6RC3JCMzXhwfVt5UvBk/TgeuQrTapqugeYLPvN qy0ktDd9U08LGZRRgjXYmhb0ILQAwM0B6A95fewx/Wu4+UyZt0LHuMCQl5WU75ujZT5C rm2ojIKbqyY7CbIHO6hKRDcknLcpqncqujV7u4oKlx7iDKUY1fPolscXd3QiTudbPkmG sFWJj2vaHfaMykLDDUY3YkUVbtu59vkMCos6sGf69zVRjNvwso5WYKUDQOwNEfK25HCE 1gTotbnZv9vvgda7fR62QgrhXFFPo66oqyiIjXt3t3PJ3UrmUe2vvInawh6CHBXDEZY+ QWPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686986104; x=1689578104; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qkJta/itqN/plYtDpPSK5B2b/lfTXQ8wtnzVNHq6pLE=; b=SGSolW+Gior/O3kwzLPNyWi2e1LhlqLmWmAx1lzZWEdcEGvLpZdmZGgZZhNzGBW0Is 4/fON73xIaIYfSktiqmXZsmTtghmKWqtGEPR1tHMascv49sCTklxycxZpVmRO9cgVEUx 7VJ8bq2mwVRMGeq6fSufbrbOZE6MFJBi6YgLwu1J2QobtbLlrfRUEwxGqwXerdFocG+e tknBZJggNGvVXp9R30ccy7BXoLcf++XF+y7nI+ts1+qXiU0xwsgq+i5PRjdiv8BLsdUt 1GqAXf1Xhxh7X2ggfqf9hcuqgcBMWAsEMOG6d1BpFF9ycpJPw9WSsV3u6tuRsHnXR9J3 zkIg== X-Gm-Message-State: AC+VfDy0//Y0bK9kedPGTzTEPXQZaoYubDRARRFOOOpT+Bcho8V8Wl+k ISy9WyYRBWHeTMO1tpHe9oIj/QtpbIKq78A2PvI= X-Google-Smtp-Source: ACHHUZ5OiiQzsETNaWBoHR3RwTTo+lhlSaUAJZCEBguY17vTlskHr3Q8Om8diCiSMwvip/2wP+bn/A== X-Received: by 2002:a05:600c:2043:b0:3f7:3280:810b with SMTP id p3-20020a05600c204300b003f73280810bmr2941325wmg.19.1686986104226; Sat, 17 Jun 2023 00:15:04 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:4aa0:8c56:eebe:c05c? ([2a05:6e02:1041:c10:4aa0:8c56:eebe:c05c]) by smtp.googlemail.com with ESMTPSA id p19-20020a05600c469300b003f7f475c3bcsm11212368wmo.1.2023.06.17.00.15.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Jun 2023 00:15:03 -0700 (PDT) Message-ID: Date: Sat, 17 Jun 2023 09:15:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v14 1/2] thermal: loongson-2: add thermal management support Content-Language: en-US To: zhuyinbo , "Rafael J . Wysocki" , Amit Kucheria , Zhang Rui , Rob Herring , Krzysztof Kozlowski , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jianmin Lv , wanghongliang@loongson.cn, Liu Peibao , loongson-kernel@lists.loongnix.cn, zhanghongchen References: <20230426062018.19755-1-zhuyinbo@loongson.cn> From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 17/06/2023 05:25, zhuyinbo wrote: > > Hi Daniel, > > 在 2023/6/12 下午10:22, Daniel Lezcano 写道: > > ... > >>> >>> +#define LOONGSON2_SOC_MAX_SENSOR_NUM            4 >>> + >>> +#define LOONGSON2_TSENSOR_CTRL_HI            0x0 >>> +#define LOONGSON2_TSENSOR_CTRL_LO            0x8 >>> +#define LOONGSON2_TSENSOR_STATUS            0x10 >>> +#define LOONGSON2_TSENSOR_OUT                0x14 >> >> Please use BIT() macros > > > I learn about that BIT() is generally used to describe the functional > bit or control bit or status bits of a register, but these register was > some different register offset and not some control bit or status bit > So using BIT() here seems a bit inappropriate, Do you think so? Yes, you are right -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog