From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3FBCC6FD1C for ; Wed, 22 Mar 2023 17:50:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229768AbjCVRu2 (ORCPT ); Wed, 22 Mar 2023 13:50:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbjCVRu2 (ORCPT ); Wed, 22 Mar 2023 13:50:28 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CECA85D768 for ; Wed, 22 Mar 2023 10:50:26 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id eg48so76150510edb.13 for ; Wed, 22 Mar 2023 10:50:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679507425; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mZzncM0ecKdqEUsYhFXJ0esFYC/77XMfZpKnpzc9Pjo=; b=IUcv6xcY+oUqK4B4K+n84pEjRF1Psx65H0Dzjchq8r9f3+jpmE1pTENA5uA0BnowzV uAHKGZCR8yyg8Jit+UxQTdJxCROGAN7uq348vwc8S2H69pRtl7tUsw44O5Il6UYtsaJL kIMT/tK/BdJkDTFqio8I+0g8YAPmolNKM2rkS6ZjgwM4RAGgA6WhN5o4jOmnT6ttDilQ a3ta6K4l537tFjok0DlhZ9IE32cWpzokB25Z8h/HHOCll7WdcSeM+E6xHn8hIPWbxpUZ Ckdf5kTeXeg1u3DT1CiQzwqLefbWDZdlXRqhCNrxoLWtqhOhJLBBbtau0hTEpNq78HqY ccXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679507425; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mZzncM0ecKdqEUsYhFXJ0esFYC/77XMfZpKnpzc9Pjo=; b=b/OQDgoBis8xlb0WbIBbrfAx9/f4wzj4zxnObKzPldCONBE16Z00hhv0WJ+5LY8Mka azX7ofQV01USMM5UxIDJ8YQmnEBAePCQwUJay9P+FPMa7jnISJs42mUKY/01ZYjoZ/SU Kl4VFQJN2wtse+7ItcJUzsOW/ngVsq+H0Xe+DlsJ4uqQysr1ANKjDMCe0vnxlHZarJ5v 6TBLrisJG3qoeu52x7Xs1KLGUivPXsRvFF4xRUR7ni2XoDGPdA/6SiZaUdfxRlWNwvn1 iO9+e2JJ09nOtQQ+OY64ExfJRAhq8DP1/BDUZi56A9jCbcTyWEH69vvKk3m9sh/gDj+R EWSA== X-Gm-Message-State: AO0yUKUvkes1Qhn2kvJjT2eftLQGRQM2kdglvfvzWUR1RG8l3yYHXO/d cnlAMiiN6XzrVUC4QK3A8OaSMA== X-Google-Smtp-Source: AK7set88wcc7ojm59JKSFAtUU+gUBZdzhodrq/+Pzcm7IRcfUHbjARjZBB5XSt1Qx/Feg+Y9p4huHA== X-Received: by 2002:a17:906:abd2:b0:918:668d:d6f9 with SMTP id kq18-20020a170906abd200b00918668dd6f9mr7468362ejb.16.1679507425316; Wed, 22 Mar 2023 10:50:25 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:5050:151b:e755:1c6? ([2a02:810d:15c0:828:5050:151b:e755:1c6]) by smtp.gmail.com with ESMTPSA id gy24-20020a170906f25800b00930445428acsm7656194ejb.14.2023.03.22.10.50.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Mar 2023 10:50:24 -0700 (PDT) Message-ID: Date: Wed, 22 Mar 2023 18:50:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [Patch v3 10/11] memory: tegra: handle no BWMGR MRQ support in BPMP Content-Language: en-US To: Sumit Gupta , treding@nvidia.com, dmitry.osipenko@collabora.com, viresh.kumar@linaro.org, rafael@kernel.org, jonathanh@nvidia.com, robh+dt@kernel.org, lpieralisi@kernel.org Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, mmaddireddy@nvidia.com, kw@linux.com, bhelgaas@google.com, vidyas@nvidia.com, sanjayc@nvidia.com, ksitaraman@nvidia.com, ishah@nvidia.com, bbasu@nvidia.com References: <20230320182441.11904-1-sumitg@nvidia.com> <20230320182441.11904-11-sumitg@nvidia.com> From: Krzysztof Kozlowski In-Reply-To: <20230320182441.11904-11-sumitg@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 20/03/2023 19:24, Sumit Gupta wrote: > If BPMP-FW doesn't support 'MRQ_BWMGR_INT', then the MC Client driver > probe fails with 'EPROBE_DEFER' which it receives on calling the func > 'devm_of_icc_get()'. Fix this by initializing the ICC even if the MRQ > is missing and return 'EINVAL' from 'icc_set_bw()' instead of passing > the request to BPMP-FW later when the BW request is made by client. > > Fixes: ("memory: tegra: add interconnect support for DRAM scaling in Tegra234") That's not correct tag. Anyway, send fixes separately. Best regards, Krzysztof