From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
ilia.lin@kernel.org, agross@kernel.org,
bjorn.andersson@linaro.org, rafael@kernel.org,
viresh.kumar@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [RESEND PATCH 4/5] cpufreq: qcom-cpufreq-nvmem: Rename qcs404 data to cpr_genpd
Date: Wed, 13 Jul 2022 15:52:50 +0100 [thread overview]
Message-ID: <ded0065e-0315-ce1f-01da-bdf3b83adf66@linaro.org> (raw)
In-Reply-To: <e160364f-68b9-2ab6-e48d-86d12e4a2f0c@linaro.org>
On 13/07/2022 14:50, Dmitry Baryshkov wrote:
> On 29/06/2022 16:03, Bryan O'Donoghue wrote:
>> At the moment the CPR genpd based code is named after the qcs404 however
>> msm8936, msm8939 and other antecedent processors of the qcs404 can also
>> make use of this data.
>>
>> Rename it to reflect a more generic use.
>>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> ---
>> drivers/cpufreq/qcom-cpufreq-nvmem.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/cpufreq/qcom-cpufreq-nvmem.c
>> b/drivers/cpufreq/qcom-cpufreq-nvmem.c
>> index 6dfa86971a757..355c8b99e974a 100644
>> --- a/drivers/cpufreq/qcom-cpufreq-nvmem.c
>> +++ b/drivers/cpufreq/qcom-cpufreq-nvmem.c
>> @@ -252,10 +252,10 @@ static const struct qcom_cpufreq_match_data
>> match_data_krait = {
>> .get_version = qcom_cpufreq_krait_name_version,
>> };
>> -static const char *qcs404_genpd_names[] = { "cpr", NULL };
>> +static const char *cpr_genpd_names[] = { "cpr", NULL };
>
> As a generic comment, as you are touching this piece of code, code you
> please move cpr_genpd_names above match_data_kryo? So that all
> match_data instances can use it.
NP.
This has been dropped in V3 per Stephan's preference to not touch
anything CPR related until doing the whole thing for 8939.
---
bod
next prev parent reply other threads:[~2022-07-13 14:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 13:02 [RESEND PATCH 0/5] qcom-cpufreq-nvmem: Add msm8939 with some fixups Bryan O'Donoghue
2022-06-29 13:02 ` [RESEND PATCH 1/5] dt-bindings: opp: Add missing compat devices Bryan O'Donoghue
2022-06-29 18:19 ` Krzysztof Kozlowski
2022-06-29 22:36 ` Rob Herring
2022-06-30 4:10 ` Bryan O'Donoghue
2022-06-30 21:16 ` Rob Herring
2022-06-30 21:16 ` Rob Herring
2022-06-29 13:03 ` [RESEND PATCH 2/5] dt-bindings: opp: Add msm8939 to the compatible list Bryan O'Donoghue
2022-06-29 18:20 ` Krzysztof Kozlowski
2022-06-29 13:03 ` [RESEND PATCH 3/5] cpufreq: blocklist Qualcomm msm8939 in cpufreq-dt-platdev Bryan O'Donoghue
2022-06-29 13:03 ` [RESEND PATCH 4/5] cpufreq: qcom-cpufreq-nvmem: Rename qcs404 data to cpr_genpd Bryan O'Donoghue
2022-06-29 19:11 ` Stephan Gerhold
2022-06-30 4:05 ` Bryan O'Donoghue
2022-06-30 18:25 ` Stephan Gerhold
2022-07-13 13:50 ` Dmitry Baryshkov
2022-07-13 14:52 ` Bryan O'Donoghue [this message]
2022-06-29 13:03 ` [RESEND PATCH 5/5] cpufreq: qcom-cpufreq-nvmem: Add msm8939 as cpr_genpd Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ded0065e-0315-ce1f-01da-bdf3b83adf66@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=ilia.lin@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).