From: Christian Loehle <christian.loehle@arm.com>
To: "Rafael J. Wysocki (Intel)" <rafael@kernel.org>
Cc: Linux PM <linux-pm@vger.kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Doug Smythies <dsmythies@telus.net>,
Zak <zakbrightonknight@gmail.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Mario Limonciello <superm1@kernel.org>
Subject: Re: [PATCH v2 2/3] cpufreq: Force passing target frequency to driver during resume
Date: Wed, 4 Nov 2026 15:09:25 +0000 [thread overview]
Message-ID: <defdec33-3006-4ecd-a5d9-c323af70047c@arm.com> (raw)
In-Reply-To: <CAJZ5v0hQOjNP8tWfyKKV9UPUDSFWFsKVpcc_HZjpi8WHO6p_1Q@mail.gmail.com>
On 11/4/26 13:44, Rafael J. Wysocki (Intel) wrote:
> On Wed, Nov 4, 2026 at 12:56 PM Christian Loehle
> <christian.loehle@arm.com> wrote:
>>
>> On 11/3/26 19:47, Rafael J. Wysocki wrote:
>>> From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
>>>
>>> The policy->cur value preserved across a system suspend-resume cycle
>>> may become stale in some cases and it may prevent the CPU performance
>>> scaling logic from being updated due to the target_freq == policy->cur
>>> check in __cpufreq_driver_target() [1].
>>>
>>> To address this, adjust the existing mechanism to force the invocation
>>> of the driver .target() callback in __cpufreq_driver_target() and make
>>> cpufreq_resume_policy() use it.
>>>
>>> This involves renaming update_limits in struct cpufreq_policy to
>>> force_target and moving the driver CPUFREQ_NEED_UPDATE_LIMITS flag check
>>> from __cpufreq_driver_target() to cpufreq_set_policy(), where it is used
>>> as a condition for setting policy->force_target.
>>>
>>> In cpufreq_resume_policy(), policy->force_target is set for drivers that
>>> implement the .target() callback, but don't implement the .get() one,
>>> which is the case when the driver callback needs to run if policy->cur
>>> becomes stale while suspended.
>>>
>>> Fixes: 2f0aea936360 ("cpufreq: suspend governors on system suspend/hibernate")
>>> Link: https://lore.kernel.org/linux-pm/20261027143725.3763827-1-zakbrightonknight@gmail.com/ [1]
>>> Reported-by: Zak Brighton Knight <zakbrightonknight@gmail.com>
>>> Reported-by: Doug Smythies <dsmythies@telus.net>
>>> Cc: All applicable <stable@vger.kernel.org>
>>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>> ---
>>>
>>> v1 -> v2:
>>> * Always clear policy->force_target if set in __cpufreq_driver_target()
>>> to avoid forcing the driver callback next time unnecessarily (Sashiko)
>>>
>>> * Replace an outdated comment in __cpufreq_driver_target()
>>>
>>> * Set policy->force_target only if .target() is present and .get() is not
>>> present because that is the only case in which it may matter
>>>
>>> * Update changelog
>>>
>>> ---
>>> drivers/cpufreq/cpufreq.c | 33 +++++++++++++++++++++------------
>>> include/linux/cpufreq.h | 4 ++--
>>> 2 files changed, 23 insertions(+), 14 deletions(-)
>>>
>>> --- a/drivers/cpufreq/cpufreq.c
>>> +++ b/drivers/cpufreq/cpufreq.c
>>> @@ -2023,6 +2023,15 @@ static void cpufreq_resume_policy(struct
>>> if (!start)
>>> return;
>>>
>>> + /*
>>> + * Force executing the driver .target() callback, if present, in the
>>> + * next invocation of __cpufreq_driver_target() in case policy->cur has
>>> + * become stale while suspended, but do it only for drivers without a
>>> + * .get() callback for which cpufreq_verify_current_freq() is a NOP.
>>> + */
>>> + if (cpufreq_driver->target && !cpufreq_driver->get)
>>> + policy->force_target = true;
>>> +
>>> if (cpufreq_start_governor(policy))
>>> pr_err("%s: Failed to start governor for CPU%u's policy\n",
>>> __func__, policy->cpu);
>>> @@ -2400,17 +2409,14 @@ int __cpufreq_driver_target(struct cpufr
>>> policy->cpu, policy->cur, target_freq, old_target_freq, relation);
>>>
>>> /*
>>> - * This might look like a redundant call as we are checking it again
>>> - * after finding index. But it is left intentionally for cases where
>>> - * exactly same freq is called again and so we can save on few function
>>> - * calls.
>>> + * Unless invoking the target callback is forced, skip the update if the
>>> + * frequency is not really changing.
>>> */
>>> - if (target_freq == policy->cur) {
>>> - if (!(cpufreq_driver->flags & CPUFREQ_NEED_UPDATE_LIMITS) ||
>>> - !policy->update_limits)
>>> - return 0;
>>> -
>>> - policy->update_limits = false;
>>> + if (policy->force_target) {
>>> + /* Avoid forcing the driver callback unnecessarily next time. */
>>> + policy->force_target = false;
>>> + } else if (target_freq == policy->cur) {
>>> + return 0;
>>> [snip]
>>
>> This is too early though? Should be something like:
>
> I don't think so.
>
> If the driver has a problem, there is not much the core can do about it.
>
> Do you have any specific drivers in mind here?
Well drivers cppc_cpufreq is certainly possible with PCC.
I don't have a platform where this would likely be an issue, but MPAR limits
is an obvious one. For resume specifically, interestingly enough, MPAR limits
uses ktime_get() instead of _boottime, so it might not be entirely unreasonable
that we would hit this.
That being said cppc_cpufreq implements .get() making the above moot for resume.
Nonetheless the old update_limits path retained the update_limits flag on the write
failure and now we drop force_target?
> [snip]
next prev parent reply other threads:[~2026-11-04 15:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 19:42 [PATCH v2 0/3] cpufreq: Fix synchronization with system suspend/resume Rafael J. Wysocki
2026-11-03 19:45 ` [PATCH v2 1/3] cpufreq: Improve suspend-resume synchronization Rafael J. Wysocki
2026-11-18 13:03 ` [REGRESSION: " Borah, Chaitanya Kumar
2026-11-03 19:47 ` [PATCH v2 2/3] cpufreq: Force passing target frequency to driver during resume Rafael J. Wysocki
2026-11-04 11:56 ` Christian Loehle
2026-11-04 13:44 ` Rafael J. Wysocki (Intel)
2026-11-04 15:09 ` Christian Loehle [this message]
2026-11-04 15:46 ` Rafael J. Wysocki (Intel)
2026-11-03 19:49 ` [PATCH v2 3/3] cpufreq: intel_pstate: Clear last written P-state value on suspend Rafael J. Wysocki
2026-11-03 20:06 ` [PATCH v2 0/3] cpufreq: Fix synchronization with system suspend/resume Mario Limonciello
2026-11-03 23:26 ` Zak Brighton Knight
2026-11-04 2:44 ` Zhongqiu Han
2026-11-04 4:19 ` Viresh Kumar
2026-11-04 4:38 ` Doug Smythies
2026-11-04 12:18 ` Christian Loehle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=defdec33-3006-4ecd-a5d9-c323af70047c@arm.com \
--to=christian.loehle@arm.com \
--cc=dsmythies@telus.net \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=superm1@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=zakbrightonknight@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox