Linux Power Management development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>,
	jishnu.prakash@oss.qualcomm.com
Cc: Rakesh Kota <rakesh.kota@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sebastian Reichel <sre@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: soc: qcom: pmic-glink: Document batteryless property
Date: Fri, 22 May 2026 12:32:56 +0200	[thread overview]
Message-ID: <df22ebcb-52d6-4a6f-852a-6d6ed376e313@kernel.org> (raw)
In-Reply-To: <82019c2e-6b6e-4edd-91b3-a28ef6eb09eb@oss.qualcomm.com>

On 22/05/2026 11:24, Konrad Dybcio wrote:
> On 5/21/26 11:58 AM, Krzysztof Kozlowski wrote:
>> On 21/05/2026 10:46, Konrad Dybcio wrote:
>>> On 5/21/26 9:20 AM, Krzysztof Kozlowski wrote:
>>>>> Since firmware does not have a way to dynamically tell if it on a
>>>>> debug-board powered device or a DCIN powered device, We are required to
>>>>> add this new DT property.
>>>>
>>>> Neither debug-board powered device nor battery-less will have
>>>> monitored-battery, thus again, why lack of that property cannot tell you
>>>> what you need?
>>>
>>> A device with a battery will not have a monitored-battery either
>> But why? If for such device property "no battery" is suitable, then for
>> me "monitored-battery" is suitable as well. IOW, if you say that having
>> a property describing batter is not a accurate hardware property here,
>> then neither saying "no battery" is, because no batter is basically some
>> sort of battery (just like empty set is still a set, empty array is
>> still an array).
> 
> The battmgr service running on one of the remoteprocs already has all
> the information about the battery and it also handles all the type-c,
> PD and charger configuration, only letting the OS know about the
> results.
> 
> Hence, unless there's some other hardware at play (e.g. for custom
> 200 W charging), which wasn't fully implemented in the QC firmware,
> there is no reason to describe a battery separately, since the OS
> can't do anything useful with that information

That's a good explanation and it implies: "no-battery" is not suitable.

> 
> In some abstract way, perhaps monitored_battery = <&pmic_glink> could
> be thought of as valid (since that's the data source the OS gets to
> see)
> 
Best regards,
Krzysztof

  reply	other threads:[~2026-05-22 10:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-18 13:49 [PATCH 0/2] qcom_battmgr: Add batteryless DC-adapter MAINS support Rakesh Kota
2026-05-18 13:49 ` [PATCH 1/2] dt-bindings: soc: qcom: pmic-glink: Document batteryless property Rakesh Kota
2026-05-18 15:27   ` Krzysztof Kozlowski
2026-05-19  8:25     ` Rakesh Kota
2026-05-19 10:35       ` Krzysztof Kozlowski
2026-05-19 10:47         ` Konrad Dybcio
2026-05-19 10:49           ` Krzysztof Kozlowski
2026-05-21  7:13         ` Kamal Wadhwa
2026-05-21  7:20           ` Krzysztof Kozlowski
2026-05-21  8:46             ` Konrad Dybcio
2026-05-21  9:58               ` Krzysztof Kozlowski
2026-05-22  9:24                 ` Konrad Dybcio
2026-05-22 10:32                   ` Krzysztof Kozlowski [this message]
2026-05-22 10:34                     ` Konrad Dybcio
2026-05-21 12:38               ` Rakesh Kota
2026-05-21 23:34           ` Dmitry Baryshkov
2026-05-18 13:49 ` [PATCH 2/2] power: supply: qcom_battmgr: Add support batteryless boards as MAINS Rakesh Kota
2026-05-18 14:36 ` [PATCH 0/2] qcom_battmgr: Add batteryless DC-adapter MAINS support Konrad Dybcio
2026-05-19  6:59   ` Rakesh Kota
2026-05-19 10:58     ` Konrad Dybcio
2026-05-21 12:28       ` Rakesh Kota
2026-05-21 22:56     ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df22ebcb-52d6-4a6f-852a-6d6ed376e313@kernel.org \
    --to=krzk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jishnu.prakash@oss.qualcomm.com \
    --cc=kamal.wadhwa@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rakesh.kota@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox