From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18150C433EF for ; Tue, 5 Jul 2022 17:21:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231181AbiGERVH (ORCPT ); Tue, 5 Jul 2022 13:21:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229591AbiGERVG (ORCPT ); Tue, 5 Jul 2022 13:21:06 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5F571F61A for ; Tue, 5 Jul 2022 10:21:04 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id bu42so1860819lfb.0 for ; Tue, 05 Jul 2022 10:21:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=LBrUJU1OxaLc3a1NUAUniiflOroxzr7h0e1+YimfCmc=; b=yHU8071L/Dc1Dd5xMXJPKAl6QgqMp9H8ecbHxLqyBFhLDAAXAizmd6gA0Sz415y2Wz r17h2IFKHZQliQu6WCCCDlIxyQH+aSqafDedO1eHPUA7skiA3dlUfRdWWTwMw5e5cAs4 nmS5UAbt75r289sZj8S4BLqVW8vXCwF2ah4oMHiBmDanJfg+/XT0S0ppNBYrhoE3lhfE uAf8hyHXPDTo7+kd0ePEJmvN+4P5pzaam6VArfO93mK1FShxWW+CvmmW6sJQsONGDEbK vt0f8HFTwtp59Ik4A3gCaVUjLOuWjLFYm+caTVgX4a7Up9AWtJd+slBOCWDYXJGLeUUy ZfXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=LBrUJU1OxaLc3a1NUAUniiflOroxzr7h0e1+YimfCmc=; b=LJkQp0r1ePGj8e8K105lXgwQ4PV1kQxtLwCpj2I8e7B3Agbp1/HYL+9QEI30Vnnbp6 KBTegdmFCzFIzlG+gqSocWsbrX5Lo1pHAO+FBAwYwAF3XjzW2W4Dg9eDbkAiDD1jFOFv HG8WiFzPtwediAYMpz95d5dfGt/Wdurq5ihlVNOB8FgTYEAtEBrC4EJj9V7ckb+20nHh AC3rNUHfcseLn22yILj2WVtuhdWueUxmSjNjinHPKSSh7xGI2BXfBOHqjuZxjvRfoAVr /S/2Smv5941DzLkP0I5tMfGxrVtUX9C9r+qLacPF02zVm6yBrbcfNAFTCLG58egQKtRT JsIQ== X-Gm-Message-State: AJIora+6TMLdYrLKKH2DMhTZ60ZDHPIkHAoJX1Zy9TO8XTgRdLffhynN 9VDBMypQ2Bwibg7yDqw2deIlCdaEfWUQDQ== X-Google-Smtp-Source: AGRyM1srO23IxMNPr3M+wSImTNYHEpYUX54PkoZGBWDlguJDCbU2Eod7/q8lRXytKxURFIU+HfTmkA== X-Received: by 2002:a05:6512:3d11:b0:47f:8fe3:8e98 with SMTP id d17-20020a0565123d1100b0047f8fe38e98mr22634217lfv.53.1657041663194; Tue, 05 Jul 2022 10:21:03 -0700 (PDT) Received: from [192.168.1.52] ([84.20.121.239]) by smtp.gmail.com with ESMTPSA id f9-20020a05651c03c900b0025a79b7fb7dsm5683463ljp.93.2022.07.05.10.21.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jul 2022 10:21:02 -0700 (PDT) Message-ID: Date: Tue, 5 Jul 2022 19:21:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V2 09/13] OPP: Assert clk_count == 1 for single clk helpers Content-Language: en-US To: Viresh Kumar , Viresh Kumar , Nishanth Menon , Stephen Boyd Cc: linux-pm@vger.kernel.org, Vincent Guittot , "Rafael J. Wysocki" , Dmitry Osipenko , linux-kernel@vger.kernel.org References: From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 05/07/2022 09:00, Viresh Kumar wrote: > Many helpers can be safely called only for devices that have a single > clk associated with them. Assert the same for those routines. > Where is the safety problem with multiple-clocks case? And how users of PM OPP API are supposed to iterate/find OPPs they want if the API now throws WARN? Best regards, Krzysztof