From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2115CC4332F for ; Sun, 12 Nov 2023 11:52:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231351AbjKLLwU (ORCPT ); Sun, 12 Nov 2023 06:52:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231364AbjKLLwT (ORCPT ); Sun, 12 Nov 2023 06:52:19 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63C5C2702; Sun, 12 Nov 2023 03:52:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699789936; x=1731325936; h=message-id:subject:from:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=c6ExBF+wBoWPFPJvEml6ZUBLXMjGD5qgTHfmERRwIHY=; b=FQAth22M6foNOthx24LdbApc5jFEvT+AJZL59lZL3VaRHwL9szF0w/p+ h91LzBJEYZ04PPJ/gz3LRuAzhxAXZfJem2MPVhjZX4o7hnAA1kgN/iZ04 /FE7esCfccvTgMf10tMufNXft59ZiYLlQSeSH+qkia733WKSF3r4m3NKX p7P9YKNe0Ubw54P2iHOrM6/XitzZ9FJRu1LQufklWoKRlusA4qGoIffHv gGQ9USpfTbCl8j/a1WnYmgGJUNqP2eceIJ9eQsGPC6KNBYeuMMCiaEU3S X8C8yotfTwYQKPKQVG2IGaiJ5cbYnlusCcLH2GeLGmcrGHnlvFi+GMtlH g==; X-IronPort-AV: E=McAfee;i="6600,9927,10891"; a="454624780" X-IronPort-AV: E=Sophos;i="6.03,297,1694761200"; d="scan'208";a="454624780" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2023 03:52:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10891"; a="834496288" X-IronPort-AV: E=Sophos;i="6.03,297,1694761200"; d="scan'208";a="834496288" Received: from linux.intel.com ([10.54.29.200]) by fmsmga004.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2023 03:52:15 -0800 Received: from abityuts-desk1.ger.corp.intel.com (abityuts-desk1.fi.intel.com [10.237.68.150]) by linux.intel.com (Postfix) with ESMTP id 77869580DAB; Sun, 12 Nov 2023 03:52:13 -0800 (PST) Message-ID: Subject: Re: [PATCH] intel_idle: add CPUIDLE_FLAG_IRQ_ENABLE to SPR C1 and C1E From: Artem Bityutskiy To: Jon Kohler Cc: Jacob Pan , Len Brown , "Rafael J. Wysocki" , "linux-pm@vger.kernel.org" , LKML Date: Sun, 12 Nov 2023 13:52:12 +0200 In-Reply-To: <22D82855-259A-425A-B401-2F51EEC3C746@nutanix.com> References: <20220630194309.40465-1-jon@nutanix.com> <20B0D65B-CB72-4F56-BF8F-7B212D04A7EA@nutanix.com> <22D82855-259A-425A-B401-2F51EEC3C746@nutanix.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Fri, 2023-11-10 at 20:00 +0000, Jon Kohler wrote: > CPUIDLE_FLAG_IRQ_ENABLE Hi, yes, I did run several experiments, and found that this change would ma= ke some micro benchmarks give worse score. I did a lot of repetitions assuming= I was mixing noise with signal, but every time confirmed that enabling interr= upts in C1 made the score worse (like 1%). I do not have explanation for this phenomena, but decided to not pursue thi= s idea. Artem.=20