From: "Pan, Harry" <harry.pan@intel.com>
To: "pavel@ucw.cz" <pavel@ucw.cz>
Cc: "Brown, Len" <len.brown@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"gs0622@gmail.com" <gs0622@gmail.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>
Subject: Re: [PATCH] PM / suspend: measure the time of filesystem syncing
Date: Tue, 12 Feb 2019 00:40:38 +0000 [thread overview]
Message-ID: <e09b1e8f534686fe199a887e311136281fa1ce30.camel@intel.com> (raw)
In-Reply-To: <20190206161612.GA7868@amd>
>
> I'd rather educate other developers that this may happen. dmesg
> timestamps should already make it easy to see.
>
> And actually... if you do "time sync" in userspace just before
> programing the RTC and suspending, this whole issue should go away.
>
>
I agree w/ you on both comments basically.
Thad said, when it comes to dmesg, readers would guess by current
implementation of the program, the two lines of pr_info and pm_pr_dbg
are controlled by compilation flags as well as printk run-level, I
think the information is enough while it is not guaranteed for this
subject.
Another reason is, months ago I worked on my community to illustrate
this odd, adding 'sync' policy in the userspace script [1] mitigated
the longer sync (issued by kernel) in suspending, however I realized
there is still rare case because the userspace sync is before the
processes freeze, the script is potentially competing w/ other high
loading tasks which means there is still a small window (sync ->
program alarm -> suspend until freeze) that could generate such odd.
Short recap this topic is trying to give a clear indication as simple
mechanism for the platform and OS developers who may concern the
suspending time w/ some sort of time constrain; given a clear metric it
allows developers to have an easier triage such hard-to-reproduce issue
shall go to virtual memory/filesystem rather than examine whether there
is longer cost on each PM sub-state along w/ the device callbacks
through a long suspending log.
Lastly, I understand this data might not so interesting to kernel
developers; somehow my role is sitting in between trying to bridge
kernel and OS developers, I fully respect reviewers' comments and
justification.
Sincerely,
Harry
[1]
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/458560/14/power_manager/tools/suspend_stress_test#202
(Apologize long URL and context as reference)
next prev parent reply other threads:[~2019-02-12 0:40 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-03 5:20 [PATCH] PM / suspend: measure the time of filesystem syncing Harry Pan
2019-02-05 11:55 ` Rafael J. Wysocki
2019-02-06 14:52 ` Pan, Harry
2019-02-05 21:23 ` Pavel Machek
2019-02-06 15:08 ` Pan, Harry
2019-02-06 15:31 ` Pan, Harry
2019-02-06 16:16 ` Pavel Machek
2019-02-12 0:40 ` Pan, Harry [this message]
2019-02-06 14:42 ` Harry Pan
2019-02-06 14:53 ` Pavel Machek
2019-02-12 23:21 ` Rafael J. Wysocki
2019-02-12 23:26 ` Rafael J. Wysocki
2019-02-12 23:35 ` Rafael J. Wysocki
2019-02-06 15:42 ` [PATCH v2] " Harry Pan
2019-02-14 7:16 ` [PATCH v3] " Harry Pan
2019-02-14 11:15 ` Harry Pan
2019-02-19 10:24 ` Rafael J. Wysocki
2019-02-20 16:44 ` Pan, Harry
2019-02-20 21:45 ` Rafael J. Wysocki
2019-02-22 15:56 ` Pan, Harry
2019-02-20 16:12 ` [PATCH v4] " Harry Pan
2019-02-20 16:18 ` Harry Pan
2019-02-22 14:54 ` [PATCH v5] PM / sleep: " Harry Pan
2019-02-24 19:37 ` kbuild test robot
2019-02-24 23:23 ` kbuild test robot
2019-02-22 15:49 ` Harry Pan
2019-02-22 17:54 ` Pavel Machek
2019-02-24 6:17 ` [PATCH v6 1/2] PM / sleep: refactor the filesystems sync to reduce duplication Harry Pan
2019-02-24 6:17 ` [PATCH v6 2/2] PM / sleep: measure the time of filesystems syncing Harry Pan
2019-02-24 20:30 ` kbuild test robot
2019-02-24 21:51 ` kbuild test robot
2019-02-25 9:44 ` [PATCH v7 1/2] PM / sleep: refactor the filesystems sync to reduce duplication Harry Pan
2019-02-25 9:44 ` [PATCH v7 2/2] PM / sleep: measure the time of filesystems syncing Harry Pan
2019-02-25 12:36 ` [PATCH v7 1/2] PM / sleep: refactor the filesystems sync to reduce duplication Harry Pan
2019-02-25 12:36 ` [PATCH v7 2/2] PM / sleep: measure the time of filesystems syncing Harry Pan
2019-03-22 8:21 ` [PATCH v7 1/2] PM / sleep: refactor the filesystems sync to reduce duplication Pavel Machek
2019-02-25 7:33 ` [PATCH v5] PM / sleep: measure the time of filesystem syncing kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e09b1e8f534686fe199a887e311136281fa1ce30.camel@intel.com \
--to=harry.pan@intel.com \
--cc=gs0622@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).