From: Christian Loehle <christian.loehle@arm.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux PM mailing list <linux-pm@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Doug Smythies <dsmythies@telus.net>
Subject: Re: TEO as default governor ?
Date: Thu, 13 Mar 2025 06:15:18 +0000 [thread overview]
Message-ID: <e1ce9edb-db24-46cc-b33f-f0fbce938f9a@arm.com> (raw)
In-Reply-To: <9b4a15c4-4e0c-43f6-b2ec-e98bc02f67cc@linaro.org>
On 3/11/25 18:00, Daniel Lezcano wrote:
> On 11/03/2025 18:34, Rafael J. Wysocki wrote:
>> On Tue, Mar 11, 2025 at 5:47 PM Christian Loehle
>> <christian.loehle@arm.com> wrote:
>>>
>>> On 3/11/25 16:31, Daniel Lezcano wrote:
>>>>
>>>> Hi,
>>>>
>>>> I think we can agree the teo governor is better then the menu governor.
>>>>
>>>> Would it make sense to make the teo governor the default governor ?
>>>>
>>>>
>>>
>>> Rafael's position seems to be quite conservative here.
>>> Fact is menu is still the default on many systems.
>>> Even worse, the really bad performance disadvantage when
>>> using menu in an intercept-heavy workload has been fixed by Rafael :)
>>> https://lore.kernel.org/lkml/bc7f915b-8d9f-4e05-9939-8b7ecc078f85@arm.com/
>>>
>>> FWIW I proposed this a while ago:
>>> https://lore.kernel.org/lkml/20240905092645.2885200-3-christian.loehle@arm.com/
>>
>> It will help if one can make a really convincing case for this change
>> (that is, show that menu with the most recent fixes included is really
>> significantly worse on their platform).
>
> For all the platforms I've been testing, the teo governor is always the best one.
>
> Using the menu governor has also an impact on the user experience as it lags on mobile.
>
> After studying the history of the menu governor few years ago, it appeared the menu governor was introduced before the SMP was widely used. The strength of the menu governor was the ability to find repeating intervals but with he multiplication of the cores, the IPIs were introduced which increased the entropy of the busy-idle cycles duration, thus making the duration much more random and altering the menu governor prediction accuracy.
Cross-posting Doug's reply here and +CC
https://lore.kernel.org/lkml/005801db9397$266ddac0$73499040$@telus.net/
Daniel if you're testing both and struggle to find a strong advantage
for teo:
teo currently has the intercept-mechanism, trying to find a shallower state
until we are at < 1/2 intercepts as wakeups.
Rafael's idea was to make this configurable, e.g. allowing only 20%
intercepts (more aggressive in selecting shallow states) or 80% (less
aggressive in selecting shallow states).
This would be a minimal change in code and the rest of teo is unaffected,
but gives users a choice, something menu won't offer.
prev parent reply other threads:[~2025-03-13 6:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 16:31 TEO as default governor ? Daniel Lezcano
2025-03-11 16:45 ` Ulf Hansson
2025-03-11 16:47 ` Christian Loehle
2025-03-11 17:34 ` Rafael J. Wysocki
2025-03-11 18:00 ` Daniel Lezcano
2025-03-11 18:26 ` Rafael J. Wysocki
2025-03-11 18:42 ` Daniel Lezcano
2025-03-11 18:51 ` Rafael J. Wysocki
2025-03-11 20:51 ` Christian Loehle
2025-03-13 6:15 ` Christian Loehle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1ce9edb-db24-46cc-b33f-f0fbce938f9a@arm.com \
--to=christian.loehle@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=dsmythies@telus.net \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox