Linux Power Management development
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: K Prateek Nayak <kprateek.nayak@amd.com>
Cc: Perry Yuan <perry.yuan@amd.com>,
	"open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
	<linux-kernel@vger.kernel.org>,
	"open list:CPU FREQUENCY SCALING FRAMEWORK"
	<linux-pm@vger.kernel.org>,
	Stuart Meckle <stuartmeckle@gmail.com>
Subject: Re: [PATCH] cpufreq/amd-pstate: Drop Kconfig option for dynamic EPP
Date: Thu, 14 May 2026 08:06:00 -0500	[thread overview]
Message-ID: <e1f2d095-68a1-4edf-9f10-b5fe84ca5de2@amd.com> (raw)
In-Reply-To: <3633a2df-73a8-46d0-a430-8f9502cfffd9@amd.com>



On 5/14/26 08:05, K Prateek Nayak wrote:
> Hello Mario,
> 
> On 5/13/2026 3:49 AM, Mario Limonciello wrote:
>> --- a/Documentation/admin-guide/pm/amd-pstate.rst
>> +++ b/Documentation/admin-guide/pm/amd-pstate.rst
>> @@ -358,8 +358,8 @@ Dynamic energy performance profile
>>   The amd-pstate driver supports dynamically selecting the energy performance
>>   profile based on whether the machine is running on AC or DC power.
>>   
>> -Whether this behavior is enabled by default depends on the kernel
>> -config option `CONFIG_X86_AMD_PSTATE_DYNAMIC_EPP`. This behavior can also be overridden
>> +Whether this behavior is enabled by default depends on the kernel command line option
>> +``amd_dynamic_epp`` is set. This behavior can also be overridden
>>   at runtime by the sysfs file ``/sys/devices/system/cpu/cpufreq/policyX/dynamic_epp``.
> 
> Unrelated nit.
> 
> This file should have been
> /sys/devices/system/cpu/amd_pstate/dynamic_epp right?
> 

Correct; thanks.  I'll roll that in.

> Apart from that, feel free to add:
> 
> Reviewed-by: K Prateek Nayak <kprateek.nayak@amd.com>

Appreciated.

> 
>>   
>>   When set to enabled, the driver will select a different energy performance


      reply	other threads:[~2026-05-14 13:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 22:19 [PATCH] cpufreq/amd-pstate: Drop Kconfig option for dynamic EPP Mario Limonciello
2026-05-14 13:05 ` K Prateek Nayak
2026-05-14 13:06   ` Mario Limonciello [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1f2d095-68a1-4edf-9f10-b5fe84ca5de2@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=perry.yuan@amd.com \
    --cc=stuartmeckle@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox