Re: [PATCH v5 1/2] thermal/qcom/lmh: support SDM670 and its CPU clusters

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 3/31/26 7:44 PM, Richard Acayan wrote:
> On Tue, Mar 31, 2026 at 10:30:29AM +0200, Konrad Dybcio wrote:
>> On 3/30/26 6:52 PM, Richard Acayan wrote:
>>> The LMh driver was made for Qualcomm SoCs with clusters of 4 CPUs, but
>>> some SoCs divide the CPUs into different sizes of clusters. In SDM670,
>>> the first 6 CPUs are in the little cluster and the next 2 are in the big
>>> cluster. Define the clusters in the match data and define the different
>>> cluster configuration for SDM670.
>>>
>>> Currently, this tolerates linking to any CPU in a given cluster.
>>>
>>> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
>>> ---
>>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>
>> [...]
>>> +	if (cpu_id < 0) {
>>> +		dev_err(dev, "Wrong CPU id associated with LMh node\n");
>>> +		return -EINVAL;
>>> +	}
>>
>> nit: try to use 'return dev_err_probe(dev, ret, "....") in the future
> 
> Does "in the future" apply to the inevitable next revision? This would
> be the first occurrence of dev_err_probe in this driver and the error
> path was just cut-and-paste.

Not necessarily, 'in the future' meaning 'in your future patches'

Konrad