From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3846C636D7 for ; Tue, 21 Feb 2023 20:08:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230141AbjBUUIy (ORCPT ); Tue, 21 Feb 2023 15:08:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230097AbjBUUIv (ORCPT ); Tue, 21 Feb 2023 15:08:51 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73CB527D42 for ; Tue, 21 Feb 2023 12:08:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677010080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=09M2IhNewYa0ZD87pwGV1iriHd9wzWyMm+sZhc4KVgY=; b=Y1O+nTD+J5/f4N2FeqHHhJoj/Tap/X5JxA1+eE1m029EJ+sixmPVZjESG12LRX/Xe3uXVM nDrWc1/Fg7SxMp3SVkO+EPROToYlf7vp10dDGl8joFR+ODDVrup/Pik47E++bXGXvlzJrB ZLFVen+YxRhy2oaIQrDiKrQIP2NnyaY= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-261-oOFAGnRlMZet1OoyOw7yRg-1; Tue, 21 Feb 2023 15:07:59 -0500 X-MC-Unique: oOFAGnRlMZet1OoyOw7yRg-1 Received: by mail-ed1-f71.google.com with SMTP id b1-20020aa7dc01000000b004ad062fee5eso7406290edu.17 for ; Tue, 21 Feb 2023 12:07:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=09M2IhNewYa0ZD87pwGV1iriHd9wzWyMm+sZhc4KVgY=; b=6VxaEsz3jvdOxAk98Azspoz0HfqIX+aR3LbBH1fFlRVbg53QJDnMyAkbeaZNkB8MtT aTqPS7X/peXIXpKmRcaCjssjxxMARdBN9vNs26wCosdDTBmJiT1KkaHw2IDKXBUr6raX WAjILrUygfl2PlfIpmEBiQSdy0Y/uzJ/YRgo85zP7wCTUWKicgckrTmHtuzdd9EyVY30 dU5MISo5du7vl7jIZdQLXnHzvJxuDKWoi5WCjhVBPjbccFhBDARPUirhXa7FxffdzRdZ ON5Y6IR4xSc6hz/Rz/bCJYuZwgHOvcYHl83DqDPKlIxJVxaxIE0aQNDJ96C4FZaDGFtP l2lQ== X-Gm-Message-State: AO0yUKUNL3pP4KKTh/FCYAOa2dhjBAqyHoxP+4+5FUZP+wAGSNCRgUzi snEBpCMErzVROBx0WWq3O0Feuo/KArOW/SMfgEyP7tV+6eOW/ArW6WHLM+MgLeAUUKoYp0d62HN fWpfpgExq4TuoKVh1yUQzHBGA X-Received: by 2002:a50:ee1a:0:b0:4ad:7c6c:5386 with SMTP id g26-20020a50ee1a000000b004ad7c6c5386mr4666714eds.30.1677010077401; Tue, 21 Feb 2023 12:07:57 -0800 (PST) X-Google-Smtp-Source: AK7set8BGn8xDOhDuov3MkZqm4u3X6uxPdXm6C3Wov/p2iyeV432KODzpfLNtWuyc+AJ4tr0hCdZqg== X-Received: by 2002:a50:ee1a:0:b0:4ad:7c6c:5386 with SMTP id g26-20020a50ee1a000000b004ad7c6c5386mr4666702eds.30.1677010077206; Tue, 21 Feb 2023 12:07:57 -0800 (PST) Received: from ?IPV6:2001:1c00:2a07:3a01:67e5:daf9:cec0:df6? (2001-1c00-2a07-3a01-67e5-daf9-cec0-0df6.cable.dynamic.v6.ziggo.nl. [2001:1c00:2a07:3a01:67e5:daf9:cec0:df6]) by smtp.gmail.com with ESMTPSA id e17-20020a50a691000000b004accf3a63cbsm1751767edc.68.2023.02.21.12.07.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Feb 2023 12:07:56 -0800 (PST) Message-ID: Date: Tue, 21 Feb 2023 21:07:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 15/16] thermal/drivers/acerhdf: Remove pointless governor test Content-Language: en-US To: Daniel Lezcano , rafael@kernel.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Kaestle , Mark Gross , "open list:ACER ASPIRE ONE TEMPERATURE AND FAN DRIVER" References: <20230221180710.2781027-1-daniel.lezcano@linaro.org> <20230221180710.2781027-16-daniel.lezcano@linaro.org> From: Hans de Goede In-Reply-To: <20230221180710.2781027-16-daniel.lezcano@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi, On 2/21/23 19:07, Daniel Lezcano wrote: > The thermal zone parameter specifies the bang-bang governor. > > The Kconfig selects the bang-bang governor. So it is pointless to test > if the governor was set for the thermal zone assuming it may not have > been compiled-in. > > Remove the test and prevent another access into the thermal internals. > > Signed-off-by: Daniel Lezcano > Acked-by: Peter Kaestle Thanks, looks good to me, here is my ack for merging this through the thermal tree. Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/platform/x86/acerhdf.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c > index 61f1c3090867..71b9c1f922d9 100644 > --- a/drivers/platform/x86/acerhdf.c > +++ b/drivers/platform/x86/acerhdf.c > @@ -697,13 +697,6 @@ static int __init acerhdf_register_thermal(void) > if (ret) > return ret; > > - if (strcmp(thz_dev->governor->name, > - acerhdf_zone_params.governor_name)) { > - pr_err("Didn't get thermal governor %s, perhaps not compiled into thermal subsystem.\n", > - acerhdf_zone_params.governor_name); > - return -EINVAL; > - } > - > return 0; > } >