* [PATCH -next v2] interconnect: qcom: icc-rpm: Remove redundant dev_err call
@ 2022-09-24 1:50 Shang XiaoJing
2022-09-24 8:14 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Shang XiaoJing @ 2022-09-24 1:50 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, djakov, linux-arm-msm, linux-pm
Cc: krzysztof.kozlowski, shangxiaojing
devm_ioremap_resource() prints error message in itself. Remove the
dev_err call to avoid redundant error message.
Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
---
changes in v2:
- delete the empty line
---
drivers/interconnect/qcom/icc-rpm.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c
index 39e43b957599..ba6781f54ab7 100644
--- a/drivers/interconnect/qcom/icc-rpm.c
+++ b/drivers/interconnect/qcom/icc-rpm.c
@@ -477,11 +477,8 @@ int qnoc_probe(struct platform_device *pdev)
}
mmio = devm_ioremap_resource(dev, res);
-
- if (IS_ERR(mmio)) {
- dev_err(dev, "Cannot ioremap interconnect bus resource\n");
+ if (IS_ERR(mmio))
return PTR_ERR(mmio);
- }
qp->regmap = devm_regmap_init_mmio(dev, mmio, desc->regmap_cfg);
if (IS_ERR(qp->regmap)) {
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next v2] interconnect: qcom: icc-rpm: Remove redundant dev_err call
2022-09-24 1:50 [PATCH -next v2] interconnect: qcom: icc-rpm: Remove redundant dev_err call Shang XiaoJing
@ 2022-09-24 8:14 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-24 8:14 UTC (permalink / raw)
To: Shang XiaoJing, agross, andersson, konrad.dybcio, djakov,
linux-arm-msm, linux-pm
On 24/09/2022 03:50, Shang XiaoJing wrote:
> devm_ioremap_resource() prints error message in itself. Remove the
> dev_err call to avoid redundant error message.
>
> Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-24 8:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-24 1:50 [PATCH -next v2] interconnect: qcom: icc-rpm: Remove redundant dev_err call Shang XiaoJing
2022-09-24 8:14 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).