From: Angus Ainslie <angus@akkea.ca>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: angus.ainslie@puri.sm, Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/4] power: bq25890_charger.c: Add debugging output of failed initialization
Date: Tue, 31 Jul 2018 12:16:19 -0600 [thread overview]
Message-ID: <e37abf500ce853afb24a8568b47c6679@www.akkea.ca> (raw)
In-Reply-To: <CAJKOXPeaNpdPbhJuc5FcPKdCq_FPr70_PCSuNMmZ5wJAhBXvmQ@mail.gmail.com>
On 2018-07-31 10:57, Krzysztof Kozlowski wrote:
> On 31 July 2018 at 18:43, Angus Ainslie (Purism) <angus@akkea.ca>
> wrote:
>> To ease adding a new part variant some debugging is handy.
>>
>> Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca>
>
> You missed my tag - I already reviewed it. Unless you change
> something, the tag should be added to commit msg:
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> Krzysztof
>
Hi Krzysztof,
Ooops, sorry about that.
Thanks for the review.
Angus
next prev parent reply other threads:[~2018-07-31 18:16 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 13:51 [PATCH] bq25890_charger.c : add the BQ25896 part Angus Ainslie
2018-07-25 9:58 ` Krzysztof Kozlowski
2018-07-25 12:17 ` Angus Ainslie
2018-07-26 6:37 ` Krzysztof Kozlowski
2018-07-25 19:46 ` [PATCH v2 0/4] Add the BQ25896 charger IC Angus Ainslie (Purism)
2018-07-25 19:46 ` [PATCH v2 1/4] power: bq25890_charger.c: Add debugging output of failed initialization Angus Ainslie (Purism)
2018-07-26 6:44 ` Krzysztof Kozlowski
2018-07-25 19:46 ` [PATCH v2 2/4] power: bq25890_charger.c: Remove unused table Angus Ainslie (Purism)
2018-07-26 6:51 ` Krzysztof Kozlowski
2018-07-27 15:26 ` Angus Ainslie
2018-07-31 6:40 ` Krzysztof Kozlowski
2018-07-25 19:46 ` [PATCH v2 3/4] power: bq25890_charger.c: Add the BQ25896 part Angus Ainslie (Purism)
2018-07-26 6:56 ` Krzysztof Kozlowski
2018-07-25 19:46 ` [PATCH v2 4/4] power: bq25890_charger.c: Read back the current battery voltage Angus Ainslie (Purism)
2018-07-26 7:03 ` Krzysztof Kozlowski
2018-07-27 15:30 ` Angus Ainslie
2018-07-31 16:43 ` [PATCH v3 0/4] Add the BQ25896 charger IC Angus Ainslie (Purism)
2018-07-31 16:43 ` [PATCH v3 1/4] power: bq25890_charger.c: Add debugging output of failed initialization Angus Ainslie (Purism)
2018-07-31 16:57 ` Krzysztof Kozlowski
2018-07-31 18:16 ` Angus Ainslie [this message]
2018-07-31 16:43 ` [PATCH v3 2/4] power: bq25890_charger.c: Remove unused table entries Angus Ainslie (Purism)
2018-07-31 16:58 ` Krzysztof Kozlowski
2018-07-31 16:43 ` [PATCH v3 3/4] power: bq25890_charger.c: Add the BQ25896 part Angus Ainslie (Purism)
2018-07-31 17:00 ` Krzysztof Kozlowski
2018-07-31 16:43 ` [PATCH v3 4/4] power: bq25890_charger.c: Read back the current battery voltage Angus Ainslie (Purism)
2018-07-31 17:02 ` Krzysztof Kozlowski
2018-07-31 17:49 ` [PATCH v4 0/4] Add the BQ25896 charger IC Angus Ainslie (Purism)
2018-07-31 17:49 ` [PATCH v4 1/4] power: bq25890_charger.c: Add debugging output of failed initialization Angus Ainslie (Purism)
2018-07-31 17:49 ` [PATCH v4 2/4] power: bq25890_charger.c: Remove unused table entries Angus Ainslie (Purism)
2018-07-31 17:49 ` [PATCH v4 3/4] power: bq25890_charger.c: Add the BQ25896 part Angus Ainslie (Purism)
2018-07-31 17:49 ` [PATCH v4 4/4] power: bq25890_charger.c: Read back the current battery voltage Angus Ainslie (Purism)
2018-08-30 21:46 ` [PATCH v4 0/4] Add the BQ25896 charger IC Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e37abf500ce853afb24a8568b47c6679@www.akkea.ca \
--to=angus@akkea.ca \
--cc=angus.ainslie@puri.sm \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).