From: Krzysztof Kozlowski <krzk@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/5] dt-bindings: thermal: Document Airoha AN7583 support
Date: Wed, 28 May 2025 09:28:12 +0200 [thread overview]
Message-ID: <e3c75b90-e76e-4ecf-b9cb-2abcc018269f@kernel.org> (raw)
In-Reply-To: <20250527215241.25767-5-ansuelsmth@gmail.com>
On 27/05/2025 23:52, Christian Marangi wrote:
> Document support for Airoha AN7583 thermal driver.
>
> Airoha AN7583 follow the same logic of Airoha EN7581 to read the
> temperature but lack all the support for the PTP_THERMAL used to monitor
> and react when trip point are triggered.
>
> Also the Airoha AN7583 lives entirely under the Chip SCU SoC register
> space hence a dedicated schema is introduced.
That's wrong argumentation. If this is part of SCU, it does not mean you
need separate schema. Quite opposite. No resources here, so this should
be folded into parent node.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-28 7:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 21:52 [PATCH v2 0/5] thermal/drivers: airoha: Add support for AN7583 Christian Marangi
2025-05-27 21:52 ` [PATCH v2 1/5] thermal: airoha: Convert to regmap API Christian Marangi
2025-05-27 21:52 ` [PATCH v2 2/5] thermal/drivers: airoha: Generalize probe function Christian Marangi
2025-05-27 21:52 ` [PATCH v2 3/5] thermal/drivers: airoha: Generalize get_thermal_ADC and set_mux function Christian Marangi
2025-05-27 21:52 ` [PATCH v2 4/5] dt-bindings: thermal: Document Airoha AN7583 support Christian Marangi
2025-05-28 7:28 ` Krzysztof Kozlowski [this message]
2025-05-27 21:52 ` [PATCH v2 5/5] thermal/drivers: airoha: Add support for AN7583 Thermal Sensor Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3c75b90-e76e-4ecf-b9cb-2abcc018269f@kernel.org \
--to=krzk@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox