From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7D543E1231 for ; Fri, 11 Sep 2026 17:13:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789146813; cv=none; b=arGQLLgbLwe2E6tf187NUHUEJKWLPqtPCLO5jo2QcfXQSVIahpkwsrtQStcBeOUVDLBEFlK0ZJtapBAYhrLNJMZ/oBLTVTb5mVkYpfFdZRJFYrXnWjkW4dqi/TacJSeACgnO6fuBabraZL2+U1ssxMwaNH48lCNkR9wM7kGT8tc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789146813; c=relaxed/simple; bh=GIg8Ee17H8uLahuwZG6QIu9IwUSfphXuVEckTgzzbiI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lE8qw586c+D1uhzXBkZUODM/0Xy67wsf2/KlKTmfGJC8JxjkxI9xyGQIetbHk6xYOfqQ9B6XrPCCxXjy9a/piEVshgzjZZZ7MMAEVL7yrA3wYQpkR7EMfbz5ZnYNESFf1/4fMNDN6OZX2Vg7gKgsASO30dUUHwu8bGx7pGt/JTo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MbMJ043Q; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WsA2Dq90; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MbMJ043Q"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WsA2Dq90" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68BF8kK0170585 for ; Fri, 11 Sep 2026 17:13:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GIg8Ee17H8uLahuwZG6QIu9IwUSfphXuVEckTgzzbiI=; b=MbMJ043Qh3693KxM TC8kMQTkju8cjNkcgW0WulTHDisRDeS0zOWD/ntCNBIH//BMVQJLOwmHGnfrnVoQ we6dQdxk2dewXcF7hvbcGVMtcQyzu+7IrU7yfFFkhxWA0BLxT4RBARs93uNpWFfh psCq4Ciz7SXlC4Kr+yxAixZvt0u1AIbftjDKa5DNH2SU98Rg4Fie+fSyEIOIJZgb 3nxRV46XfAERrERiZVDNEDd0G8cygfq6HCYuON8opaV5PrqvXD4d+sykhXziHZBG WqdZ3HZvPs5sCRC5KNok3cCunb/JVu5nUgZpOTrxivUvVl9vyeWKEIWYdqtnIIae RJeFIw== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gmm1e8gp1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 11 Sep 2026 17:13:30 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-86a7bb1dd95so1463626b3a.0 for ; Fri, 11 Sep 2026 10:13:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789146809; x=1789751609; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=GIg8Ee17H8uLahuwZG6QIu9IwUSfphXuVEckTgzzbiI=; b=WsA2Dq90HLFrqu66j4Q2H6a9nD7NPsx+o4m/8mN5hvJF932Mh0pc4kw7wVoXFniFOt vS7s6OCUoeDtCg6/7KSUksEAu1dv9RBcs3uxL/UvPdhQDHs55lEM7Knczd6u5byiHH/V VSqF1SVZqhAsoytWU4IuBMwWcnzWAlcGpZAEjIa3QFKL9J9zkWPSd5svchIO3XVqG7Ad Eg0FWIs170vg8WNUqu+BOLPaF2w4PzDqBi8zyYny9OqZJY6bhwA9RMQAJd/KKZC4VIOg diHrn40i7XV7gib/bdayQI9IFyKjMquJ66HaEgtIqBTv7qzFz4cZa8+sbY9aEB1eoShh EhBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789146809; x=1789751609; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GIg8Ee17H8uLahuwZG6QIu9IwUSfphXuVEckTgzzbiI=; b=rBb02niAiEuyD7z+gE/lxYfPmP1IZflGapv44/elDisBbXLNQCyeWxZBHPOZcCevGm /5eDwqn44Gr+vRIImWSYcr5g92a1TAQb9TfI0F8yZTpyeI+Pb130qyJ8lzyR27rBcdb9 jQMsXm0nZqCJ0Db77+d+VrYI8gweMPnXBS4aYqKcRuSMHPLD8ZwGPEbzQqVLhMWr8xRc uIFE7oWo8JbWUW2nS2XB/I7uIDTOlmePIKLKo66OxXIM0Rq8MpSuaBYdQnC9yI91hOSj sYt1U58HLv6K/Y20+l0F81kQ+5C5a2bJP0iuKMDz8AhbzNZ5mkvnGc5B0jukjEmKvyIL 3SsQ== X-Forwarded-Encrypted: i=1; AKwUvBwRqog9LzaeU0Mk/lTRz20wE88Ht9GreDNTLJf2MaHkBfsJUxFIWbxTbTrEgVh5k72dPYRE7601sQ==@vger.kernel.org X-Gm-Message-State: AFuF++km2Rbx86Mk3FqBnjGDoBQFlVjpStvHI11Vjbguvt7BG39t7edr MYueCzC38f7jgD6rH/LFMdOnYFf8qsdAI7svro6VIxBidRuSyEtJeUpoIAdyllno2m2mMcPlUSB CyBx7ncPiXbhh06413NOb9mpdjMDREaZI6801BCU3KfJRgTo3qqJo4H18t9X5FA== X-Gm-Gg: AYBFou2k6P9VLwkfYuSnwDVURfDiqyORrllsHYHPUdKTicXJUus7qobWAMNKkb0R4rl tAjBAQe8fBXiOx5LbPaUvu800nd1UH08EMfIy6NEwZuuxrlAR6AA2ZB63yPPr5P04Wi4a6nCicd 1vE682BRxSB7tqRlgkqzMI7qWGds/zYNHDQMyNKUllLm75Cu2THWHd2TnJ4ydmOXfzUtyliCdjj 4juJnLqna1teccqeOSzsIUkRoPtSjRJZt5wL06dGqpfvPlMaZmfQYeIoZtxTsHWiwaK3jxQ9Hpj 0LcsoSPEEO7eih5Yz807RpjqrUmATyee9kBex/MO5R6KCQfPpZZMUVmfKItpPKdJqC9DOkPSAqS QUdX/KxczP6DCrqvZn+F0+1Bdpmlkkasg X-Received: by 2002:a05:6a00:1786:b0:84e:354:422b with SMTP id d2e1a72fcca58-86b6f55356fmr3892857b3a.2.1789146809343; Fri, 11 Sep 2026 10:13:29 -0700 (PDT) X-Received: by 2002:a05:6a00:1786:b0:84e:354:422b with SMTP id d2e1a72fcca58-86b6f55356fmr3892808b3a.2.1789146808816; Fri, 11 Sep 2026 10:13:28 -0700 (PDT) Received: from [192.168.0.6] ([49.204.105.169]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-86b291c1601sm1492832b3a.31.2026.09.11.10.13.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Sep 2026 10:13:28 -0700 (PDT) Message-ID: Date: Fri, 11 Sep 2026 22:43:20 +0530 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/9] soc: qcom: geni-se: Remove OPP rate reset from resource deactivation To: Konrad Dybcio , Sudeep Holla , Cristian Marussi , Ulf Hansson , Bjorn Andersson , Konrad Dybcio , Greg Kroah-Hartman , Jiri Slaby , Mark Brown , Viken Dadhaniya , Andi Shyti Cc: mukesh.savaliya@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, linux-i2c@vger.kernel.org References: <20260827-derive_clk_perf_tbl_from_perf_domain_opp_table-v2-0-091697dbeb02@oss.qualcomm.com> <20260827-derive_clk_perf_tbl_from_perf_domain_opp_table-v2-4-091697dbeb02@oss.qualcomm.com> <813aae42-22bf-4029-8f04-54fc555a2a1c@oss.qualcomm.com> Content-Language: en-US From: Praveen Talari In-Reply-To: <813aae42-22bf-4029-8f04-54fc555a2a1c@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTExMDI0MCBTYWx0ZWRfXxmp17xj6Ptk/ bqvfBb4hy0GFD8mi46Nt0eXK8dtQy8gCLKivgpb5RaNdP53R18ner8c8YLBFfnv7IvqeooAewBd J/1DZg12xY9aCL9fDnz6aett458z7etlVkWmNFr/ftMFxObTbbdJ7YFOgmP7mulX247LULWOjTA RrSVgiEZsh8u7MsF00webxBnmSaOrMm4lEbzxfEBMHhnBg1GU11jhhLxqHJpIDqZJJUV5p5qMtI 19BKzTN/ww4SDqVUASjzFLjqJuNMDrdbGw9ZmKx6GA4DYIV9qoggcZbFptgRFwIVruz8shAls6j ggaRhID3M9pwny9kRIC+/z+g0sHwo+dALNTeKyq119AuNPAC6PFPLd5j5E8yxVfziFTDNYp9pw6 a4Nd3rkVNe4wJL4SUC7HB5bqu/rGPrrhpOVyrVZK+6bvH7UJPrq9XM0olSphLv5alSk2w9eg7oj mOM+157TtB87tnX/w0w== X-Proofpoint-ORIG-GUID: B9u8Z6D9xIYUveo7JMEp59FukIybEKUE X-Proofpoint-GUID: B9u8Z6D9xIYUveo7JMEp59FukIybEKUE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTExMDI0MCBTYWx0ZWRfX5/B6zQNPtw7X mTwgw9av7B2nuNU00oX9yoxtw+6Iu2b6OHAAD4xPmW9Xzjd+X4wZXYC47qRXr0bs4VKnWnSE1+v /Me7h4yDQvG9F3Cct6LtSsuSnVqEnCc= X-Authority-Analysis: v=2.4 cv=LrwHWXdc c=1 sm=1 tr=0 ts=6aa436ba cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=KFINdI5Z0390/lZYonNNQw==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=Bcqig9hN0zFNc8VZEzUA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-11_05,2026-09-11_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 adultscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609110240 Hi Konrad, Thank you for review. On 04-09-2026 14:19, Konrad Dybcio wrote: > On 8/27/26 7:59 PM, Praveen Talari wrote: >> Remove the dev_pm_opp_set_rate(se->dev, 0) call from >> geni_se_resources_deactivate(). >> >> OPP resource management should be controlled by the consumer driver. > I believe the opposite was the original intent behind creating > these helpers.. Previously, resetting the OPP rate to 0 was applicable only to Linux-managed resource control. With this series, dev_pm_opp_set_rate() is used for both Linux-managed and firmware managed resource control. Therefore, the reset should no longer be performed unconditionally in geni_se_resources_deactivate(). Instead, the consumer driver can reset the rate when required, keeping the common resource deactivation path applicable to both configurations Thanks, Praveen Talari > >> Additionally, clocks are already disabled by geni_se_clks_off(), making >> the OPP rate reset unnecessary during resource deactivation. > That is, on the other hand, a valid reason > > Konrad