From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 112A4363C57 for ; Wed, 29 Apr 2026 14:40:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777473640; cv=none; b=GDrpbrjAXQ7oEgEaEljy0ke66z7UinhYet7/RhgpKWRVNXVyoTtWyRhGrXzYB+eZyQ1WrMVpPh/vS54sjmzyYRiuXg1mOCUSaanWv2aq9/nkP4z3SbE1JG4U/ohb4b72DxxL1ZwjDV/QqSXYCuBzGlsyLVj4tYmdv1yathCNoVo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777473640; c=relaxed/simple; bh=niI+3mQl4evkN4UDHgVij5jImVtE8gOR0Lbni2M5DOM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dY4uVwAqAWRfGHAwIOah2mi7ZNR8JemIHcAjKT5UZTTBqFOKgZNu2gB+iYxqXO0PebweShqoQ7NpCRGdkfcPJhGnH/EEMKxW7VC+u2susj6FeXvqgxRonm1o56b0eieMcdoGddPT3MSiEdUXmmCkzcfkPCqtCEbL5+AvQ/zLcFk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ef4lgzEQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UCOJrjCo; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ef4lgzEQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UCOJrjCo" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63T8pmCx901571 for ; Wed, 29 Apr 2026 14:40:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LTvtklw7T1tb7yJFotQqtbbrKTIyjQvnhgz95DrLbqg=; b=ef4lgzEQ0flJSMRZ KCnuAiih1mbTvqZvzGBYQboodTPMVkgCKfwmA5v0NlHDxRLUAe5/usrRvZ5DunCd Dtjq0bLjjK3NrCNYRkODrOqac+6ckiFHH6fmetbhcIKei5jHHb+guSZrHefwBrGg FoyPOBVEtGV92AmsE50FouavHUlLT8wCyRDvN4QBXV0ev0XkwZEoB2P50ez9bd9q 7h7a3sEek4My4c3w+FppcLU8QeCdwUdddAENA6g/bEViMqXg4Op+3Sg7d7SJgik3 L5inTOStIvMr3tGDYjL5P8c0QrSJPEcn26vs2X3sbdU4Ugl+yq7SJ6TS8ccR4a6y KsSeCA== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dubq9j5dk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 29 Apr 2026 14:40:37 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-35da99b90f6so14966136a91.1 for ; Wed, 29 Apr 2026 07:40:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777473637; x=1778078437; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LTvtklw7T1tb7yJFotQqtbbrKTIyjQvnhgz95DrLbqg=; b=UCOJrjCoQniY+ZspQrTPdxh1CP37X+0Vw6j/gDLdk8qtn9KDdemql1OErNxg5iBn0a Kn9nZpdYg5vqzsCTa3SBeBJhUNPR/EMXa1YgmV9KT4Ze9Tdn00wXCs1oAcmooouQnHL+ qkPPtvXX93qgTYllTbqHaUvZiMB1TfVmc8a8GS26gnLG4Jeifedjx63zEVt/06EQ2m0m gFntdgqQE1ZjQZyfKMMq6lISSd/3Gn+4maihhUfeOBdsnq3Aqnu90mNHEXdddLDhd5rJ FzqlMZrJveOirNDzOu359iO9qCt1c923C/nL2q7LgfUG8ERiKGJ4X4bqKfsrF8P5+ccE F2Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777473637; x=1778078437; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LTvtklw7T1tb7yJFotQqtbbrKTIyjQvnhgz95DrLbqg=; b=VwjjPaEQ+LPww/9rV7se58MBnCyTUljzrNhmncR8kxqJMZC0NiRwMmemxyzCuqVex9 0PxEpd/DrX7WegHTX1yipdnGFfKAEpRALqVXLjiGK4Z4opioQ7SmQH5D24if8b19tTly o9NDGBEZTPW3X9OkNHDAcA+vHqDj+LGya+rx4q3EojP322zYl3qwx3Q1+O9wLrlTVWA3 +tthDDwOy4vQnM5MD0JDpNbA1XDOjcotXbqZ24fRJJEKPdpA4JAJgfQ1KODQqxpfcwrI 6vTCrfaNiUXNFtP0A4YkklKtMtr7uLGQBO0Yf83p1h2o4UFl1wqN/onym2boUgm7lX5o maIw== X-Gm-Message-State: AOJu0YwVsBSvtmCrBXN6hQeS6FBcagOmrE8i3S7zyk6/qscFmsZDr9pn BFqowrSiTyrZQ2fZUPZN23qydVA1nzNcEAn/krebo+iUvNFXMauJF1t/PFxtNOg3l76lh/9dEkR RNbTEDmytbBwYzYDTEOXD+4AQJMIUJIGhCs9DRNVGBx0NFJqcopI760j4GEdF8g== X-Gm-Gg: AeBDietqzuQr9yazKYEU64egqQcxMyzn38r8V6t+lsbyg0ny4ny02+fjaeO7EFnFUCe LmJV1n2XdC4I5STO5vAr1jyDq7oUWgTsyjQcEar+8mQ/D+AbTVIeHp5u1y5OTKkhnwphq07oBsI +/kX8WVswzF/0ELPi9IcIM7eg/qrQ5PLdvd8QumxsUWOTyofB7ZlcZe8ErqecZYaLT6gFWTUEGy xfL6aSDdGUiwICi5RLTfXVIJAKwFfb2u3cY2bGgJTu8ef97pGifZ/f25WuYwEP5sAqC3nezKgqz mIRL+9FznHLKOwGDaKkPsVqM2loxY9fOg3Y+TGqXwTnkHG+ZtpRD2zTVARy6penYDx874cvQ77F GJEvq5xWBWokUqg9xmIsC2wVKU9mGOEpnuqkAgCprjmNm8wh7DRJiU9+DSNqe+bSRtfRmeQShqi DQ0rjd609s354oOfv4Lm3LeBr9vZmTxAbCvk8IdvjxMzIcl9conVw= X-Received: by 2002:a17:90b:5828:b0:35b:97ba:acee with SMTP id 98e67ed59e1d1-364a0d2ca8emr4196244a91.17.1777473636543; Wed, 29 Apr 2026 07:40:36 -0700 (PDT) X-Received: by 2002:a17:90b:5828:b0:35b:97ba:acee with SMTP id 98e67ed59e1d1-364a0d2ca8emr4196167a91.17.1777473635798; Wed, 29 Apr 2026 07:40:35 -0700 (PDT) Received: from [10.190.200.117] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-364a0303f52sm4214118a91.16.2026.04.29.07.40.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Apr 2026 07:40:35 -0700 (PDT) Message-ID: Date: Wed, 29 Apr 2026 20:10:24 +0530 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v21 05/13] mfd: psci-mfd: Add PSCI MFD driver for cpuidle-psci-domain cell To: Shivendra Pratap , Sebastian Reichel , Mark Rutland , Lorenzo Pieralisi , "Rafael J. Wysocki" , Daniel Lezcano , Christian Loehle , Ulf Hansson , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Arnd Bergmann , Souvik Chakravarty , Andy Yan , Matthias Brugger , John Stultz , Moritz Fischer , Bartosz Golaszewski , Sudeep Holla Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Florian Fainelli , Krzysztof Kozlowski , Dmitry Baryshkov , Mukesh Ojha , Andre Draszik , Greg Kroah-Hartman , Kathiravan Thirumoorthy , Srinivas Kandagatla References: <20260427-arm-psci-system_reset2-vendor-reboots-v21-0-dcf937775e73@oss.qualcomm.com> <20260427-arm-psci-system_reset2-vendor-reboots-v21-5-dcf937775e73@oss.qualcomm.com> Content-Language: en-US From: Pankaj Patil In-Reply-To: <20260427-arm-psci-system_reset2-vendor-reboots-v21-5-dcf937775e73@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: LrmUPjDLIW9Rqgj8VkluAaT_d5gtRGHl X-Proofpoint-ORIG-GUID: LrmUPjDLIW9Rqgj8VkluAaT_d5gtRGHl X-Authority-Analysis: v=2.4 cv=Wak8rUhX c=1 sm=1 tr=0 ts=69f21865 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=JfrnYn6hAAAA:8 a=U_Ea8TlPRqx-BgSQmf4A:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 a=1CNFftbPRP8L7MoqJWF3:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI5MDE0OCBTYWx0ZWRfXw4QDBN/sHdDk npFNhRK7sHVFPB+xzdXBWbPnnspauR3Rnq2snO9Qzqme4xipfJQV7BLk6eeD3ZQbsUez5LMifFt xBo34S7RQWhcKuRYWA60NNkLBDg/ak7nD9CsVZP3iKsUfHs4ez+pIHebBUaGKH01IyfIUPuJMv6 TRimojn6tKlPOUX1m6wR5HM5VCa/Xa27bK60gpbvxFRxaaixymhst0LX2Yq6OxgkFbXH/IKnJVT AiF8skwYV81Vq81blvwYxoHbmeHtmq3yhTRQaJfJlj+ygIEP4EH3twtsVZqRYaEE2mz5yPFIoC8 YxyHn7wZw19iMpCq4Qz4sd6Bxv5JDRBs6vtDbCXb4lcU8SD4ZuH1Y88GYv649eZl7Rgeslpa/JQ 6+sfi42LsMRT6rlm2VaSMRmfVFORS9SA1QG2DGdQHO3+sfbaehvjMCuAeCbwL469vD9xryvCLJQ 15U83lmgWbdQhd3MR6w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-28_05,2026-04-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 spamscore=0 clxscore=1015 bulkscore=0 impostorscore=0 adultscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604290148 On 4/27/2026 11:04 PM, Shivendra Pratap wrote: > PSCI has multiple kernel consumers, such as cpuidle-psci-domain. > Currently, both the PSCI core driver and cpuidle-psci-domain bind > directly to the same PSCI node "arm,psci-1.0". Additional consumers, if > introduced, would also need to bind in the same way, leading to several > drivers attached to a single device node. > > Introduce a PSCI MFD driver that binds to "arm,psci-1.0" and registers > PSCI child cells. As the first user, register cpuidle-psci-domain as a > child cell. > > Update cpuidle-psci-domain to probe as an MFD child and use the parent > PSCI node for power-domain traversal. > > Signed-off-by: Shivendra Pratap > --- > MAINTAINERS | 1 + > drivers/cpuidle/Kconfig.arm | 1 + > drivers/cpuidle/cpuidle-psci-domain.c | 9 +------- > drivers/mfd/Kconfig | 10 ++++++++ > drivers/mfd/Makefile | 2 ++ > drivers/mfd/psci-mfd.c | 43 +++++++++++++++++++++++++++++++++++ > 6 files changed, 58 insertions(+), 8 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index c871acf2179ce16c80b404027e6b969c7787a6bb..333b01fa00b8fbd15e6f31a6b9af47600411624e 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -21239,6 +21239,7 @@ L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > S: Maintained > F: Documentation/devicetree/bindings/arm/psci.yaml > F: drivers/firmware/psci/ > +F: drivers/mfd/psci-mfd.c > F: include/linux/psci.h > F: include/uapi/linux/psci.h > > diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm > index a1ee475d180dacab245510674514811aec337ad3..1a1316d11e0a2e4f61801586229f5104e2435865 100644 > --- a/drivers/cpuidle/Kconfig.arm > +++ b/drivers/cpuidle/Kconfig.arm > @@ -36,6 +36,7 @@ config ARM_PSCI_CPUIDLE_DOMAIN > bool "PSCI CPU idle Domain" > depends on ARM_PSCI_CPUIDLE > depends on PM_GENERIC_DOMAINS_OF > + depends on MFD_PSCI Should this be select MFD_PSCI? We're seeing bootup issues on Glymur when MFD_PSCI is not y > select DT_IDLE_GENPD > default y > help > diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c > index b9e4ad7d43a3310a76ce62018dff0af1488e33d2..a2d01810f2957abdfa52ae66503dc0cbb205f163 100644 > --- a/drivers/cpuidle/cpuidle-psci-domain.c > +++ b/drivers/cpuidle/cpuidle-psci-domain.c > @@ -17,7 +17,6 @@ > #include > #include > #include > -#include > > #include "cpuidle-psci.h" > #include "dt_idle_genpd.h" > @@ -122,14 +121,9 @@ static void psci_pd_remove(void) > } > } > > -static const struct of_device_id psci_of_match[] = { > - { .compatible = "arm,psci-1.0" }, > - {} > -}; > - > static int psci_cpuidle_domain_probe(struct platform_device *pdev) > { > - struct device_node *np = pdev->dev.of_node; > + struct device_node *np = pdev->dev.parent->of_node; > bool use_osi = psci_has_osi_support(); > int ret = 0, pd_count = 0; > > @@ -181,7 +175,6 @@ static struct platform_driver psci_cpuidle_domain_driver = { > .probe = psci_cpuidle_domain_probe, > .driver = { > .name = "psci-cpuidle-domain", > - .of_match_table = psci_of_match, > }, > }; > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 7192c9d1d268e93d1557ca6519ac96056e37e221..75ea5b47315cedfd1153899eef28614a165a14f5 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -2376,6 +2376,16 @@ config MFD_KHADAS_MCU > additional drivers must be enabled in order to use the functionality > of the device. > > +config MFD_PSCI > + bool "PSCI MFD for psci child cells" > + depends on ARM_PSCI_FW > + select MFD_CORE > + help > + PSCI MFD registers PSCI child cells and exposes them as > + platform devices. Child drivers are probed only if enabled in the > + kernel configuration. Select this option whenever a supported PSCI > + child driver is selected. > + > config MFD_ACER_A500_EC > tristate "Support for Acer Iconia Tab A500 Embedded Controller" > depends on I2C > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > index e75e8045c28afae975ac61d282b3b85af5440119..36e872b11b995135a04ca24c33fd3a4d08e4f49a 100644 > --- a/drivers/mfd/Makefile > +++ b/drivers/mfd/Makefile > @@ -24,6 +24,8 @@ obj-$(CONFIG_MFD_EXYNOS_LPASS) += exynos-lpass.o > obj-$(CONFIG_MFD_GATEWORKS_GSC) += gateworks-gsc.o > obj-$(CONFIG_MFD_MACSMC) += macsmc.o > > +obj-$(CONFIG_MFD_PSCI) += psci-mfd.o > + > obj-$(CONFIG_MFD_TI_LP873X) += lp873x.o > obj-$(CONFIG_MFD_TI_LP87565) += lp87565.o > obj-$(CONFIG_MFD_TI_AM335X_TSCADC) += ti_am335x_tscadc.o > diff --git a/drivers/mfd/psci-mfd.c b/drivers/mfd/psci-mfd.c > new file mode 100644 > index 0000000000000000000000000000000000000000..7affd6bb09dd83452664edeccb09290fe4f43186 > --- /dev/null > +++ b/drivers/mfd/psci-mfd.c > @@ -0,0 +1,43 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. > + */ > + > +#include > +#include > +#include > +#include > + > +static const struct mfd_cell psci_cells[] = { > + { > + .name = "psci-cpuidle-domain", > + }, > +}; > + > +static int psci_mfd_probe(struct platform_device *pdev) > +{ > + return devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_AUTO, psci_cells, > + ARRAY_SIZE(psci_cells), NULL, 0, NULL); > +} > + > +static const struct of_device_id psci_mfd_of_match[] = { > + { .compatible = "arm,psci-1.0" }, > + { } > +}; > + > +static struct platform_driver psci_mfd_driver = { > + .probe = psci_mfd_probe, > + .driver = { > + .name = "psci-mfd", > + .of_match_table = psci_mfd_of_match, > + }, > +}; > + > +static int __init psci_mfd_init(void) > +{ > + return platform_driver_register(&psci_mfd_driver); > +} > + > +core_initcall(psci_mfd_init); > + > +MODULE_LICENSE("GPL"); >