From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH] thermal: imx: fix for dependency on cpu-freq Date: Tue, 20 Nov 2018 09:54:29 +0100 Message-ID: References: <1540362909-32481-1-git-send-email-Anson.Huang@nxp.com> <28d501b1-8016-cc1a-3f7c-ac485ab81aa2@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Anson Huang , "rui.zhang@intel.com" , "edubezval@gmail.com" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: dl-linux-imx List-Id: linux-pm@vger.kernel.org On 20/11/2018 09:47, Anson Huang wrote: > Hi, Daniel > > Best Regards! > Anson Huang > >> -----Original Message----- >> From: Daniel Lezcano [mailto:daniel.lezcano@linaro.org] >> Sent: 2018年11月20日 16:45 >> To: Anson Huang ; rui.zhang@intel.com; >> edubezval@gmail.com; linux-pm@vger.kernel.org; >> linux-kernel@vger.kernel.org >> Cc: dl-linux-imx >> Subject: Re: [PATCH] thermal: imx: fix for dependency on cpu-freq >> >> On 24/10/2018 08:39, Anson Huang wrote: >>> The thermal driver is a standalone driver for monitoring SoC >>> temperature by enabling thermal sensor, so it can be enabled even when >>> CONFIG_CPU_FREQ is NOT set. So remove the dependency with >> CPU_THERMAL. >>> >>> Add CONFIG_CPU_FREQ check for cpu-freq related operation in thermal >>> driver to make thermal driver probe successfully when CONFIG_CPU_FREQ >>> is NOT set. >>> >>> Signed-off-by: Anson Huang >>> --- >> >> Why not simply kill this legacy code ? > > Because killing legacy code will have old dtb compatible issue, old dtb > will NOT have cpufreq cooling function. Yeah, I imagine that is the reason why you want to keep the legacy code but do you really care about old DTB based boards? Are they still updated with newer *upstream vanilla* kernels? -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog