From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>, rafael@kernel.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
rui.zhang@intel.com, amitk@kernel.org
Subject: Re: [PATCH v3 2/4] powercap: idle_inject: Add update callback
Date: Tue, 17 Jan 2023 07:08:25 -0800 [thread overview]
Message-ID: <e4f08f6642939e9707ee6427affe3d4aca06410a.camel@linux.intel.com> (raw)
In-Reply-To: <c5167eb8-22d6-c230-5828-80e59154aeb0@linaro.org>
On Tue, 2023-01-17 at 12:13 +0100, Daniel Lezcano wrote:
> On 17/01/2023 03:07, Srinivas Pandruvada wrote:
>
> [ ... ]
>
> > +struct idle_inject_device *idle_inject_register(struct cpumask
> > *cpumask)
> > +{
> > + return idle_inject_register_full(cpumask, NULL);
> > +}
> > EXPORT_SYMBOL_NS_GPL(idle_inject_register, IDLE_INJECT);
>
> Why not just add the parameter to idle_inject_register() ?
>
> There is only one user ATM
That was done in v1. But Rafael suggested to avoid changes to existing
kernel source.
Thanks,
Srinivas
>
>
next prev parent reply other threads:[~2023-01-17 15:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 2:07 [PATCH v3 0/4] Per CPU idle injection Srinivas Pandruvada
2023-01-17 2:07 ` [PATCH v3 1/4] powercap: idle_inject: Export symbols Srinivas Pandruvada
2023-01-17 9:34 ` Daniel Lezcano
2023-01-17 2:07 ` [PATCH v3 2/4] powercap: idle_inject: Add update callback Srinivas Pandruvada
2023-01-17 11:13 ` Daniel Lezcano
2023-01-17 15:08 ` srinivas pandruvada [this message]
2023-01-17 15:09 ` Rafael J. Wysocki
2023-01-19 18:01 ` srinivas pandruvada
2023-01-17 2:07 ` [PATCH v3 3/4] thermal/drivers/intel_powerclamp: Use powercap idle-inject framework Srinivas Pandruvada
2023-01-17 11:16 ` Daniel Lezcano
2023-01-17 14:49 ` Rafael J. Wysocki
2023-01-17 14:55 ` Daniel Lezcano
2023-01-17 2:07 ` [PATCH v3 4/4] thermal/drivers/intel_cpu_idle_cooling: Introduce Intel cpu idle cooling driver Srinivas Pandruvada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4f08f6642939e9707ee6427affe3d4aca06410a.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox