From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8857C63797 for ; Tue, 17 Jan 2023 15:08:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232187AbjAQPI2 (ORCPT ); Tue, 17 Jan 2023 10:08:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232334AbjAQPI1 (ORCPT ); Tue, 17 Jan 2023 10:08:27 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B10E83D0AF; Tue, 17 Jan 2023 07:08:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673968106; x=1705504106; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=SQsT0mjx5ZWHQPoOgYAo5vZEfEWYhlkbbWw1IeCzlCs=; b=NQvW33I4t9cwLOsYzP1sbxM3OjdtHnm4ecLyHnSwt6PPPeFZ9ovdWMCC V8XW96+ir6uqfWy1dskFQOPx10/XQfdkJDFE9OO8N/dOad2vkIS0y/nSW nZKzJjrg83n3H6ilI6TBB49LeViFyOwiM64EELBVUzo8Qz22QM9Ya+XVN 7r20/MIbNEmjVhb+tl/ExJKiCeq4dmFa1a5FqGJypWBHLRvoY+BisRfbI sFyeWl6Mb+Qo35J/xRonOn1Il/q9Xxd4ot/Pz1AJ7825ND8RVbHF7pXKB q98Ica1m5WJupkwK+gq/Z682wYPXjyxTSW88AlJtIscl54SAyg6pfC0Hn Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="305093299" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="305093299" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2023 07:08:26 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="689821106" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="689821106" Received: from mfmaier-mobl.amr.corp.intel.com (HELO spandruv-desk1.amr.corp.intel.com) ([10.212.214.121]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2023 07:08:26 -0800 Message-ID: Subject: Re: [PATCH v3 2/4] powercap: idle_inject: Add update callback From: srinivas pandruvada To: Daniel Lezcano , rafael@kernel.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, rui.zhang@intel.com, amitk@kernel.org Date: Tue, 17 Jan 2023 07:08:25 -0800 In-Reply-To: References: <20230117020742.2760307-1-srinivas.pandruvada@linux.intel.com> <20230117020742.2760307-3-srinivas.pandruvada@linux.intel.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, 2023-01-17 at 12:13 +0100, Daniel Lezcano wrote: > On 17/01/2023 03:07, Srinivas Pandruvada wrote: > > [ ... ] > > > +struct idle_inject_device *idle_inject_register(struct cpumask > > *cpumask) > > +{ > > +       return idle_inject_register_full(cpumask, NULL); > > +} > >   EXPORT_SYMBOL_NS_GPL(idle_inject_register, IDLE_INJECT); > > Why not just add the parameter to idle_inject_register() ? > > There is only one user ATM That was done in v1. But Rafael suggested to avoid changes to existing kernel source. Thanks, Srinivas > >