From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03F8F28CF5F for ; Mon, 12 Oct 2026 13:23:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791811406; cv=none; b=i3gNZ+NG2dYCr0fkC2zVg5vJ9HRtUS6TT+CCBJIP2CS3eaFVyGMCUOSh+xXNfg+asts8upqPUpgWNmSZXSlJ+A2m+lxtIEEEHRZjw102CRXPIRgl+myAGTVFnOqwmGiPPREKK+gbVwbb9qERt/TYTySt3hI4f7BU2FVwdQDhXw0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791811406; c=relaxed/simple; bh=R28SeeBt9BfCJhpMmjquk97CFZSG0kKrI1J07/GucNI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eo2W9We06D0SuZNoHnju2siRnHNct5ImrqbagjoHs4B85rluqKXavq02cJ2SogP2hROGT2l+xbRLrhNmWCq516s0a+8rACd0UlaWtqxoFWHU7UEAMMo4IdZcvz8/303YUfdKchNlx5TPTPMhhvnIRraeEY3Uruym+jX4wYPotFg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Wy0CFUem; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ULWMuEEv; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Wy0CFUem"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ULWMuEEv" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69CBxxBs3364522 for ; Mon, 12 Oct 2026 13:23:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HqDiWOuLptx8G+jFnl5RV+jg+K9hUTE/Qbj1fk+J+i8=; b=Wy0CFUemNZ/OOIc+ /eWdi10emTqaruTWSL/gmhM3paSbIdGW/m+yGEI31dLGX8y/jhjf6JaTNASgeqYD JXn7Fi48LQ2ice+Rwg1maVBO5BF1oEcOoBJDniwDRaGWtsg3PSkzOqYU88RrN4tI onlQPoxsNArN4hR/B/Zwh8W95MyJNDqywkg1Tkzlp65SO4xZmIN/9cSrxivcFV5A hDVwh7Ot52atWuqiyM5+BJDsC+Q1DooLOWfZTPu+kYm2KbPiFeDimg3BJhFUiWXc R57bf0KYjUA0O5ZttkVumXR9wWvehG2FaxFIluKji5Vql+aoZmnuq+WDazKlhx43 TLrxRA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4h8wdr8wpm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 12 Oct 2026 13:23:24 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-93e629c7b16so25037185a.1 for ; Mon, 12 Oct 2026 06:23:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1791811403; x=1792416203; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=HqDiWOuLptx8G+jFnl5RV+jg+K9hUTE/Qbj1fk+J+i8=; b=ULWMuEEvucm9DwfOHqiaMU1qbyigM3w4111Ffy8pdYg2HLXA0aon9+i1VkeqIl+8vF GNclsbxc+ErZseD6sthBgXXLHRAnQwCIDpBnTuO26qBGY1LBKfcF1n5lOn+8YEF5Y3Ju +rsUdSEd24hBalRTx18dbomcpBmXKggyB1Kuyle1i6Dz4Trc4zOansEbqnO+PQVBLWZ6 1HuFwMt0grKNlo3yW3Y+jnNYwr5yXARwzCuIR2CmT+L/e5kSsjl4xKow5NrQ2tOC+9Ae 0LOp/4NRxIR2mUEUrsVaUjr8lUlJ5WmVIAqWaM947IDTy9rXtP15mu66b5cgGJJ7R/Eq 342Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791811403; x=1792416203; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HqDiWOuLptx8G+jFnl5RV+jg+K9hUTE/Qbj1fk+J+i8=; b=VNg1NIAClGAp8pTj5M2DkbbtGaNN7RB7Pg/nRuSPi689757NQI4OZyZc0coU6OPHES l7uCuIk70B3rRdSpHk1+vjyGofWLPN5ZXuMyYsP5Ri98wZ0Dtgzfjz1zMMGu5OJHh1bH YjPpqSM2iMwb8V5xEzGCypNZW0cDp839n12OzcKCUxPzRGCyQdEMDP6hF8ImcxinbVg7 tklF6wgB1/5ocWI23ZxFtyOV4Qlm+XbXxwGNhCGvXOvhQtGZdoNfUn3qi6sT8qzzHToC cX2110oE8zOMQXClkH1BT1PgX9/qh4dy8ZW3hAMK3+I90fGVaMMilEm+hP0TpXewv5e/ 8oBg== X-Forwarded-Encrypted: i=1; AKwUvByxotb0ViH0sVoauGNAu9o3T/BvwCDrIXi+nOBFZCCEj0x2vOAwjNaVrYsmRMfk7Ktetw84AefSrQ==@vger.kernel.org X-Gm-Message-State: AFq9FYLGatIqcJxQErd0pRVwD3RwpNXgV6JWtaOlBydzBsty+O1AtkIn Wu3P+975EmT9wQVtlKufjfQd/2tzPNl3I+9jq9X+oRShyYpEKVj3EjoFmwCOog/6IPfmKOQb05A 8hWydu0C63VcXeXICRVHRme0AOKtUuDaDWbWezI+d9k8fs8GKCQo7prTRBLWZ9OjLAj3JtA== X-Gm-Gg: AYBFou25jMDr+Th5bClxANcXQYLSUZkewFdCT8kWeGXtWAa3mJrf4qXWkAiy0SSqU/H 99in6ZoLwo/1CkijkdfVRgmCY+5r4/QJ7CM6Dwjr07xoy4YUhSWvRQjsnXKjWaGQ/TGJ9T5fibq NXeCjuKFzffEwk0mrqptZtIFgWHxhH8LQscjI7bsJckHMW+C2EEnRJzt0unFE7J9i3tujSx1mxc bE/WUb6v2lVRro76kkIa+mMA5rCM0mWXu7TwHWW8+L7Z3qM55htFiSBuWsBXa4trFGN9X1kczdf IVf8JkjiSaEagvP9bth+6MyFiUbC5CE0R3H9WAwGNJ2p5OtU6GcVW6Bg+Q0ca4i0zGIQs9V2TUb Hva9Mef1Op33Zqw1NXfNnug== X-Received: by 2002:a05:620a:2855:b0:939:8148:1e3d with SMTP id af79cd13be357-93ebd0d7987mr1589452385a.2.1791811402916; Mon, 12 Oct 2026 06:23:22 -0700 (PDT) X-Received: by 2002:a05:620a:2855:b0:939:8148:1e3d with SMTP id af79cd13be357-93ebd0d7987mr1589448485a.2.1791811402480; Mon, 12 Oct 2026 06:23:22 -0700 (PDT) Received: from [192.168.226.26] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c31a9a9fffbsm460528366b.49.2026.10.12.06.23.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Oct 2026 06:23:21 -0700 (PDT) Message-ID: Date: Mon, 12 Oct 2026 15:23:19 +0200 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] power: supply: qcom_battmgr: report the USB type from USB_ADAP_TYPE To: Joonhoe Kim <26rote@gmail.com>, sre@kernel.org Cc: kamal.wadhwa@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20261012130053.442-1-26rote@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20261012130053.442-1-26rote@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDEyMDA1MyBTYWx0ZWRfX5RJ+na63GbwN DS4sTJ6SwzCDIHogYXmRRgzNXDREy7Je53+Ig8n4JQwYJeIcECP4waL8Lx+bzfwD4pKf79z9ruP pG2GJQIPWZkoE0uNyEqkcMZtuMKaABWRikS/UxqlrUF9EnkW6lYms9Yu86KjJ+EKDDkcv1+OQ1l 4r3zgoj8Accg4mVVX4cjHIJQ3mAIkDmfNLzeTE37KH07NUtleyw/gZEVl0WdzSH0yeo8aH/4Plq jcagHQo5nv3gLzcqNzILDAbWq8pmujX/U7DInMiXD94FiXAFjLfBXXf2T8DUcwv6uvNfLdOlSwY nKzjb66UVDTSd9uMuCipn+qGFgbgC3WOPpwcOm3HrXhHH9bOYVpmW/gQapSUlVjY/qJGglzQ/ay 5pqwTQg5ScfXZLy6LbefSg5ZrvGGDl2z0GUSm4IYPWr40ktkBXErgSAYRah8UE5I+hwg5HkgzTU tfP1ysyN0GShYULylLA== X-Authority-Analysis: v=2.4 cv=SvAFe/O0 c=1 sm=1 tr=0 ts=6accdf4c cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=pGLkceISAAAA:8 a=_5F9AhPyAwiU4pQxHRYA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDEyMDA1MyBTYWx0ZWRfX9NU2rRnybeu4 eQyX9q9OjrxjMr7DWUIpoDf+G2q2sQlP8KXFm884pBS80tm344fzzy7xs4Kn1y+K0xfspMwYt3X wHcraWSSw0XdiDaQuci7UE/IyprgUpI= X-Proofpoint-ORIG-GUID: 8gSFL4buAwiVV_fRBRvoJL1ZPcyXbM9q X-Proofpoint-GUID: 8gSFL4buAwiVV_fRBRvoJL1ZPcyXbM9q X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-12_04,2026-10-09_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 clxscore=1015 phishscore=0 bulkscore=0 priorityscore=1501 adultscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610120053 On 10/12/26 3:00 PM, Joonhoe Kim wrote: > On SM8350 and SM8550 class firmware the USB power supply reads its > usb_type from the USB_TYPE property. On a Kaanapali (SM8850) tablet that > property is 1 (SDP) whatever is plugged in, while USB_ADAP_TYPE reports > the adapter, using the same numbering as POWER_SUPPLY_USB_TYPE_*: > > PC port USB_TYPE 1 USB_ADAP_TYPE 1 (SDP) > USB-C dock, 5 V PD USB_TYPE 1 USB_ADAP_TYPE 6 (PD) > 65 W PPS charger USB_TYPE 1 USB_ADAP_TYPE 8 (PD_PPS) > > Qualcomm's downstream qti_battery_charger driver also maps > USB_ADAP_TYPE to POWER_SUPPLY_PROP_USB_TYPE. > > Request USB_ADAP_TYPE for POWER_SUPPLY_PROP_USB_TYPE instead. > > Tested on a Lenovo Legion Tab Y700 gen 5 (qcom,kaanapali-pmic-glink, > which uses the SM8550 path). Only tested on this device; the SM8350 > variant shares the property map and was not tested. > > Fixes: 29e8142b5623 ("power: supply: Introduce Qualcomm PMIC GLINK power supply") > Reviewed-by: Kamal Wadhwa > Assisted-by: LLM > Signed-off-by: Joonhoe Kim <26rote@gmail.com> > --- Reviewed-by: Konrad Dybcio Konrad